Ubuntu
gnome-control-center package

New thunderbolt panel

Bug #1773378 reported by Sebastien Bacher
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-control-center (Ubuntu)
Fix Released
High
Sebastien Bacher
Bionic
Fix Released
High
Unassigned

Bug Description

* Impact

Ubuntu 18.04 includes desktop integration for thunderbolt devices though bolt and recent GNOME integration. The settings part of the feature missed 18.04 but landed upstream since. The new panel allows to review the list of authorized devices and revoke access, see https://christian.kellner.me/2018/04/23/the-state-of-thunderbolt-3-in-fedora-28/ for details (fedora backported the feature in there recent 28 version)

* Test case

- Connect a thunderbolt device
- Accept the authentification
- Go to settings -> devices -> thunderbolt

The device should be listed as "authorized"

You can also try to disable the authorization and see that the device gets correctly denied then

* Regression impact

It's a new UI so there is no possible regression in an existing fonctionnality.

Note that the new strings have been manually added to the bionic translations template some time ago which means they should have a correct level of translations in the next langpacks update
https://lists.ubuntu.com/archives/ubuntu-translators/2018-May/007496.html

The patches serie has a small change of behaviour in that subpanel use the main settings icons now, that solves the issue were some panels didn't have a correct icon (including the thunderbolt one).

Sebastien Bacher (seb128)
Changed in gnome-control-center (Ubuntu):
importance: Undecided → High
assignee: nobody → Sebastien Bacher (seb128)
Sebastien Bacher (seb128)
Changed in gnome-control-center (Ubuntu):
status: New → Fix Committed
Jeremy Bícha (jbicha)
Changed in gnome-control-center (Ubuntu Bionic):
status: New → Triaged
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:3.28.1-0ubuntu4

---------------
gnome-control-center (1:3.28.1-0ubuntu4) cosmic; urgency=medium

  [ Andrea Azzarone ]
    * debian/patches/git_invalid_dereferencing.patch:
    - Avoid dereferencing invalid pointer (lp: #1759468)

 -- Sebastien Bacher <email address hidden> Fri, 25 May 2018 16:25:16 +0200

Changed in gnome-control-center (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Sebastien, or anyone else affected,

Accepted gnome-control-center into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.28.1-0ubuntu1.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-control-center (Ubuntu Bionic):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Betty Lin (bettyl) wrote :

Installed the 1:3.28.1-0ubuntu1.18.04.1 on 18.04 Dell XPS 13 9370 machine and tested with Dell dock TB16 BME (Thuderbolt 3 device)

After accepted the authentication, go to settings -> devices, 'Thunderbolt' listed in Devices and Dell Dock listed as "Authorized"

Sebastien Bacher (seb128)
tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:3.28.1-0ubuntu1.18.04.1

---------------
gnome-control-center (1:3.28.1-0ubuntu1.18.04.1) bionic; urgency=medium

  * debian/patches/0001-shell-Don-t-set-per-panel-icon.patch,
    debian/patches/0002-shell-Icon-name-helper-returns-symbolic-name.patch,
    debian/patches/0003-thunderbolt-new-panel-for-device-management.patch,
    debian/patches/0004-thunderbolt-move-to-the-Devices-page.patch:
    - backport the new upstream "thunderbolt" panel (same patches as fedora
      is using). Also change to not use per panel icons but just the
      settings one, that's the right thing to do and avoid issues when
      some panels like the thunderbolt one don't have a symbolic icon.
      (lp: #1773378)
  * debian/patches/git_select_panel.patch:
    - "Only try to select an existing panel on startup",
       otherwise it's possible to hit a segfault (lp: #1773382)

  [ Andrea Azzarone ]
    * debian/patches/git_invalid_dereferencing.patch:
    - Avoid dereferencing invalid pointer (lp: #1759468)

 -- Sebastien Bacher <email address hidden> Fri, 25 May 2018 15:51:57 +0200

Changed in gnome-control-center (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gnome-control-center has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.