dialog for edit via has save button not at the bottom by default

Bug #1772260 reported by Thomas Pointhuber
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
Jeff Young

Bug Description

# HowTo Reproduce

1. press 'e' on a via
2. see that the dialog does not seem correctly formated at the bottom

# Expected Behaviour

OK button is aligned to bottom of dialog as done for all other windows

Furthermore, I get the following assert on wx 3.1.1 when opening the dialog:

'''
ASSERT INFO:
./src/common/sizer.cpp(2100): assert "!(flags & wxALIGN_RIGHT)" failed in DoInsert(): Horizontal alignment flags are ignored in horizontal sizers

BACKTRACE:
[1] wxBoxSizer::DoInsert(unsigned long, wxSizerItem*)
[2] make_fcontext
'''

# System Informations

Application: kicad
Version: (5.0.0-rc2-dev-769-g8f6ae7040), debug build
Libraries:
    wxWidgets 3.1.1
    libcurl/7.60.0 OpenSSL/1.1.0h zlib/1.2.11 libidn2/2.0.4 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.31.1
Platform: Linux 4.16.9-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.1.1 (wchar_t,wx containers) GTK+ 2.24
    Boost: 1.66.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.60.0
    Compiler: Clang 6.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: pcbnew
Revision history for this message
Thomas Pointhuber (pointhi) wrote :
Revision history for this message
Jeff Young (jeyjey) wrote :

Doesn't reproduce on OSX, but I think I know what the fix is for GTK so I'll check it in and we can see.

Changed in kicad:
assignee: nobody → Jeff Young (jeyjey)
status: New → In Progress
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 62a5ee8c219decc77be10bdc4e1a5ed376a86340
https://git.launchpad.net/kicad/patch/?id=62a5ee8c219decc77be10bdc4e1a5ed376a86340

Changed in kicad:
status: In Progress → Fix Committed
Revision history for this message
Thomas Pointhuber (pointhi) wrote :

does not seem to be fixed. If you try to change the size of the dialog you would also notice that the alignment looks a bit odd and you cannot squeeze the dialog as much as expected.

https://cloud.oe5tpo.com/s/CZPC45obZzMaCZi

Application: kicad
Version: (5.0.0-rc2-dev-780-gc49a4398a), debug build
Libraries:
    wxWidgets 3.1.1
    libcurl/7.60.0 OpenSSL/1.1.0h zlib/1.2.11 libidn2/2.0.4 libpsl/0.20.2 (+libidn2/2.0.4) nghttp2/1.31.1
Platform: Linux 4.16.9-1-ARCH x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.1.1 (wchar_t,wx containers) GTK+ 2.24
    Boost: 1.66.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.60.0
    Compiler: Clang 6.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Revision history for this message
Jeff Young (jeyjey) wrote :

Ahh... that video helped. It does reproduce on Mac; you just have to size the window larger than it needs to be.

Revision history for this message
Jeff Young (jeyjey) wrote :

(Note that when the window is resized larger you will still see blank space, but it will be above the OK/Cancel rather than below.)

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 0fd0e84162153ba725fe387550e736128e975ad2
https://git.launchpad.net/kicad/patch/?id=0fd0e84162153ba725fe387550e736128e975ad2

Changed in kicad:
status: Fix Committed → New
status: New → Fix Committed
Revision history for this message
Thomas Pointhuber (pointhi) wrote :

Thanks, OK Button is now correct. The dialog, on the other hand, is still way to big on my system by default.

I also noticed a missing gap between the input field and the visible frame.

For the window title, it would be probably better to call it "Track Properties" / "Via Properties" depending on the selected item

Revision history for this message
Jeff Young (jeyjey) wrote :

All these have been fixed already in 6.0, but I think we're close enough to the 5.0 end-game that I'd rather not introduce any risk by backporting them.

Revision history for this message
Jeff Young (jeyjey) wrote :

(I see you're doing your own builds. If you want to see the current 6.0 version you can pull it from https://git.launchpad.net/~jeyjey/kicad/log/?h=6.0. It's nearly a month old but should have the Track/Via Properties stuff in it.)

Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.