scripts dont accept gnu long options ( eg --help)

Bug #177051 reported by KarlGoetz
6
Affects Status Importance Assigned to Milestone
ldapscripts (Debian)
Fix Released
Unknown
ldapscripts (Ubuntu)
Fix Released
Wishlist
Siegfried Gevatter

Bug Description

Binary package hint: ldapscripts

ldapscripts 'ldapaddgroup' and 'ldapdeletegroup' (and so probably all of them) accept --help as a thing to make, not as a request for guidance:

root@server:~# ldapaddgroup --help
Successfully added group --help to LDAP
root@server:~# file `which ldapaddgroup`
/usr/bin/ldapaddgroup: POSIX shell script text executable
root@server:~# ldapdeletegroup --help
Successfully deleted group cn=--help,ou=Group,dc=domain,dc=com from LDAP

Running Ubuntu 7.10, ldapscripts info:
apt-cache policy ldapscripts
ldapscripts:
  Installed: 1.4-2
  Candidate: 1.4-2

Tags: bitesize

Related branches

Changed in ldapscripts:
importance: Undecided → Wishlist
Revision history for this message
Andreas Wenning (andreas-wenning) wrote :
Changed in ldapscripts:
assignee: nobody → andreas-wenning
status: New → In Progress
Changed in ldapscripts:
status: Unknown → New
Revision history for this message
Andreas Wenning (andreas-wenning) wrote :

This debdiff fixes the bug.

From the changelog:
  * Adding the --help option to all scripts; shows usage. (LP: #177051)
    - Added dpatch to debian/rules and Build-Depends
    - Added debian/patches/01-help-option.dpatch

Changed in ldapscripts:
assignee: andreas-wenning → nobody
status: In Progress → Confirmed
Revision history for this message
Andreas Wenning (andreas-wenning) wrote :

Forgot to add "XSBC-Original-Maintainer". This is done now.

Revision history for this message
Siegfried Gevatter (rainct) wrote :

- Please add an entry to the changelog mentioning that you changed the Maintainer field to match the DebianMaintainerField specification. Also note that you can use the script "update-maintainer" (from package "ubuntu-dev-tools") for this rutinary task (just execute it in the source directory and it will change tha Maintainer field and note it in the changelog).

- It is best practice when patching a package from Debian with no patch system to not add one (to minimize the diff to Debian; packages using cdbs are an exception to this) or use that one you think it's Maintainer would prefer. In this case it is evident that the authors prefers simple-patchsys (not only because it's cdbs' default system but because there is a commented out line for this in debian/rules). It isn't really important, but it wouldn't be bad to use simple-patchsys instead of dpatch because of this (and to avoid the additional build dependency).

- You might consider also taking "-h" as an option to show the help. Do you think it would be apropiate, too?

Please address this issues and subscribe ubuntu-universe-sponsors again once you have a new debdiff ready (well, or don't do so; I have subscribed to this bug and will upload your next debdiff ;)).

Thanks for contributing to Ubuntu!

Changed in ldapscripts:
assignee: nobody → andreas-wenning
status: Confirmed → In Progress
Revision history for this message
Andreas Wenning (andreas-wenning) wrote :

Good idea to take both --help and -h arguments. I can see that one of the scripts (with all arguments optional) shows usage when using -h, so this is indeed appropriate.

Thanks for the feedback. Here is a new debdiff.

From the changelog:
  * Adding --help and -h to all scripts; shows usage. (LP: #177051)
    - Enabled simple-patchsys in debian/rules
    - Added debian/patches/help-options.patch
  * Modify Maintainer value to match the DebianMaintainerField
    specification.
  * Standards-Version changed to 3.7.3
    - Added Homepage field to debian/control

Changed in ldapscripts:
assignee: andreas-wenning → nobody
status: In Progress → Confirmed
Revision history for this message
Siegfried Gevatter (rainct) wrote :

Uploaded. Thanks!

Changed in ldapscripts:
assignee: nobody → rainct
status: Confirmed → In Progress
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ldapscripts - 1.7.1-2ubuntu1

---------------
ldapscripts (1.7.1-2ubuntu1) hardy; urgency=low

  * Adding --help and -h to all scripts; shows usage. (LP: #177051)
    - Enabled simple-patchsys in debian/rules
    - Added debian/patches/help-options.patch
  * Modify Maintainer value to match the DebianMaintainerField
    specification.
  * Standards-Version changed to 3.7.3
    - Added Homepage field to debian/control

 -- Andreas Wenning <email address hidden> Sat, 23 Feb 2008 15:09:03 +0100

Changed in ldapscripts:
status: Fix Committed → Fix Released
Changed in ldapscripts (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.