Containers in CI updates all packages which takes time and leads to timeouts

So we need the tripleo containers images update pushed

CentOS 7.5 was released on the evening of May 9th, so there is a lot of packages to update. We need updated container images (not sure if just updating the base image will be enough).

IMO, the actual problem is in how overcloud-prep-containers.sh works to update containers with packages built on the fly for gate jobs. As my understanding the goal of this script would be to update containers with the updated code in the review which is being gated. However, as currently implemented, this task is updating the containers with all available updates in the repos enabled in the script, including dependencies and base OS packages. Until now it hasn't been a problem because the centos updates repo is not enabled and base packages don't change after initial CentOS minor release is published. However, yesterday, CentOS 7.5 was released and published into base repo, so the script is trying to update all the base packages.

I think the best solution for this would be that overcloud-prep-containers.sh makes a smarter update selecting only the required packages to be updated, that means, the ones in the temporary repository created by DLRN as part of the oooq job.

@Alfredo, it was working so until we had problems that built packages required updated packages from base repo: https://bugs.launchpad.net/tripleo/+bug/1747986

@Sagi, yes we need to have enabled base and dependencies repo so that they are available when a package update requires it. But my point is that those packages shouldn't be updated unless they are required by the code being tested.

Let me put an example, let's say this job is running in neutron gate

1. dlrn rebuilds neutron as part of the oooq job on the fly, with the tested patch
2. It creates a "temporary repo" with only the rebuilt packages, openstack-neutron-common openstack-neutron-l3, etc...
3. we should do yum -y update openstack-neutron-common openstack-neutron-... instead of yum update -y8
4. if a new dependency has been added to the spec wich is in base repo it will be installed by rpm dependencies resolution

OK, so we have a few approaches to solve it.
1) Promote new containers based on 7.5 - promotion jobs should pass for it.
2) To update only we need to update:
  a) change to container-check script: https://github.com/imain/container-check/pull/2
  b) change to extras: https://review.openstack.org/#/c/567550/
3) to disable base os repo temporary: https://review.openstack.org/#/c/567526/

Let's turn off the container update until we get a promotion

Related fix proposed to branch: master
Review: https://review.openstack.org/567636

Turning off container updates for now https://review.openstack.org/#/c/567580/

Reviewed: https://review.openstack.org/567636
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=3f12a00533e32d894ad18627e6be1163c0dd5ad8
Submitter: Zuul
Branch: master

commit 3f12a00533e32d894ad18627e6be1163c0dd5ad8
Author: Alex Schultz <email address hidden>
Date: Thu May 10 10:18:55 2018 -0600

    Add yum update to base

    In order to handle out of date distro containers, let's add a yum update
    to the kolla base container to ensure that at the end of the base
    container build we'll have the latest base packages installed. This will
    ensure we don't hit out of date dependency bits in later containers. For
    example, we currently only have 7.4 base centos image available from the
    upstream but we're install the base repos in the base build. This would
    mean that we'd be getting 7.5 packages in later containers but might
    possibly have a mix of 7.4 and 7.5 packages installed.

    Change-Id: Ifdfc1b84b7b6a306868260611271fd49bdd594d4
    Related-Bug: #1770355

We wait for https://pypi.org/project/container-check/#history to be released by @imain and then https://review.openstack.org/567550 (Run containers update only for required packages) to be merged.
Permanent solution will be in tripleo-common, patches are in pipeline: https://review.openstack.org/#/q/I4905c35fcd45ef0fe1845857020c7e1a44c8c3d6

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/568270

Reviewed: https://review.openstack.org/568270
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5bb2fe60e325eabc604a0d8596ec137b36997ba2
Submitter: Zuul
Branch: stable/queens

commit 5bb2fe60e325eabc604a0d8596ec137b36997ba2
Author: Alex Schultz <email address hidden>
Date: Thu May 10 10:18:55 2018 -0600

    Add yum update to base

    In order to handle out of date distro containers, let's add a yum update
    to the kolla base container to ensure that at the end of the base
    container build we'll have the latest base packages installed. This will
    ensure we don't hit out of date dependency bits in later containers. For
    example, we currently only have 7.4 base centos image available from the
    upstream but we're install the base repos in the base build. This would
    mean that we'd be getting 7.5 packages in later containers but might
    possibly have a mix of 7.4 and 7.5 packages installed.

    Change-Id: Ifdfc1b84b7b6a306868260611271fd49bdd594d4
    Related-Bug: #1770355
    (cherry picked from commit 3f12a00533e32d894ad18627e6be1163c0dd5ad8)