/usr/lib/gnome-initial-setup/gnome-initial-setup:double free or corruption (!prev)

Bug #1767873 reported by errors.ubuntu.com bug bridge
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-initial-setup (Ubuntu)
Fix Released
High
Robert Ancell
Bionic
Fix Released
High
Unassigned

Bug Description

[Impact]
gnome-initial-setup might crash when completed, due to a double free. This causes a crash report to show, but the functionality to otherwise work.

[Test Case]
Check crash reports stop showing on errors.ubuntu.com

[Regression Potential]
Fix is to use correct GObject API, unlikely to cause further issues.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Robert, could you have a look?

(Ccing Didier since the e.u.c stacktrace is on the "report" page)

Changed in gnome-initial-setup (Ubuntu):
assignee: nobody → Robert Ancell (robert-ancell)
importance: Undecided → High
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I think the issue is on the C side.

I took care to not free anything returned by sysmetrics when I'm allocating C memory so that the callers does it. Looks like a double free in the disposal of the report page?

(for ref: https://github.com/ubuntu/ubuntu-report/blob/master/pkg/sysmetrics/C/libsysmetrics.go#L40)

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Confirmed it's a double free in gnome-initial-setup - we are freeing a string in dispose (), which can be called multiple times. Switch to freeing in finalize () which is only called once.

Changed in gnome-initial-setup (Ubuntu):
status: New → Triaged
description: updated
Changed in gnome-initial-setup (Ubuntu):
status: Triaged → Fix Committed
Jeremy Bícha (jbicha)
Changed in gnome-initial-setup (Ubuntu Bionic):
importance: Undecided → High
status: New → In Progress
Revision history for this message
Sebastien Bacher (seb128) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello errors.ubuntu.com, or anyone else affected,

Accepted gnome-initial-setup into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-initial-setup/3.28.0-2ubuntu6.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-initial-setup (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-initial-setup - 3.28.0-2ubuntu7

---------------
gnome-initial-setup (3.28.0-2ubuntu7) cosmic; urgency=medium

  [ Robert Ancell ]
  * debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch:
    - Fix crash on shutdown in ubuntu-report page (LP: #1767873)

  [ Spencer Bygraves ]
  * Update the "What's new" graphic to mention dock and notifications
    (LP: #1768557)

  [ Andrea Azzarone ]
  * Don't autostart if user quits the wizard before completing it
    (LP: #1768929)

  [ Jeremy Bicha ]
  * Drop debian/ubuntu-changes.png to use the version included in
    0001-Add-Ubuntu-mode-with-special-pages.patch

 -- Jeremy Bicha <email address hidden> Thu, 03 May 2018 14:06:19 -0400

Changed in gnome-initial-setup (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Not being reported with 3.28.0-2ubuntu6.1 - so marking this as verified.

tags: added: verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-initial-setup - 3.28.0-2ubuntu6.1

---------------
gnome-initial-setup (3.28.0-2ubuntu6.1) bionic; urgency=medium

  [ Robert Ancell ]
  * debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch:
    - Fix crash on shutdown in ubuntu-report page (LP: #1767873)

  [ Spencer Bygraves ]
  * Update the "What's new" graphic to mention dock and notifications
    (LP: #1768557)

  [ Andrea Azzarone ]
  * Don't autostart if user quits the wizard before completing it
    (LP: #1768929)

  [ Jeremy Bicha ]
  * Drop debian/ubuntu-changes.png to use the version included in
    0001-Add-Ubuntu-mode-with-special-pages.patch

 -- Jeremy Bicha <email address hidden> Thu, 03 May 2018 14:06:19 -0400

Changed in gnome-initial-setup (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-initial-setup has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in gnome-initial-setup (Ubuntu):
assignee: Robert Ancell (robert-ancell) → Rituraj Burhagohain (rituraj161996)
Changed in gnome-initial-setup (Ubuntu):
assignee: Rituraj Burhagohain (rituraj161996) → Robert Ancell (robert-ancell)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.