tripleo

undercloud does not expose adding additional insecure-registries for docker

Bug #1767373 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Emilien Macchi
tripleo rocky-3

Bug Description

If you're using another registry to pull down containers from that is not properly signed, you have to manually update /etc/sysconfig/docker with a new --insecure-registry configuration item because we do not currently expose this via instack-undercloud.

https://github.com/openstack/instack-undercloud/blob/8c421446d566c0a66cdae5f7752466e2012e1515/elements/puppet-stack-config/puppet-stack-config.yaml.template#L798

I'm not sure if we have a similar thing for containerized undercloud either.

Emilien Macchi (emilienm)
Changed in tripleo:
assignee: nobody → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to instack-undercloud (master)

Fix proposed to branch: master
Review: https://review.openstack.org/564885

Changed in tripleo:
status: Triaged → In Progress
Bogdan Dobrelya (bogdando)
tags: added: upgrade
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to instack-undercloud (master)

Reviewed: https://review.openstack.org/564885
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=2ee1ebfd34d72a91311ed7683c272b070fde61ea
Submitter: Zuul
Branch: master

commit 2ee1ebfd34d72a91311ed7683c272b070fde61ea
Author: Emilien Macchi <email address hidden>
Date: Fri Apr 27 13:58:47 2018 -0700

    Introduce docker_insecure_registries parameter

    Introduce docker_insecure_registries that is an array of host/port
    combiniations of docker insecure registries. The default value will
    be the previous parameter that were hardcoded, but now we can easily
    override it in undercloud.conf.

    Note: the feature is already supported for the containerized undercloud
    but was only missing in instack-undercloud. This patch will be
    backported.

    Depends-On: I14fda3481ac88429648bed8edb2f4469b33be957
    Change-Id: I402ebb80b1d755cdb0c3c28fd542121bc60cb144
    Closes-Bug: #1767373

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to instack-undercloud (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/565505

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to instack-undercloud (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/565507

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to instack-undercloud (stable/queens)

Reviewed: https://review.openstack.org/565505
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=68b7bfb36f22fee7b0a96c84dc845a6c3ee66d83
Submitter: Zuul
Branch: stable/queens

commit 68b7bfb36f22fee7b0a96c84dc845a6c3ee66d83
Author: Emilien Macchi <email address hidden>
Date: Fri Apr 27 13:58:47 2018 -0700

    Introduce docker_insecure_registries parameter

    Introduce docker_insecure_registries that is an array of host/port
    combiniations of docker insecure registries. The default value will
    be the previous parameter that were hardcoded, but now we can easily
    override it in undercloud.conf.

    Note: the feature is already supported for the containerized undercloud
    but was only missing in instack-undercloud. This patch will be
    backported.

    Depends-On: I14fda3481ac88429648bed8edb2f4469b33be957
    Change-Id: I402ebb80b1d755cdb0c3c28fd542121bc60cb144
    Closes-Bug: #1767373
    (cherry picked from commit 2ee1ebfd34d72a91311ed7683c272b070fde61ea)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to instack-undercloud (stable/pike)

Reviewed: https://review.openstack.org/565507
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=bdafdfa746d66b4839b13d491a294bc3ae2e1253
Submitter: Zuul
Branch: stable/pike

commit bdafdfa746d66b4839b13d491a294bc3ae2e1253
Author: Emilien Macchi <email address hidden>
Date: Fri Apr 27 13:58:47 2018 -0700

    Introduce docker_insecure_registries parameter

    Introduce docker_insecure_registries that is an array of host/port
    combiniations of docker insecure registries. The default value will
    be the previous parameter that were hardcoded, but now we can easily
    override it in undercloud.conf.

    Note: the feature is already supported for the containerized undercloud
    but was only missing in instack-undercloud. This patch will be
    backported.

    Depends-On: I14fda3481ac88429648bed8edb2f4469b33be957
    Change-Id: I402ebb80b1d755cdb0c3c28fd542121bc60cb144
    Closes-Bug: #1767373
    (cherry picked from commit 2ee1ebfd34d72a91311ed7683c272b070fde61ea)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/instack-undercloud 7.4.12

This issue was fixed in the openstack/instack-undercloud 7.4.12 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/instack-undercloud 8.4.2

This issue was fixed in the openstack/instack-undercloud 8.4.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/instack-undercloud 9.1.0

This issue was fixed in the openstack/instack-undercloud 9.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/582971
Reason: tripleo gate is now broken, I'm clearing the gate. Please do not recheck or restore this patch, I'll take care of it when things work again.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/582971
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b1a31a70fd27a4dcfcf1a3ec7f4790bf6c3a8b57
Submitter: Zuul
Branch: master

commit b1a31a70fd27a4dcfcf1a3ec7f4790bf6c3a8b57
Author: Emilien Macchi <email address hidden>
Date: Mon Jul 16 11:12:33 2018 -0400

    Allow operators to override docker_insecure_registries

    Allow the operators to override the INSECURE_REGISTRY parameter without
    hardcoding the local_ip and the admin VIP in all the cases.
    If the operators want to override the whole parameter, they now can with
    docker_insecure_registries parameter in undercloud.conf.

    Related-Bug: #1767373
    Change-Id: I2f734f603dd29e8b46bc6cf0c7af7c92488f0818

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.