Tempest API tests failing for stable/queens branch

I think that we should add shim API extension to Neutron to make discoverable standard attributes for segments are available or not.
Then we will be able to use it in tempest tests to skip test if this feature is not available

@Slawek,

+1. In addition, I think we should also trigger jobs of each stable branch against changes in neutron-tempest-plugin as well.

Perhaps, it can be fixed by a backport: https://review.openstack.org/#/c/562298/

Revert: https://review.openstack.org/562305

Fix proposed to branch: master
Review: https://review.openstack.org/562320

Related fix proposed to branch: master
Review: https://review.openstack.org/562331

The test is failing in tripleo as well:-
master:- https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-master/63a5b7a/undercloud/home/jenkins/tempest/tempest.html.gz
Queens:- https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-ovb-1ctlr_1comp-featureset020-queens/a1bc8c7/undercloud/home/jenkins/tempest/tempest.html.gz

https://review.openstack.org/#/c/562324/ should fix the issue.

Reviewed: https://review.openstack.org/562320
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9506044550ca0eab31612f0f1228eb30b2150532
Submitter: Zuul
Branch: master

commit 9506044550ca0eab31612f0f1228eb30b2150532
Author: Hongbin Lu <email address hidden>
Date: Wed Apr 18 15:41:45 2018 +0000

    Add a shim extension standard-attr-segment

    Standard attributes has been added to segment [1] and we need
    a shim extension to indicate this.

    [1] https://review.openstack.org/#/c/558318/

    Change-Id: I761fa7cb684a457726dedc95fde92d6adb86f5e4
    Partial-Bug: #1765008

Still failing after https://review.openstack.org/#/c/562324/, looks we need "segments" plugin as well but we don't have it, So we should add this test to skip list for queens and master.

<<< Still failing after https://review.openstack.org/#/c/562324/, looks we need "segments" plugin as well <<< but we don't have it, So we should add this test to skip list for queens and master.
    Proposed: https://review.openstack.org/562902 to add test to the skip list.

Related fix proposed to branch: master
Review: https://review.openstack.org/562932

Reviewed: https://review.openstack.org/562902
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=d90770fcabcabb14aef92980aae0ea5cfa4f0b68
Submitter: Zuul
Branch: master

commit d90770fcabcabb14aef92980aae0ea5cfa4f0b68
Author: yatin <email address hidden>
Date: Fri Apr 20 07:48:59 2018 +0530

    Add test_segment_with_timestamp to skip list

    [1] Added the test in neutron-tempest-plugin,
    looks like it needs "segments" plugin and we don't
    have it enabled in tripleo, so until it's fixed skip
    the affected test.

    [1] https://review.openstack.org/#/c/558609/

    Related-Bug: #1765008
    Change-Id: I37c96d8446cb222efbc6454934fa3eddfefe2d25

Removed the promotion-blocker tag, the commit to add the test to the skip list https://review.openstack.org/562902 has been merged.

neutron part of the issue has been fixed

i think i misunderstood.
it seems the sim extension "standard-attr-segment" was added to ml2 plugin.
i suspect it should be in the segment service plugin instead.

Fix proposed to branch: master
Review: https://review.openstack.org/563995

Reviewed: https://review.openstack.org/562932
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bc3600b3628605436834d4712a745dfe9c43ddf4
Submitter: Zuul
Branch: master

commit bc3600b3628605436834d4712a745dfe9c43ddf4
Author: yatin <email address hidden>
Date: Fri Apr 20 10:06:15 2018 +0530

    Add neutron "segments" plugin to the default list

    [1] Added a tests which requires "segments" plugin but
    we don't have it enabled in overcloud. It is enabled in
    neutron jobs from long[2]. This patch adds this plugin
    to the default enabled plugins.

    [1] https://review.openstack.org/#/c/558609/
    [2] https://review.openstack.org/#/c/459439/

    Related-Bug: #1765008
    Change-Id: I1bc36c4533dcaadd81d7c93a194e9319217c69cd

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/564378

Reviewed: https://review.openstack.org/563995
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e36a2bd65c65d7dad15579aa86bb5fe6614a40ab
Submitter: Zuul
Branch: master

commit e36a2bd65c65d7dad15579aa86bb5fe6614a40ab
Author: Hongbin Lu <email address hidden>
Date: Tue Apr 24 14:59:23 2018 +0000

    Move standard-attr-segment to service plugin

    Standard attributes was added to segment resource at [1].
    In [2], a shim extension standard-attr-segment was added to ml2
    plugin to indicate this change, but this extension should be
    placed to segment service plugin instead. This commit fixes it.

    [1] https://review.openstack.org/#/c/558318/
    [2] https://review.openstack.org/#/c/562320/

    Change-Id: I5b0a6bafd1e3f4552e32809a449868d7a5868739
    Closes-Bug: #1765008

Reviewed: https://review.openstack.org/564378
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9d746aa49f1eb17d6d709c6f350fa08507b1aaaf
Submitter: Zuul
Branch: stable/queens

commit 9d746aa49f1eb17d6d709c6f350fa08507b1aaaf
Author: yatin <email address hidden>
Date: Fri Apr 20 10:06:15 2018 +0530

    Add neutron "segments" plugin to the default list

    [1] Added a tests which requires "segments" plugin but
    we don't have it enabled in overcloud. It is enabled in
    neutron jobs from long[2]. This patch adds this plugin
    to the default enabled plugins.

    [1] https://review.openstack.org/#/c/558609/
    [2] https://review.openstack.org/#/c/459439/

    Related-Bug: #1765008
    Change-Id: I1bc36c4533dcaadd81d7c93a194e9319217c69cd
    (cherry picked from commit bc3600b3628605436834d4712a745dfe9c43ddf4)

Reviewed: https://review.openstack.org/562331
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=9de5b2ee02afc3020dcda1529288deabfbab33e8
Submitter: Zuul
Branch: master

commit 9de5b2ee02afc3020dcda1529288deabfbab33e8
Author: Hongbin Lu <email address hidden>
Date: Wed Apr 18 16:09:33 2018 +0000

    Add a shim extension standard-attr-segment

    Neutron patch: https://review.openstack.org/#/c/562320/

    Change-Id: I34616a01c6fc0617984272d577650420233041e1
    Related-Bug: #1765008
    Related-Bug: #1760902

This issue was fixed in the openstack/neutron 13.0.0.0b2 development milestone.

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/794957

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/794957
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Reviewed: https://review.opendev.org/c/openstack/neutron/+/794957
Committed: https://opendev.org/openstack/neutron/commit/3ac4b0d634057fbc0f4c031e3e3e43079871d4e9
Submitter: "Zuul (22348)"
Branch: master

commit 3ac4b0d634057fbc0f4c031e3e3e43079871d4e9
Author: Slawek Kaplonski <email address hidden>
Date: Sat Jun 5 12:31:49 2021 +0200

    Remove _standard_attr_segment_lib and use definition from neutron-lib

    It is available in Neutron lib since version 1.16 so pretty long time
    now.

    Also use segment api definition from neutron-lib, it's available
    since version 1.19.0. The api definition from neutron-lib also
    avoids circulary dependency b/w standard-attr-segment and segment
    extension[1].

    [1] https://review.opendev.org/c/openstack/neutron-lib/+/577866

    Change-Id: I13699f8c494a15d8bb9e13f767f2725f7cab9f4f
    Related-Bug: #1765008