tripleo

instack-undercloud: issues with net_config_override

Bug #1764507 reported by Dan Prince
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Dan Prince
tripleo rocky-2

Bug Description

Trying to use net_config_override=<empty file> with instack. At first this appeared to work but it causes puppet errors.

On a retry we also discovered that the IP validations in instack have a hard coded check to use /etc/os-net-config/config.json instead of the override file. So it failed even earlier.

Also, the comment in undercloud.conf references instack-undercloud/elements/undercloud-stack-config/net-config.json.template which no longer exists.

All of the above should be fixed to make this feature more usable.

Tags: ux
Dan Prince (dan-prince)
Changed in tripleo:
assignee: nobody → Dan Prince (dan-prince)
importance: Undecided → High
status: New → In Progress
Dan Prince (dan-prince)
summary: - instack: issues with net_config_override
+ instack-undercloud: issues with net_config_override
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tripleo (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/563935

Bogdan Dobrelya (bogdando)
Changed in tripleo:
milestone: none → rocky-2
tags: added: ux
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to instack-undercloud (master)

Fix proposed to branch: master
Review: https://review.openstack.org/563937

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/564227

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/563935
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=203083e97d89404f96f1528772d7e458b1864f8b
Submitter: Zuul
Branch: master

commit 203083e97d89404f96f1528772d7e458b1864f8b
Author: Dan Prince <email address hidden>
Date: Tue Apr 24 08:55:05 2018 -0400

    Only run os-net-config if file has content

    Instack undercloud allows the user to specify their own
    os-net-config overrides file. This file currently cannot be empty
    because it causes an exception in this puppet manifest.

    This patch skips running os-net-config if the config file has no
    data and allows the user a means to disable os-net-config from running
    if they choose to do so.

    Related bug: #1764507

    Change-Id: I69eb812af2d653cb3eb29694ae29b57ebb2de53d

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to instack-undercloud (master)

Reviewed: https://review.openstack.org/563937
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=c64a1c823e021b050c7eccaee1c42f4040b6b4e8
Submitter: Zuul
Branch: master

commit c64a1c823e021b050c7eccaee1c42f4040b6b4e8
Author: Dan Prince <email address hidden>
Date: Tue Apr 24 08:57:34 2018 -0400

    Fix net_config_override validations

    There is an issue with the _validate_no_ip_change function
    where it doesn't work correctly with a custom net_config_override
    file.

    This patch resolves validation issue so that custom os-net-config
    templates are taken into account. Additionally it makes it so
    that the net_config_override can be empty, thus providing the
    user a means of disabling os-net-config if they choose to do so.

    Change-Id: Iada099a6bddc7927d26b19776e705b1ac231b2e5
    Depends-On: I69eb812af2d653cb3eb29694ae29b57ebb2de53d
    Closes-bug: #1764507

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/564227
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=aaee4e42a0b723d119ef27f9a504cdb28180c475
Submitter: Zuul
Branch: master

commit aaee4e42a0b723d119ef27f9a504cdb28180c475
Author: Dan Prince <email address hidden>
Date: Wed Apr 25 09:51:51 2018 -0400

    Fix net_config_override validations

    There is an issue with the _validate_no_ip_change function
    where it doesn't work correctly with a custom net_config_override
    file.

    This patch resolves validation issue so that custom os-net-config
    templates are taken into account. Additionally it makes it so
    that the net_config_override can be empty, thus providing the
    user a means of disabling os-net-config if they choose to do so.

    Change-Id: I127c2742522e695dd1fd15413a47bf4d8ebea8fa
    Related-bug: #1764507

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/instack-undercloud 9.1.0

This issue was fixed in the openstack/instack-undercloud 9.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.