[SRU] dpkg zstd support
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| dpkg |
Fix Released
|
Unknown
|
|||
| dpkg (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Xenial |
Fix Released
|
Undecided
|
Balint Reczey | ||
Bug Description
[Impact]
* Xenial's dpkg can't decompress zstd-compressed binary packages preventing some systems of Launchpad from processing packages with such compression. This blocks publishing zstd-compressed binary packages through Launchpad for later Ubuntu releases as well.
[Test Plan]
* https:/
* Download and unpack it. With unfixed dpkg an error should be shown.
$ wget https:/
# unfixed:
$ dpkg-deb -R glibc-doc-
dpkg-deb: error: archive 'glibc-
# fixed
$ time dpkg-deb -R glibc-doc-
real 0m0.148s
user 0m0.041s
sys 0m0.124s
* Also install the package:
root@x-zstd:~# dpkg -i glibc-doc-
Selecting previously unselected package glibc-doc-
(Reading database ... 25816 files and directories currently installed.)
Preparing to unpack glibc-doc-
Unpacking glibc-doc-reference (2.33-0ubuntu2~
Setting up glibc-doc-reference (2.33-0ubuntu2~
Processing triggers for install-info (6.1.0.dfsg.1-5) ...
root@x-zstd:~#
* Build the hello package, it should work
* Build the hello package overriding the compression to zstd, this should fail:
$ cat debian/rules
...
override_
dh_builddeb -- -Zzstd
...
make[1]: Entering directory '/root/hello-2.10'
dh_builddeb -- -Zzstd
dpkg-deb: error: only decompression is supported for 'zstd'!
Type dpkg-deb --help for help about manipulating *.deb files;
Type dpkg --help for help about installing and deinstalling packages.
dh_builddeb: dpkg-deb -Zzstd --build debian/hello .. returned exit code 2
debian/rules:12: recipe for target 'override_
[Where problems could occur]
* The fix is isolated and is a backport from Bionic with the compression part omitted. Crashes could happen due to coding errors should they exist.
Only decompression should be supported and this is verified in the test plan.
* Incompabilities between libzstd present in Xenial and present in later releases could prevent dpkg running on Xenial from successfully processing packages built on later releases. The package for Xenial is built with libzstd1 (build-depending on libzstd1-dev) which is at version 1.3.1+dfsg-
[Original Bug Text]
As discussed previously, we want to have zstd support in 18.04 to evaluate and potentially enable it in later releases.
The zstd support adds a dependency on libzstd1 to dpkg. This should not have any effect on live images, since libzstd1 is part of the various live tasks, as btrfs-progs need it. For installed systems, this might be a new dependency (if they do not use btrfs, tor, or some other tools), so an increase of ~520 KB, as that's the size of the library and the library only depends on libc6.
The change is isolated, it adds the compressor and decompressor to dpkg, please see the attached patch for the details.
The change is being discussed here:
https:/
https:/
Related branches
- Steve Langasek: Approve
-
Diff: 11 lines (+3/-0)1 file modifiedubuntu-sru (+3/-0)
- Steve Langasek: Approve
-
Diff: 11 lines (+3/-0)1 file modifiedubuntu-sru (+3/-0)
| Balint Reczey (rbalint) wrote | #1 |
| Łukasz Zemczak (sil2100) wrote | #2 |
| Changed in dpkg (Ubuntu): | |
| status: | New → Triaged |
| tags: | added: id-5a9f9b96fff3bd2877ffa9de |
| Changed in dpkg: | |
| status: | Unknown → New |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in dpkg (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in dpkg: | |
| status: | New → Incomplete |
| summary: |
- [FFe] dpkg zstd support + [SRU] dpkg zstd support |
| Changed in dpkg (Ubuntu Xenial): | |
| assignee: | nobody → Balint Reczey (rbalint) |
| description: | updated |
| description: | updated |
| description: | updated |
| description: | updated |
| description: | updated |
| Steve Langasek (vorlon) wrote Please test proposed package | #4 |
| Changed in dpkg (Ubuntu Xenial): | |
| status: | New → Fix Committed |
| tags: | added: verification-needed verification-needed-xenial |
| Ubuntu SRU Bot (ubuntu-sru-bot) wrote Autopkgtest regression report (dpkg/1.18.4ubuntu1.7) | #5 |
| Balint Reczey (rbalint) wrote | #6 |
| tags: |
added: verification-done verification-done-xenial removed: verification-needed verification-needed-xenial |
| Brian Murray (brian-murray) wrote Update Released | #7 |
| Launchpad Janitor (janitor) wrote | #8 |
| Changed in dpkg (Ubuntu Xenial): | |
| status: | Fix Committed → Fix Released |
| Changed in dpkg: | |
| status: | Incomplete → Fix Released |
Since it's a non-invasive feature (+ we're already +1 on it for apt), FFe approved. Please proceed!