MAAS

[2.4, UI, regression] Details page actions (e.g. machine details) has all actions instead of actions per status

Bug #1763831 reported by Andres Rodriguez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Lee Trager
MAAS 2.4.0beta2

Bug Description

Previously, the machine details page only had access for the machine depending on the status.

This has now regressed and its showing all available actions even if they don't apply for the machine status.

See original description

Related branches

~ltrager/maas:lp1763831
Blake Rouse (community): Approve
MAAS Lander: Approve
Diff: 53 lines (+29/-1)
2 files modified
src/maasserver/static/js/angular/controllers/node_details.js (+2/-1)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+27/-0)
Andres Rodriguez (andreserl)
Changed in maas:
importance: Undecided → Critical
status: New → Triaged
milestone: none → 2.4.0beta3
tags: added: vanilla-transition
Changed in maas:
milestone: 2.4.0beta3 → 2.4.0beta2
Revision history for this message
Andres Rodriguez (andreserl) wrote : Re: [2.4, regression] Details page actions (e.g. machine details) has all actions instead of actions per status

@Ant,

I'm not quite sure what branch has regressed this, but I've assigned it to you since I believe you guys were doing improvements around the area.

Changed in maas:
assignee: nobody → Anthony Dillon (ya-bo-ng)
summary: - [2.4] Details page (e.g. machine details) has all actions instead of
- actions per status
+ [2.4] Details page actions (e.g. machine details) has all actions
+ instead of actions per status
summary: - [2.4] Details page actions (e.g. machine details) has all actions
- instead of actions per status
+ [2.4, regression] Details page actions (e.g. machine details) has all
+ actions instead of actions per status
description: updated
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Actually, I believe I've found which branch regressed this.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

I think this branch regressed this:

6a492283ffee14fb37dffcc008124e9edad92221

Changed in maas:
assignee: Anthony Dillon (ya-bo-ng) → Lee Trager (ltrager)
Revision history for this message
Andres Rodriguez (andreserl) wrote :

- // Build the available action options control from the
- // allowed actions, except set-zone which does not make
- // sense in this view because the form has this
- // functionality
- angular.forEach($scope.action.allOptions, function(option) {
- if($scope.node.actions.indexOf(option.name) >= 0
- && option.name !== "set-zone") {
- $scope.action.availableOptions.push(option);
- }
- });

tags: removed: vanilla-transition
summary: - [2.4, regression] Details page actions (e.g. machine details) has all
- actions instead of actions per status
+ [2.4, UI, regression] Details page actions (e.g. machine details) has
+ all actions instead of actions per status
Andres Rodriguez (andreserl)
Changed in maas:
importance: Critical → High
MAAS Lander (maas-lander)
Changed in maas:
status: Triaged → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.