slirp: Add domainname option to slirp's DHCP server

Bug #1762315 reported by Christian Ehrhardt 
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qemu (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

This is a spin off from bug 1753938.

TL;DR:
- there was a 3rd party upload on 1st of March with two features
- one might have been ok (one day late but ok otherwise)
- but the other was breaking FFE and maintainability
- I reverted and discussed this in bug 1753938
- We agreed to try taking the small and maintainable change for Bionic

Details on the Change:
- it is available a while at http://patchwork.ozlabs.org/patch/878667/
- It is in the subtree maintainers tree a while now
  Samuel Thibault <email address hidden> took it into the subtree
- will (most likely) be in qemu 2.13 due to the subtree pull then
- It was in Bionic from 5th to 22nd March already and there were no complains/reports on it

By breaking out the 2nd change (that was more complex and had potential maintenance issues in qmp format) this would be a great candidate to make Bionic better.

As mentioned it was already tested and in Bionic for a while, so the change really should be good.
Also in terms of "potential regression risk" it is limited to slirp which is less commonly used in "enterprisy" environments, but a useful feature in general still.

I'm readding the change and would be ready to puload together with a bunch of others that are queued up.
But while it is small, but it is a feature, so I'd need an FFE ack for this to process it further.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Polling for a quick FFE ack by the Release Team on IRC now ...

description: updated
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is like the forth time or so these changes are part of the regression testing, but one can never be sure - running soon (again)

Therefore build started in ppa for next qemu: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3225

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Seeing that the change is mostly confined to slirp and relatively low-profile, I suppose we can get that in still. FFe approved.

Changed in qemu (Ubuntu):
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qemu - 1:2.11+dfsg-1ubuntu6

---------------
qemu (1:2.11+dfsg-1ubuntu6) bionic; urgency=medium

  * Remove LP: 1752026 changes to d/p/ubuntu/define-ubuntu-machine-types.patch.
    The Kernel fixes are preferred and already committed to the kernel.
    Therefore remove the default disabling of the HTM feature (LP: #1761175)
  * d/p/ubuntu/lp1739665-SSE-AVX-AVX512-cpu-features.patch: Enable new
    SSE/AVX/AVX512 cpu features (LP: #1739665)
  * d/p/ubuntu/lp1740219-continuous-space-commpage.patch: make Arm
    space+commpage continuous which avoids long startup times on
    qemu-user-static (LP: #1740219)
  * d/p/ubuntu/lp-1761372-*: provide pseries-bionic-2.11-sxxm type as
    convenience with all meltdown/spectre workarounds enabled by default.
    This is not the default type following upstream and x86 on that.
    (LP: #1761372).
  * d/p/ubuntu/lp-1704312-1-* provide means to manually handle filesystem-dax
    with pmem by backporting align and unarmed options (LP: #1704312).
  * d/p/ubuntu/lp-1762315-slirp-Add-domainname.patch: slirp: Add domainname
    option to slirp's DHCP server (LP: #1762315)

 -- Christian Ehrhardt <email address hidden> Wed, 04 Apr 2018 15:16:07 +0200

Changed in qemu (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.