Shift of conntrackd to systemd notification causes upgrade issues from Xenial

Hi Mark,

Thanks for reporting this.

Does this look like the error that you hit? https://paste.ubuntu.com/p/4bv3PGBfMF/

I wasn't able to reproduce this using the default package config when upgrading conntrackd from xenial to bionic, however if I remove "Systemd on" from the bionic config file (/etc/conntrackd/conntrackd.conf), it fails due to timeout as shown in the above paste.

I have the broken package built in the following PPA in case anyone wants to test:

sudo add-apt-repository ppa:corey.bryant/bionic-queens
sudo apt update

Note: That particular issue appears to have been fixed in artful and bionic via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835384. However if you're not using the default config provided by the bionic package then it's possible you'd hit it on upgrade.

Thanks,
Corey

Yes, the issue is on upgrade, where if you don't add the 'Systemd on'
config, it fails.

Since the package is built with --enable-systemd I don't see why we wouldn't default the config to 'Systemd on'. I'm going to look into patching this.

I've uploaded conntrack-tools 1:1.4.4+snapshot20161117-6ubuntu2 to bionic. This version of the package defaults to using 'Systemd on' for conntrackd config. I tested upgrades from xenial to bionic with the following in the bionic config /etc/conntrackd/conntrackd.conf:

1) 'Systemd on' # upgrade is successful
2) Systemd config not specified # upgrade is successful (defaults to 'Systemd on')
3) 'Systemd off' # upgrade fails as expected with timeout

I'll submit the patch back to Debian as well.

Note: The package in my ppa now has the new package version.

Just to be clear, the new version of the package patches the conntrackd code to default to 'Systemd on', as opposed to requiring 'Systemd on' in /etc/conntrackd/conntrackd.conf.

Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895826

This bug was fixed in the package conntrack-tools - 1:1.4.4+snapshot20161117-6ubuntu2

---------------
conntrack-tools (1:1.4.4+snapshot20161117-6ubuntu2) bionic; urgency=medium

  * d/p/enable-runtime-systemd.patch: Enable systemd runtime support by
    default since the package is compiled with --enable-systemd
    (LP: #1761994).

 -- Corey Bryant <email address hidden> Mon, 16 Apr 2018 09:21:40 -0400

Ah, elegant approach, BUT we'll need to maintain that patch carefully if
it doesn't get upstreamed, a lazy future merge will just cause the
problem to resurface.

Mark