[2.4, UI] Containers should be called containers, not devices
Bug #1761269 reported by
Dean Henrichsmeyer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Mike Pontillo | ||
Bug Description
When you have LXD containers deployed and LXD talks to MAAS, you nicely see a list of your containers in the containers tab on the machine detail page.
That being said, if you look at the subnet that those containers are on, they're called "devices" in MAAS even though MAAS clearly knows they're containers. They should be called containers on the subnet page too, not devices.
Related branches
~mpontillo/maas:subnet-details-show-containers--bug-1761269
- Andres Rodriguez (community): Approve
- Newell Jensen (community): Approve
- MAAS Lander: Approve
-
Diff: 48 lines (+14/-0)3 files modifiedsrc/maasserver/models/staticipaddress.py (+1/-0)
src/maasserver/static/js/angular/controllers/subnet_details.js (+4/-0)
src/maasserver/static/js/angular/controllers/tests/test_subnet_details.js (+9/-0)
| summary: |
- Containers should be called containers, not devices + [2.4] Containers should be called containers, not devices |
| Changed in maas: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| assignee: | nobody → Mike Pontillo (mpontillo) |
| milestone: | none → 2.4.0beta2 |
| summary: |
- [2.4] Containers should be called containers, not devices + [2.4, UI] Containers should be called containers, not devices |
| Changed in maas: | |
| milestone: | 2.4.0beta2 → 2.4.0rc1 |
| Changed in maas: | |
| status: | Triaged → In Progress |
Revision history for this message
| Mike Pontillo (mpontillo) wrote | #1 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| milestone: | 2.4.0rc1 → 2.4.0beta3 |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Some technical background: MAAS models containers as "devices" internally. This is why they show up as "devices". A "device", to MAAS, is something on the network that MAAS knows about which is "unmanaged" (can't be deployed). So that's why they appear that way.
If the IP address is associated with a node, the subnet details page uses the node's type to determine what to show.
To fix this issue, we need to amend the `node_summary` object for each IP address (populated in maasserver/