[2.4, websockets] Only request and send what is needed on node list websocket
Bug #1759091 reported by
Lee Trager
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Lee Trager | ||
| 2.3 |
Triaged
|
High
|
Unassigned | ||
Bug Description
The websocket handler allows the output to change whether the request is a get or list. However it only has one queryset. The node object prefetches everything it needs for the detailed view even when listing. The websocket should only be pulling from the database what it is actually going to send to the client.
Node listing is also sending alot of information not used on the listing page. Only data actually needed to render the page should be fetched from the database and sent.
Related branches
~ltrager/maas:2.3_1759091
- Blake Rouse (community): Approve
-
Diff: 992 lines (+325/-152)16 files modifiedsrc/maasserver/third_party_drivers.py (+3/-2)
src/maasserver/websockets/base.py (+8/-4)
src/maasserver/websockets/handlers/controller.py (+17/-8)
src/maasserver/websockets/handlers/device.py (+15/-7)
src/maasserver/websockets/handlers/event.py (+1/-1)
src/maasserver/websockets/handlers/machine.py (+36/-30)
src/maasserver/websockets/handlers/node.py (+69/-50)
src/maasserver/websockets/handlers/notification.py (+2/-2)
src/maasserver/websockets/handlers/sshkey.py (+1/-1)
src/maasserver/websockets/handlers/switch.py (+7/-3)
src/maasserver/websockets/handlers/tests/test_controller.py (+69/-1)
src/maasserver/websockets/handlers/tests/test_device.py (+19/-4)
src/maasserver/websockets/handlers/tests/test_machine.py (+54/-15)
src/maasserver/websockets/handlers/tests/test_switch.py (+1/-20)
src/maasserver/websockets/handlers/user.py (+3/-3)
src/maasserver/websockets/tests/test_base.py (+20/-1)
~ltrager/maas:limit_listing_queries
- Blake Rouse (community): Approve
- MAAS Lander: Needs Fixing
-
Diff: 995 lines (+323/-165)16 files modifiedsrc/maasserver/third_party_drivers.py (+3/-2)
src/maasserver/websockets/base.py (+8/-4)
src/maasserver/websockets/handlers/controller.py (+17/-8)
src/maasserver/websockets/handlers/device.py (+15/-7)
src/maasserver/websockets/handlers/event.py (+1/-1)
src/maasserver/websockets/handlers/machine.py (+37/-43)
src/maasserver/websockets/handlers/node.py (+65/-49)
src/maasserver/websockets/handlers/notification.py (+2/-2)
src/maasserver/websockets/handlers/sshkey.py (+1/-1)
src/maasserver/websockets/handlers/switch.py (+7/-3)
src/maasserver/websockets/handlers/tests/test_controller.py (+69/-1)
src/maasserver/websockets/handlers/tests/test_device.py (+19/-4)
src/maasserver/websockets/handlers/tests/test_machine.py (+55/-16)
src/maasserver/websockets/handlers/tests/test_switch.py (+1/-20)
src/maasserver/websockets/handlers/user.py (+3/-3)
src/maasserver/websockets/tests/test_base.py (+20/-1)
| Changed in maas: | |
| milestone: | 2.4.0alpha2 → 2.4.0beta1 |
| summary: |
- Only request and send what is needed on node list websocket + [2.4, websocket] Only request and send what is needed on node list + websocket |
| summary: |
- [2.4, websocket] Only request and send what is needed on node list + [2.4, websockets] Only request and send what is needed on node list websocket |
| Changed in maas: | |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
