Glance Client

image-create-via-import does not fail with missing {container,disk}-format for web-download method

Bug #1757927 reported by Brian Rosmaita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Critical
Brian Rosmaita
Glance Client 2.11.0 "rocky-1"
Queens
Fix Released
Critical
Brian Rosmaita
Glance Client 2.10.0 "queens-bugfix-1"

Bug Description

When calling image-create-via-import with --import-method glance-direct, the call fails if container_format or disk_format are missing. This doesn't happen with the web-download method. We want it to happen because otherwise the API will error out when the task is processed, but at that point it's too late to get info back to the user.

OpenStack Infra (hudson-openstack)
Changed in python-glanceclient:
status: Triaged → In Progress
Revision history for this message
Brian Rosmaita (brian-rosmaita) wrote :

Patch proposed to master: https://review.openstack.org/#/c/555148/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/555390

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (stable/queens)

Reviewed: https://review.openstack.org/555390
Committed: https://git.openstack.org/cgit/openstack/python-glanceclient/commit/?id=91c19dddddd6b7ba4a9c3ab6ec23cab64b481c3c
Submitter: Zuul
Branch: stable/queens

commit 91c19dddddd6b7ba4a9c3ab6ec23cab64b481c3c
Author: Brian Rosmaita <email address hidden>
Date: Thu Mar 22 01:13:38 2018 -0400

    Check for container,disk_format on web-download

    Fail image-create-via-import requests for the web-download import
    method that don't include values for container_format or disk_format.

    Closes-bug: #1757927

    Depends-on: I0e1d18844f64723608288de473e97710798eb602

    Change-Id: Ic5c81916823ff32f2dbddd32b40e825de0697dc9
    (cherry picked from commit 6cd537e2748fa636aa3061812b257d549a6d603f)

tags: added: in-stable-queens
Brian Rosmaita (brian-rosmaita)
Changed in python-glanceclient:
status: In Progress → Fix Committed
milestone: none → 2.11.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-glanceclient 2.10.0

This issue was fixed in the openstack/python-glanceclient 2.10.0 release.

Brian Rosmaita (brian-rosmaita)
Changed in python-glanceclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.