Ubuntu
dovecot package

Ubuntu in the welcome string confuses autopkgtest

Bug #1757265 reported by Dimitri John Ledkov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dovecot (Ubuntu)
Fix Released
Undecided
Unassigned
Artful
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

 * Autopkgtests regressed in artful

[Test Case]

 * Check that autopkgtests are passing

[Regression Potential]

 * Cherrypick of assertions updates from bionic, no behaviour changes vs what is in security/updates already

[Autopkgtests current failures]

======================================================================
FAIL: test_pop3 (__main__.DovecotDirectTest)
Test POP3 protocol.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.TPbesI/build.xBI/dovecot-2.2.27/debian/tests/general", line 106, in test_pop3
    self.assertEqual(pop.getwelcome(), b'+OK Dovecot ready.')
AssertionError: b'+OK Dovecot (Ubuntu) ready.' != b'+OK Dovecot ready.'

======================================================================
FAIL: test_pop3s (__main__.DovecotDirectTest)
Test POP3S protocol.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.TPbesI/build.xBI/dovecot-2.2.27/debian/tests/general", line 114, in test_pop3s
    self.assertEqual(pop.getwelcome(), b'+OK Dovecot ready.')
AssertionError: b'+OK Dovecot (Ubuntu) ready.' != b'+OK Dovecot ready.'

======================================================================
FAIL: test_pop3 (__main__.DovecotMmapTest)
Test POP3 protocol.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.TPbesI/build.xBI/dovecot-2.2.27/debian/tests/general", line 106, in test_pop3
    self.assertEqual(pop.getwelcome(), b'+OK Dovecot ready.')
AssertionError: b'+OK Dovecot (Ubuntu) ready.' != b'+OK Dovecot ready.'

======================================================================
FAIL: test_pop3s (__main__.DovecotMmapTest)
Test POP3S protocol.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.TPbesI/build.xBI/dovecot-2.2.27/debian/tests/general", line 114, in test_pop3s
    self.assertEqual(pop.getwelcome(), b'+OK Dovecot ready.')
AssertionError: b'+OK Dovecot (Ubuntu) ready.' != b'+OK Dovecot ready.'

----------------------------------------------------------------------
Ran 10 tests in 114.835s

As seen in artful autopkgtests

See original description
Dimitri John Ledkov (xnox)
Changed in dovecot (Ubuntu):
status: New → Fix Released
description: updated
Dimitri John Ledkov (xnox)
description: updated
Dimitri John Ledkov (xnox)
Changed in dovecot (Ubuntu Artful):
status: New → In Progress
Revision history for this message
Robie Basak (racb) wrote :

On the Artful upload wearing my SRU hat, I'm not sure it's appropriate for us to release an SRU solely to fix a dep8 test, as that's not user impacting but does involve a potential regression due to a rebuild and certainly a bunch of downloads for all Artful dovecot users. I've posted https://lists.ubuntu.com/archives/ubuntu-release/2018-March/004352.html to ask for consensus for a policy on this.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I personally think in this case the fix for just autopkgtest regressions seems appropriate. Since I do not see dovecot having any regular artful uploads, it might take a while until the ADT regression is fixed if we decide to 'batch it up'. Getting it accepted doesn't involve a lot of cost, so I don't see a reason it shouldn't get released now.

Changed in dovecot (Ubuntu Artful):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-artful
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Dimitri, or anyone else affected,

Accepted dovecot into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dovecot/1:2.2.27-3ubuntu1.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

http://autopkgtest.ubuntu.com/packages/dovecot

Is all green.

tags: added: verification-done verification-done-artful
removed: verification-needed verification-needed-artful
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dovecot - 1:2.2.27-3ubuntu1.4

---------------
dovecot (1:2.2.27-3ubuntu1.4) artful; urgency=medium

  * Cherrypick bionic autopkgtest fix to account for Ubuntu in the welcome
    string. LP: #1757265

 -- Dimitri John Ledkov <email address hidden> Wed, 21 Mar 2018 10:17:09 +0000

Changed in dovecot (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for dovecot has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.