gdebi-gtk broken in 18.04 error: unable to read filedescriptor flags

Bug #1756238 reported by Mark-pcnetspec
98
This bug affects 17 people
Affects Status Importance Assigned to Milestone
vte2.91 (Ubuntu)
Fix Released
High
Unassigned
Bionic
Fix Released
High
Unassigned

Bug Description

When using gdebi-gtk to install a .deb the install fails with the message:-

dpkg: error: unable to read filedescriptor flags for <package status and progress file descriptor>: Bad file descriptor

This only occurs via the gdebi-gtk GUI front end, packages install perfectly if done via the CLI with:
sudo gdebi /path/to/packagename.deb

Simon Quigley (tsimonq2)
Changed in gdebi (Ubuntu):
importance: Undecided → Critical
status: New → Confirmed
Revision history for this message
Demetrius Lolos (dlolos1) wrote :

Same problem here using Ubuntu 18.04 beta 1. Did an update and now gdebit doesn't even ask for a password. But does work in terminal.

Revision history for this message
Phelps Scofield (phelpsscofield) wrote :

In my Ubuntu 18.04 Beta 1 the gdebi program does not install any deb packages, but when I click install package it crashes and closes. I am installing through dpkg on the terminal.

Revision history for this message
Mark-pcnetspec (mark-pcnetspec) wrote :

Any update on this ?

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Maybe this is related to the fix for LP: #1719746 and the reason why the %f option was dropped in Ubuntu 17.10.

(I don't use gdebi and am not working on fixing this bug.)

Revision history for this message
Mark-pcnetspec (mark-pcnetspec) wrote :

No it's not that clicking the .deb doesn't fire up gdebi-gtk (it does), it's that gdebi-gtk crashes whilst installing the .deb throwing the error:-

dpkg: error: unable to read filedescriptor flags for <package status and progress file descriptor>: Bad file descriptor

Changing (or dropping) the %f option makes no difference :(

Revision history for this message
Jeremy Bícha (jbicha) wrote :

One other person suggested that updating vte from 0.50 to 0.52 triggered this bug
LP: #1758918

I haven't investigated that either.

Revision history for this message
Mark-pcnetspec (mark-pcnetspec) wrote :

Yep, definitely something in vte 0.52 because downgrading to 0.48 by installing these packages from artful:-

gir1.2-vte-2.91_0.48.4-0ubuntu1_amd64.deb
libvte-2.91-0_0.48.4-0ubuntu1_amd64.deb
libvte-2.91-0-udeb_0.48.4-0ubuntu1_amd64.udeb
libvte-2.91-common_0.48.4-0ubuntu1_all.deb

fixes the issue.

Revision history for this message
Mark-pcnetspec (mark-pcnetspec) wrote :

I may have gone overboard with libvte-2.91-0-udeb which isn't a default package so is unnecessary.

Jeremy Bícha (jbicha)
Changed in vte2.91 (Ubuntu):
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

I can reproduce the bug, and I also get the same (faulty) result with vanilla vte-0.48 compiled by me (that is, not the Ubuntu package, contrary to comment 7).

Jeremy, could you please test if bringing back 91_keep_fds.patch solves the issue? The error message sounds suspiciously related to what this patch was doing.

vte2.91 (0.51.90-1ubuntu1) bionic; urgency=medium
  [...]
  * Dropped change, apparently hasn't been needed for years:
    - Add 91_keep_fds.patch:
      + Keep file descriptors open on vte_fork_pty()

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

Yup, with manually compiled vte-0.53, this patch fixes the problem.

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

Which, of course, raises the question:

- Is gdebi doing something wrong? Is there an alternative approach provided by VTE, which gdebi should start using instead?
- Does VTE really lack a feature that is required by gdebi, so VTE should add?
- Did VTE perhaps reject adding this feature (if so, why?), hence the need for the patch?

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

Looks like 91_keep_fds.patch was something that never made it upstream when originally added.

vte (1:0.25.91-0ubuntu4) maverick; urgency=low

  * debian/patches/91_keep_fds.patch:
    - Update and return patch that hadn't been applied upstream (LP: #620297)
 -- Robert Ancell <email address hidden> Wed, 08 Sep 2010 17:57:18 +1000

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Ok, I'm going to go ahead and restore the patch for now to fix gdebi.

Changed in vte2.91 (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Egmont, see https://bugzilla.gnome.org/show_bug.cgi?id=320128 (mentioned in the patch header).

Revision history for this message
Mark-pcnetspec (mark-pcnetspec) wrote :

for what it's worth, 91_keep_fds.patch fixes libvte-2.91-0 for me.

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

Ideally gdebi should be fixed not to rely on this patch. Obviously that's somewhat more work.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vte2.91 - 0.52.0-1ubuntu2

---------------
vte2.91 (0.52.0-1ubuntu2) bionic; urgency=medium

  * Restore 91_keep_fds.patch since gdebi still requires it (LP: #1756238)

 -- Jeremy Bicha <email address hidden> Sat, 31 Mar 2018 16:56:28 -0400

Changed in vte2.91 (Ubuntu):
status: Fix Committed → Fix Released
Jeremy Bícha (jbicha)
Changed in gdebi (Ubuntu):
importance: Critical → Medium
status: Confirmed → Triaged
Revision history for this message
Mark-pcnetspec (mark-pcnetspec) wrote :

vte2.91 (0.52.0-1ubuntu2) fixes it, thanks everyone.

Revision history for this message
Brian Murray (brian-murray) wrote : Missing SRU information

Thanks for uploading the fix for this bug report to -proposed. However, when reviewing the package in -proposed and the details of this bug report I noticed that the bug description is missing information required for the SRU process. You can find full details at http://wiki.ubuntu.com/StableReleaseUpdates#Procedure but essentially this bug is missing some of the following: a statement of impact, a test case and details regarding the regression potential. Thanks in advance!

Revision history for this message
Iain Lane (laney) wrote :

This bug is Fix Released in bionic. The reference is only included in LP-Bugs-Fixed because I copied the previous merge entry and then built the source package with -v. Sorry that that's confusing.

(bug #1765389 is actually missing SRU information and I pinged Rico to add it.)

Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Mark-pcnetspec, or anyone else affected,

Accepted vte2.91 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/vte2.91/0.52.2-1ubuntu1~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in vte2.91 (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Mark-pcnetspec (mark-pcnetspec) wrote :

As far as I was concerned this bug was already fixed in:-

0.52.1-1ubuntu1

in the main repo, so I can't see any need for this in proposed now.

But just to answer your question anyway, YES:-

0.52.2-1ubunti1-18.04.1

also fixes the issue (though now it would likely be more accurate to say it doesn't regress the earlier fix).

Iain Lane (laney)
Changed in vte2.91 (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Iain Lane (laney) wrote :

Let's just mark it as done so the team's tools see that it is fixed

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for vte2.91 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
slumbergod (slumbergod) wrote :

I just did a clean install of Xubuntu 18.04.1 and then installed gdebi and its frontend.
The interface crashes for me so it hasn't been fixed. The back-end might work from the command line but the gui is broken.

Revision history for this message
Mark smith (zebiddy8) wrote :

I *might* have a possible clue for the gdebi gui crash in Bionic.

If I right click on a .deb file and tell it to install with gdebi the gui will crash.
If I open a terminal in the same directory as the file and launch gdebi-gtk *.deb the gui will install and uninstall the .deb file without crashing.

I hope this offers a potential clue for a fix, I love the gdebi installer and I thank ALL of you programmers for your diligence and hard work!!

Mark

Revision history for this message
Alexandre Speltri (alexandreporks) wrote :

I have the exact same problem in Ubuntu 18.04.1 tottaly updated, including backports. Mark Smith #26 commentary works with me also. I think the gdebi-gtk when not opened from terminal, crashes when I have to type me password

Revision history for this message
Carlos Suárez (bitseater) wrote :

There is a error into the /usr/share/polkit-1/actions/com.ubuntu.pkexec.gdebi-gtk.policy file:

Change "<action id="com.ubuntu.pkexec.gdebi.gtk">" with "<action id="com.ubuntu.pkexec.gdebi-gtk">".

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

In groovy the code for vte-keep-FD patch has been refactored to support new upstream code.

However, I think it's the time we plan to remove this next cycle, given that gdebi is the only project using it so far [1], and that upstream already suggested a better way to do it [2].

So, if someone is still interested in fixing gdebi to address this, please act as otherwise it's very likely that next versions of vte will break it.

[1] https://codesearch.debian.net/search?q=VTE_PTY_KEEP_FD&literal=1
[2] https://bugzilla.gnome.org/show_bug.cgi?id=320128#c23

Revision history for this message
Fredrik Jacobsson (smask) wrote :

Next version of vte broke it.

gdebi-gtk barfs on file descriptors in Impish (proposed enabled)

Revision history for this message
Norbert (nrbrtx) wrote :

This bug is returned to impish as bug 1946499 . Please fix it.

tags: added: impish
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote (last edit ):

@Marco Trevisan (@3v1n0) With this change, the 91_keep_fds.patch in vte can be dropped

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Patch to drop ubuntu-specific hack from gdebi because it is not needed any more" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in gdebi (Ubuntu):
importance: Medium → High
status: Triaged → In Progress
Changed in gdebi (Ubuntu):
status: In Progress → Fix Committed
Mathew Hodson (mhodson)
Changed in vte2.91 (Ubuntu Bionic):
importance: Undecided → High
Revision history for this message
Mathew Hodson (mhodson) wrote :

I think it makes more sense to use bug 1946499 to track the issue happening in Ubuntu 21.10. The patches in this bug landed two years ago, so it would be confusing to reopen it.

no longer affects: gdebi (Ubuntu)
tags: removed: impish
Mathew Hodson (mhodson)
tags: removed: patch
Revision history for this message
Robie Basak (racb) wrote : Proposed package upload rejected

An upload of gdebi to impish-proposed has been rejected from the upload queue for the following reason: "Missing SRU information. This looks like it wasn't intended for SRU, and the changes are now in Jammy?".

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Mark-pcnetspec, or anyone else affected,

Accepted gdebi into impish-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gdebi/0.9.5.7+nmu5ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-impish to verification-done-impish. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-impish. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-impish
removed: verification-done
Revision history for this message
Norbert (nrbrtx) wrote :

Package from impish-proposed fixed the issue.
Thanks!

tags: added: verification-done-impish
removed: verification-needed-impish
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.