Input field height changes slightly when entering in st password fields.

Bug #1743058 reported by Dimitri John Ledkov
30
This bug affects 6 people
Affects Status Importance Assigned to Milestone
gnome-shell (Ubuntu)
Fix Released
Medium
Marco Trevisan (Treviño)
Bionic
Fix Released
Low
Marco Trevisan (Treviño)

Bug Description

It appears there is the font/height rendering issue in multiple places. With the textentry "jumping" in height slightly upon entering anything.

I have observed this on the login screen password entry screen, lockscreen entry, and the gnome pin entry for my ssh/gpg smartcard.

It almost feels as if the "dots" of the hidden password are either of larger font size and/or bold, whilst an empty text field and/or unfocused text field font is either smaller and or regular (non-bold). Resulting in a rendering / layout jiggles.

[ Impact ]

Password input field increase the vertical size as soon as the user types something

[ Test case ]

1. Run:
   pkexec true
2. Start typing something
3. The input field should not resize vertically

This works only in case the big-font a11y option is not enabled

[ Regression potential ]

Input Text entries might be slightly taller than they were

Related branches

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

As far as I can tell, this is either an 'st' (Shell Toolkit in gnome-shell, also used on the login screen) bug, or an issue with our theming which is patched into gnome-shell.

The same st gnome-shell code is used in security prompts. So I think this bug lays entirely within gnome-shell and not the other components.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gdm3 (Ubuntu):
status: New → Confirmed
Changed in gnome-keyring (Ubuntu):
status: New → Confirmed
Changed in gnome-shell (Ubuntu):
status: New → Confirmed
no longer affects: gdm3 (Ubuntu)
no longer affects: gnome-keyring (Ubuntu)
tags: added: visual-quality
summary: - In multiple apps, the input field "jumps"
+ Input field height changes slightly when entering in st password fields.
Changed in gnome-shell (Ubuntu):
importance: Undecided → Low
Changed in gnome-shell (Ubuntu):
status: Confirmed → In Progress
status: In Progress → Fix Released
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
importance: Low → Medium
description: updated
Iain Lane (laney)
Changed in gnome-shell (Ubuntu Bionic):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in gnome-shell (Ubuntu Bionic):
status: New → In Progress
status: In Progress → Fix Committed
importance: Undecided → Low
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Dimitri, or anyone else affected,

Accepted gnome-shell into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.28.3-0ubuntu0.18.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-bionic
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Verified this bug is fixed in bionic version 3.28.3-0ubuntu0.18.04.3, but it introduces a rather bad regression where the login screen is now the upstream grey theme.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

I don't think this is the case... At least I didn't get this regression in my vm.

Is it yours clean?

Aslo I don't see how this could happen, as per the pure diff.
Is your gdm3 altrnative setup properly?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK, I wiped another laptop and installed 18.04.1 fresh with only the above fix.

Verified bug fixed with no regressions, using 3.28.3-0ubuntu0.18.04.3.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell - 3.28.3-0ubuntu0.18.04.3

---------------
gnome-shell (3.28.3-0ubuntu0.18.04.3) bionic; urgency=medium

  * debian/ubuntu.css:
    - use defined color for menu separators (LP: #1739931)
    - set StEntry minimun height to work properly with Ubuntu font (LP: #1743058)
  * debian/patches/st-button-Ignore-pointer-emulated-touch-events.patch:
    - Don't emit two click events on touch under X11 (LP: #1745888)
  * d/p/st-scroll-view-Handle-the-case-where-scrollbars-are-NULL.patch,
    d/p/st-scroll-view-Remove-scrollbars-references-on-dispose.patch:
    - Handle NULL scroll bars in st-scroll-view (LP: #1725312)

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 06 Nov 2018 17:49:17 +0000

Changed in gnome-shell (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gnome-shell has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.