Ceph Monitor Charm

upgrade failure: str to float comparison

Bug #1742079 reported by James Page
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph Monitor Charm
Fix Released
Critical
James Page
Ceph OSD Charm
Fix Released
Critical
James Page
charms.ceph
Fix Released
Critical
James Page

Bug Description

2018-01-09 08:16:43 INFO config-changed obtained 'mon_juju-dababc-2-lxd-0_luminous_start'
2018-01-09 08:16:43 INFO config-changed Traceback (most recent call last):
2018-01-09 08:16:43 INFO config-changed File "/var/lib/juju/agents/unit-ceph-mon-1/charm/hooks/config-changed", line 725, in <module>
2018-01-09 08:16:43 INFO config-changed hooks.execute(sys.argv)
2018-01-09 08:16:43 INFO config-changed File "/var/lib/juju/agents/unit-ceph-mon-1/charm/hooks/charmhelpers/core/hookenv.py", line 798, in execute
2018-01-09 08:16:43 INFO config-changed self._hooks[hook_name]()
2018-01-09 08:16:43 INFO config-changed File "/var/lib/juju/agents/unit-ceph-mon-1/charm/hooks/charmhelpers/contrib/hardening/harden.py", line 79, in _harden_inner2
2018-01-09 08:16:43 INFO config-changed return f(*args, **kwargs)
2018-01-09 08:16:43 INFO config-changed File "/var/lib/juju/agents/unit-ceph-mon-1/charm/hooks/config-changed", line 187, in config_changed
2018-01-09 08:16:43 INFO config-changed check_for_upgrade()
2018-01-09 08:16:43 INFO config-changed File "/var/lib/juju/agents/unit-ceph-mon-1/charm/hooks/config-changed", line 107, in check_for_upgrade
2018-01-09 08:16:43 INFO config-changed upgrade_key='admin')
2018-01-09 08:16:43 INFO config-changed File "lib/ceph/utils.py", line 1671, in roll_monitor_cluster
2018-01-09 08:16:43 INFO config-changed version=new_version)
2018-01-09 08:16:43 INFO config-changed File "lib/ceph/utils.py", line 1802, in wait_on_previous_node
2018-01-09 08:16:43 INFO config-changed if (current_timestamp - (10 * 60)) > previous_node_start_time:
2018-01-09 08:16:43 INFO config-changed TypeError: unorderable types: float() > str()

Tags: upgrade
James Page (james-page)
summary: - upgrade failure: str to flaot comparison
+ upgrade failure: str to float comparison
James Page (james-page)
tags: added: upgrade
James Page (james-page)
Changed in charm-ceph-mon:
importance: Undecided → Critical
Changed in charm-ceph-osd:
importance: Undecided → Critical
Changed in charms.ceph:
importance: Undecided → Critical
James Page (james-page)
Changed in charms.ceph:
status: New → Triaged
Changed in charm-ceph-osd:
status: New → Triaged
Changed in charm-ceph-mon:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charms.ceph (master)

Reviewed: https://review.openstack.org/532191
Committed: https://git.openstack.org/cgit/openstack/charms.ceph/commit/?id=e007b5265cd30baccb44adb4c2471fe9d6b8db78
Submitter: Zuul
Branch: master

commit e007b5265cd30baccb44adb4c2471fe9d6b8db78
Author: James Page <email address hidden>
Date: Tue Jan 9 14:13:50 2018 +0000

    py3: Deal with comparison with str and None

    Under Python 3, its not possible to compare a float with an object
    of type str or NoneType; ensure that these conditions are handled
    in the conditional which waits for the previous unit in the cluster
    to complete upgrade before the current unit commences.

    This change also includes a minor change to the way time span
    assessed in unit tests for this function.

    Change-Id: I34e3be4c55976d562497257626a339c72efabbad
    Closes-Bug: 1742079

Changed in charms.ceph:
status: Triaged → Fix Released
Ryan Beisner (1chb1n)
Changed in charm-ceph-mon:
assignee: nobody → James Page (james-page)
Changed in charm-ceph-osd:
assignee: nobody → James Page (james-page)
Changed in charms.ceph:
assignee: nobody → James Page (james-page)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-mon (master)

Reviewed: https://review.openstack.org/532499
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=1f0593649c8eaadd71f22a40ece9356b7f75b1ef
Submitter: Zuul
Branch: master

commit 1f0593649c8eaadd71f22a40ece9356b7f75b1ef
Author: James Page <email address hidden>
Date: Wed Jan 10 09:12:20 2018 +0000

    Resync ceph helpers for misc fixes

    Pickup fixes for upgrade from Jewel -> Luminous.

    Change-Id: Id0694b5116e604efbe1c5259de332ae0c4bae574
    Closes-Bug: 1742082
    Closes-Bug: 1742083
    Closes-Bug: 1742120
    Closes-Bug: 1742079
    Closes-Bug: 1742408

Changed in charm-ceph-mon:
status: Triaged → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-osd (master)

Reviewed: https://review.openstack.org/532500
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=de3b55a4e70d0b56531f7d844e0afa052bb082eb
Submitter: Zuul
Branch: master

commit de3b55a4e70d0b56531f7d844e0afa052bb082eb
Author: James Page <email address hidden>
Date: Wed Jan 10 11:31:53 2018 +0000

    Resync ceph helpers for misc fixes

    Pickup fixes for upgrade from Jewel -> Luminous.

    Change-Id: I3ffeebc38464096724ca0fd40f1cf29cf3e7fe4f
    Closes-Bug: 1742082
    Closes-Bug: 1742083
    Closes-Bug: 1742120
    Closes-Bug: 1742079
    Closes-Bug: 1742408

Changed in charm-ceph-osd:
status: Triaged → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-mon (stable/17.11)

Fix proposed to branch: stable/17.11
Review: https://review.openstack.org/533150

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-ceph-osd (stable/17.11)

Fix proposed to branch: stable/17.11
Review: https://review.openstack.org/533151

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-osd (stable/17.11)

Reviewed: https://review.openstack.org/533151
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=8c50b3a48331316df422609cb78980d96f079b99
Submitter: Zuul
Branch: stable/17.11

commit 8c50b3a48331316df422609cb78980d96f079b99
Author: James Page <email address hidden>
Date: Wed Jan 10 11:31:53 2018 +0000

    Resync ceph helpers for misc fixes

    Pickup fixes for upgrade from Jewel -> Luminous.

    Change-Id: I3ffeebc38464096724ca0fd40f1cf29cf3e7fe4f
    Closes-Bug: 1742082
    Closes-Bug: 1742083
    Closes-Bug: 1742120
    Closes-Bug: 1742079
    Closes-Bug: 1742408
    (cherry picked from commit de3b55a4e70d0b56531f7d844e0afa052bb082eb)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-mon (stable/17.11)

Reviewed: https://review.openstack.org/533150
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=d43ba706fa0ec8631c2271abceb70dc05201f198
Submitter: Zuul
Branch: stable/17.11

commit d43ba706fa0ec8631c2271abceb70dc05201f198
Author: James Page <email address hidden>
Date: Wed Jan 10 09:12:20 2018 +0000

    Resync ceph helpers for misc fixes

    Pickup fixes for upgrade from Jewel -> Luminous.

    Change-Id: Id0694b5116e604efbe1c5259de332ae0c4bae574
    Closes-Bug: 1742082
    Closes-Bug: 1742083
    Closes-Bug: 1742120
    Closes-Bug: 1742079
    Closes-Bug: 1742408
    (cherry picked from commit 1f0593649c8eaadd71f22a40ece9356b7f75b1ef)

James Page (james-page)
Changed in charm-ceph-osd:
status: Fix Committed → Fix Released
Changed in charm-ceph-mon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.