build.snapcraft.io uses snapcraft from the deb archive

Bug #1737994 reported by Alan Pope 🍺🐧🐱 🦄
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson
launchpad-buildd
Fix Released
High
Colin Watson

Bug Description

snapcraft is now available in the stable channel. We should probably switch to using the snap of snapcraft

alan@deep-thought:~$ snap info snapcraft
name: snapcraft
summary: easily create snaps
publisher: canonical
contact: <email address hidden>
description: |
  Snapcraft aims to make upstream developers' lives easier and as such is not a
  single toolset, but instead is a collection of tools that enable the natural
  workflow of an upstream to be extended with a simple release step into Snappy
  enabled system.
snap-id: vMTKRaLjnOJQetI78HjntT37VuoyssFE
commands:
  - snapcraft
tracking: edge
installed: 2.37+git3.1a7a4f7 (938) 53MB classic
refreshed: 2017-12-11 23:44:28 +0000 UTC
channels:
  stable: 2.35 (794) 53MB classic
  candidate: ↑
  beta: 2.37 (924) 53MB classic
  edge: 2.37+git3.1a7a4f7 (938) 53MB classic

Related branches

Revision history for this message
Colin Watson (cjwatson) wrote :

<sergiusens> cjwatson btw, mind if we work on switching snapcraft to use the snap for lp buidlers?
<cjwatson> sergiusens: I don't mind, but how were you planning to go about it?
<cjwatson> it's a bit involved
<sergiusens> cjwatson oh, then step one would be to get an idea of how involved it is :-)
<sergiusens> I had the impression it would be more about testing that s/apt install snapcraft/snap install snapcraft --classic/ was working as expected on staging
<cjwatson> sergiusens: we need to make it be a switch, not just change it in the code (which is harder to roll back, harder to experiment with on particular snaps, etc.); and probably as part of the same chunk of work we need to add channel control
<cjwatson> sergiusens: which means it needs to be propagated down from the LP buildd-manager, and probably needs data model changes
<sergiusens> cjwatson up to LP or even build.snapcraft.io ?
<sergiusens> I'll write up the proposed set of steps on the forum
<cjwatson> sergiusens: not build.snapcraft.io IMO. We can flip the switch eventually but it needs to be controlled
<cjwatson> sergiusens: IMO the steps are: (1) design data model in LP (possibly taking into account where core is installed from too, at least for the future?) (2) add option to snap build type in launchpad-buildd to cause it to install snapcraft as a snap (3) LP database migration to add whatever new columns we need (4) implement new data model and API changes in LP, and adjust the build args sent to builders (5) possible UI changes
<cjwatson> sergiusens: ordering is important because builders, DB migrations, LP code are all deployed independently so we need to ensure the right kind of compatibility

Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Changed in launchpad-buildd:
status: New → Triaged
importance: Undecided → High
Changed in launchpad:
assignee: nobody → Sergio Schvezov (sergiusens)
Changed in launchpad-buildd:
assignee: nobody → Sergio Schvezov (sergiusens)
Revision history for this message
Colin Watson (cjwatson) wrote :

Sergio, assigning this to you since you said you were planning to work on it. Let us know if that turns out not to be viable.

tags: added: feature lp-snappy
Colin Watson (cjwatson)
Changed in launchpad:
assignee: Sergio Schvezov (sergiusens) → Colin Watson (cjwatson)
Changed in launchpad-buildd:
assignee: Sergio Schvezov (sergiusens) → Colin Watson (cjwatson)
Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: Triaged → In Progress
Colin Watson (cjwatson)
Changed in launchpad:
status: Triaged → In Progress
Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: In Progress → Fix Committed
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Revision history for this message
Colin Watson (cjwatson) wrote :

2018-03-12 18:49:08,832 INFO 2209-83-1 applied just now in 0.0 seconds

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Colin Watson (cjwatson) wrote :

The initial work here seems OK, but this is only part of the fix; we still need to do more work to present the state in the UI and to roll it out by default.

tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → In Progress
Colin Watson (cjwatson)
Changed in launchpad-buildd:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Colin Watson (cjwatson) wrote :

This is now code-complete in Launchpad: we have the ability to make this change globally. I'm not yet doing so because we'd like to have some kind of QA of the set of snaps that Launchpad builds (or at least a reasonable sample) to make sure that we aren't wildly regressing them by switching to the snap.

Revision history for this message
Colin Watson (cjwatson) wrote :

This has been done for a while except for the legacy case of snaps that don't specify any base at all. I think we might as well close this bug.

Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.