Ctrl + F search disengages immediately after CTRL + F pressed

Bug #1735071 reported by Scott Cohen
38
This bug affects 4 people
Affects Status Importance Assigned to Milestone
GNOME Software
Fix Released
Unknown
gnome-software (Ubuntu)
Fix Released
Low
Robert Ancell
Bionic
Fix Released
Low
Robert Ancell
Cosmic
Won't Fix
Low
Unassigned
Disco
Fix Released
Low
Robert Ancell

Bug Description

* Impact
ctrl-F doesn't open the search widget

* Test case
- open gnome-software
- hit ctrl-F
-> the search widget should display

* Regression potential
The change is in the event handler for the specific keybinding so it shouldn't have any side effect if that feature is working

--------------------------

I press Ctrl + F to open up the search bar to search but I find that immediately after I press Ctrl + F, the bar closes and resets to its original state. I can visibly see the bar show up as well as it closing immediately. I have tested this functionality in the gnome-software-center from other distributions and the master branch and this works. I think this is a theme issue. I am using the default Ubuntu theme by the way.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: gnome-software 3.26.3-2ubuntu1
ProcVersionSignature: Ubuntu 4.13.0-16.19-generic 4.13.4
Uname: Linux 4.13.0-16-generic x86_64
ApportVersion: 2.20.8-0ubuntu2
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Tue Nov 28 20:28:44 2017
InstallationDate: Installed on 2017-07-20 (131 days ago)
InstallationMedia: Ubuntu 17.04 "Zesty Zapus" - Release amd64 (20170412)
InstalledPlugins:
 gnome-software-plugin-flatpak N/A
 gnome-software-plugin-limba N/A
 gnome-software-plugin-snap 3.26.3-2ubuntu1
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-software
UpgradeStatus: Upgraded to bionic on 2017-11-23 (6 days ago)

Revision history for this message
Scott Cohen (yetoo) wrote :
description: updated
Changed in gnome-software (Ubuntu):
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-software (Ubuntu):
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

That's still an issue but it seems to work if started with
$ GTK_IM_MODULE=xim gnome-software

so an issue with ibus? (same problem with GTK_IM_MODULE=)

Revision history for this message
Andrea Azzarone (azzar1) wrote :
Changed in gnome-software (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Andrea Azzarone (azzar1)
Changed in gnome-software:
status: Unknown → New
Changed in gnome-software:
status: New → Fix Released
Revision history for this message
corrado venturini (corradoventu) wrote :

On Ubuntu 19.10 gnome-software 3.30.6-2ubuntu3 Ctrl+F does not open the search bar but closes it if already open by click on the magnifying glass icon.

Revision history for this message
Sebastien Bacher (seb128) wrote :
Changed in gnome-software (Ubuntu):
status: In Progress → Fix Committed
assignee: Andrea Azzarone (azzar1) → Robert Ancell (robert-ancell)
description: updated
Changed in gnome-software (Ubuntu Bionic):
importance: Undecided → Low
Changed in gnome-software (Ubuntu Disco):
importance: Undecided → Low
Changed in gnome-software (Ubuntu Bionic):
status: New → Fix Committed
Changed in gnome-software (Ubuntu Disco):
status: New → Fix Committed
Changed in gnome-software (Ubuntu Bionic):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in gnome-software (Ubuntu Disco):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in gnome-software (Ubuntu Cosmic):
status: New → Won't Fix
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.30.6-2ubuntu5

---------------
gnome-software (3.30.6-2ubuntu5) eoan; urgency=medium

  * debian/patches/0014-Add-a-basic-permissions-system.patch:
  * debian/patches/0028-Added-u2f-devices-to-interfaces-UI.patch
    - Merge u2f changes into original patch
  * debian/patches/0027-shell-Don-t-progate-CTRL-F-key-pressed-event.patch:
    - Fix Ctrl-F not opening search bar (LP: #1735071)

gnome-software (3.30.6-2ubuntu4) disco; urgency=mediumd

  * debian/patches/0026-odrs-Only-show-reviews-from-the-same-distribution.patch:
    - Show only Ubuntu reviews (LP: #1825064)

 -- Robert Ancell <email address hidden> Tue, 14 May 2019 11:04:29 +1200

Changed in gnome-software (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, so I have some trouble with the SRUs addressing this bug. Per SRU policy [1], we in generall only should only aim for fixing 'high-impact bugs'. This bug seems to be marked with an importance of Low, which normally isn't per-se good SRU material (if it was bundled with some other, high-importance changes, the story would be slightly different). That being said, the issue does seem to be quite annoying and getting it fixed can improve the overall user-experience for our LTS users.

That being said, after actually checking the change, I feel it's safe enough that I think I'll be accepting this for both series - mainly for bionic, but let's also get disco as 'consistency' for people doing funny upgrades to a non-LTS series.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :
tags: added: verification-needed verification-needed-disco
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Scott, or anyone else affected,

Accepted gnome-software into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.30.6-2ubuntu4.19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Actually, I don't see an upload for bionic for fixing this bug. The task was already set to 'Fix Committed' - where is the bionic fix committed? Is it in the current bionic gnome-software already?

Revision history for this message
Robert Ancell (robert-ancell) wrote :

It's committed in the disco packaging repository, but not uploaded. I planned on bundling that change with other changes in an SRU.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Installing 3.30.6-2ubuntu4.19.04.1 and restarting gnome-software, then ctrl-F does display the widget

tags: added: verification-done-disco
removed: verification-needed-disco
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.30.6-2ubuntu4.19.04.1

---------------
gnome-software (3.30.6-2ubuntu4.19.04.1) disco; urgency=medium

  * debian/patches/0027-shell-Don-t-progate-CTRL-F-key-pressed-event.patch:
    - Fix Ctrl-F not opening search bar (LP: #1735071)

 -- Robert Ancell <email address hidden> Tue, 14 May 2019 11:04:29 +1200

Changed in gnome-software (Ubuntu Disco):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Scott, or anyone else affected,

Accepted gnome-software into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.28.1-0ubuntu4.18.04.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-bionic
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Confirmed in bionic that gnome-software 3.28.1-0ubuntu4.18.04.12 shows search after pressing Ctrl-F.

tags: added: verification-done-bionic
removed: verification-needed-bionic
tags: removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.28.1-0ubuntu4.18.04.12

---------------
gnome-software (3.28.1-0ubuntu4.18.04.12) bionic; urgency=medium

  * debian/patches/0001-Fix-apps-that-were-previously-uninstalled-from-not-s.patch:
    - Fix apps that are reinstalled from disappearing from installed page
      (LP: #1742997)

gnome-software (3.28.1-0ubuntu4.18.04.11) bionic; urgency=medium

  * debian/patches/0031-shell-Don-t-progate-CTRL-F-key-pressed-event.patch:
    - Fix Ctrl-F not opening search bar (LP: #1735071)
  * debian/patches/0014-Add-a-basic-permissions-system.patch:
    - Fix interface connections not showing correct state (LP: #1806697)
  * debian/patches/0017-snap-Use-default-icon-if-none-provided.patch:
    - Update default snap icon (LP: #1818920)
  * debian/patches/0032-snap-Update-Snap-store-category-mapping.patch:
    - Update snap store categories (LP: #1836826)

 -- Robert Ancell <email address hidden> Tue, 17 Sep 2019 09:49:03 +0200

Changed in gnome-software (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.