Race condition in zone imports tests

Bug #1734868 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Thomas Herve

Bug Description

Seen here: http://logs.openstack.org/23/523223/3/check/puppet-openstack-integration-4-scenario003-tempest-centos-7/212f9ac/job-output.txt.gz#_2017-11-28_09_29_27_411291

designate_tempest_plugin.tests.api.v2.test_zones_imports.ZonesImportTest.test_show_zone_import[id-c8909558-0dc6-478a-9e91-eb97b52e59e0,smoke]
---------------------------------------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "/usr/lib/python2.7/site-packages/designate_tempest_plugin/tests/api/v2/test_zones_imports.py", line 55, in test_show_zone_import
        self.assertExpected(zone_import, body, self.excluded_keys)
      File "/usr/lib/python2.7/site-packages/designate_tempest_plugin/tests/base.py", line 82, in assertExpected
        self.assertEqual(value, actual[key], key)
      File "/usr/lib/python2.7/site-packages/testtools/testcase.py", line 350, in assertEqual
        self.assertThat(observed, matcher, message)
      File "/usr/lib/python2.7/site-packages/testtools/testcase.py", line 435, in assertThat
        raise mismatch_error
    testtools.matchers._impl.MismatchError: None != u'3e9ab13d-5b17-47f9-b165-c3e84c8439a9': zone_id

We can see that returned by the import POST:

Body: {"status": "PENDING", "zone_id": null, ...}

So the zone_id is not available yet, we need to poll to make sure the zone is created properly before calling show on it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate-tempest-plugin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/523389

Changed in designate:
assignee: nobody → Thomas Herve (therve)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate-tempest-plugin (master)

Reviewed: https://review.openstack.org/523389
Committed: https://git.openstack.org/cgit/openstack/designate-tempest-plugin/commit/?id=d8dd2cecff0e6b0e179a8da2d35911ab9d465f7a
Submitter: Zuul
Branch: master

commit d8dd2cecff0e6b0e179a8da2d35911ab9d465f7a
Author: Thomas Herve <email address hidden>
Date: Tue Nov 28 11:58:14 2017 +0100

    Remove zone_id on import compare

    If the import is fast, it can be done by the show, so we can't compare
    zone_id.

    Closes-Bug: #1734868

    Change-Id: I291155304a36142ec2fd2f772215bb10f2dbae11

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate-tempest-plugin 0.4.0

This issue was fixed in the openstack/designate-tempest-plugin 0.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.