git-ubuntu

error: orphan tag already exists during import

Bug #1733856 reported by Andreas Hasenack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-ubuntu
Fix Released
High
Unassigned
git-ubuntu lp-beta

Bug Description

I was testing the fix for bug #1730778 with the proposed branch. I tried to import lockfile-progs like this:

$ git-ubuntu import -v --no-push -d lockfile-progs-git-repo lockfile-progs 2>&1 | tee log.lockfile-progs

that hit this error:
11/22/2017 12:43:30 - DEBUG:Creating tag importer/orphan/0.1.13 pointing to 5f672c4d413c5c8395a8361a273051e7f52a4993
11/22/2017 12:43:30 - DEBUG:Executing: git tag -a -m "git-ubuntu import v0.6.2" importer/orphan/0.1.13 5f672c4d413c5c8395a8361a273051e7f52a4993
11/22/2017 12:43:30 - ERROR:Command exited 128: git tag -a -m "git-ubuntu import v0.6.2" importer/orphan/0.1.13 5f672c4d413c5c8395a8361a273051e7f52a4993
11/22/2017 12:43:30 - ERROR:stdout:
11/22/2017 12:43:30 - ERROR:stderr: fatal: tag 'importer/orphan/0.1.13' already exists

Traceback (most recent call last):
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/importer.py", line 1446, in import_publishes
    ubuntu_sinfo=ubuntu_sinfo,
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/importer.py", line 1224, in import_unapplied_spi
    upload_parent_commit,
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/importer.py", line 572, in commit_unapplied_patches_import
    None,
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/importer.py", line 552, in _commit_import
    tag, commit_hash
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/git_repository.py", line 1259, in git_run
    return run(['git'] + args, env=combined_env, **kwargs)
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/run.py", line 85, in run
    raise e
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/run.py", line 64, in run
    stdout=stdout, stderr=stderr, stdin=stdin)
  File "/usr/lib/python3.6/subprocess.py", line 418, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'tag', '-a', '-m', 'git-ubuntu import v0.6.2', 'importer/orphan/0.1.13', '5f672c4d413c5c8395a8361a273051e7f52a4993']' returned non-zero exit status 128.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/ubuntu/git/projects/usd-importer/bin/git-ubuntu", line 22, in <module>
    main()
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/__main__.py", line 243, in main
    sys.exit(args.func(args))
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/importer.py", line 1569, in cli_main
    retry_backoffs=args.retry_backoffs,
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/importer.py", line 334, in main
    allow_applied_failures=allow_applied_failures,
  File "/home/ubuntu/git/projects/usd-importer/gitubuntu/importer.py", line 1461, in import_publishes
    raise GitUbuntuImportError(msg) from e
gitubuntu.importer.GitUbuntuImportError: Unable to import patches-unapplied 0.1.13 to debian
11/22/2017 12:43:30 - INFO:Leaving /home/ubuntu/deb/lockfile-progs-git-repo as directed

Full session attached and in http://pastebin.ubuntu.com/26019672/

Related branches

~nacc/git-ubuntu:import-tests
Robie Basak: Pending requested
Diff: 3973 lines (+2268/-369) (has conflicts)
68 files modified
.gitignore (+4/-0)
MANIFEST.in (+2/-0)
bin/import-source-packages.py (+23/-27)
bin/source-package-walker.py (+36/-87)
bin/update-repository-alias.py (+11/-43)
gitubuntu/apt_repo.py (+276/-0)
gitubuntu/apt_repo_test.py (+214/-0)
gitubuntu/apt_repo_test/README (+24/-0)
gitubuntu/apt_repo_test/attacker-privkey.asc (+105/-0)
gitubuntu/apt_repo_test/attacker-pubkey.asc (+52/-0)
gitubuntu/apt_repo_test/by-hash.badfile/dists/bionic/InRelease (+38/-0)
gitubuntu/apt_repo_test/by-hash.badfile/dists/bionic/main/source/by-hash/SHA256/106acf8f3542252ebbd46ea8ca10719d847208c2067c483a8f4568e70bde41b1 (+1/-0)
gitubuntu/apt_repo_test/detached.attackersig/dists/bionic/Release (+2/-0)
gitubuntu/apt_repo_test/detached.attackersig/dists/bionic/Release.gpg (+16/-0)
gitubuntu/apt_repo_test/detached.badsig/dists/bionic/Release (+2/-0)
gitubuntu/apt_repo_test/detached.badsig/dists/bionic/Release.gpg (+16/-0)
gitubuntu/apt_repo_test/detached.by-hash/dists/bionic/Release (+18/-0)
gitubuntu/apt_repo_test/detached.by-hash/dists/bionic/Release.gpg (+16/-0)
gitubuntu/apt_repo_test/detached.by-hash/dists/bionic/main/source/by-hash/SHA256/106acf8f3542252ebbd46ea8ca10719d847208c2067c483a8f4568e70bde41b1 (+1/-0)
gitubuntu/apt_repo_test/inline.attackersig/dists/bionic/InRelease (+21/-0)
gitubuntu/apt_repo_test/inline.badsig/dists/bionic/InRelease (+21/-0)
gitubuntu/apt_repo_test/inline.by-hash/dists/bionic/InRelease (+38/-0)
gitubuntu/apt_repo_test/inline.by-hash/dists/bionic/main/source/by-hash/SHA256/106acf8f3542252ebbd46ea8ca10719d847208c2067c483a8f4568e70bde41b1 (+1/-0)
gitubuntu/apt_repo_test/inline.injection/dists/bionic/InRelease (+37/-0)
gitubuntu/apt_repo_test/inline.no-hash/dists/bionic/InRelease (+37/-0)
gitubuntu/apt_repo_test/inline.no-hash/dists/bionic/main/source/Sources (+1/-0)
gitubuntu/apt_repo_test/no-hash.badfile/dists/bionic/Release (+13/-0)
gitubuntu/apt_repo_test/no-hash.badfile/dists/bionic/Release.gpg (+16/-0)
gitubuntu/apt_repo_test/no-hash.badfile/dists/bionic/main/source/Sources (+1/-0)
gitubuntu/apt_repo_test/nosig.bare/dists/bionic/Release (+1/-0)
gitubuntu/apt_repo_test/nosig.detached-empty/dists/bionic/Release (+1/-0)
gitubuntu/apt_repo_test/nosig.detached-empty/dists/bionic/Release.gpg (+0/-0)
gitubuntu/apt_repo_test/nosig.inline/dists/bionic/InRelease (+1/-0)
gitubuntu/apt_repo_test/nothing/README (+4/-0)
gitubuntu/apt_repo_test/privkey.asc (+105/-0)
gitubuntu/apt_repo_test/pubkey.asc (+51/-0)
gitubuntu/build.py (+15/-16)
gitubuntu/changelog_tests/test_date_1 (+0/-0)
gitubuntu/changelog_tests/test_date_2 (+0/-0)
gitubuntu/changelog_tests/test_distribution (+0/-0)
gitubuntu/changelog_tests/test_distribution_source_1 (+0/-0)
gitubuntu/changelog_tests/test_distribution_source_2 (+0/-0)
gitubuntu/changelog_tests/test_distribution_source_3 (+0/-0)
gitubuntu/changelog_tests/test_distribution_source_4 (+0/-0)
gitubuntu/changelog_tests/test_utf8_error (+0/-0)
gitubuntu/changelog_tests/test_versions_1 (+0/-0)
gitubuntu/changelog_tests/test_versions_2 (+0/-0)
gitubuntu/changelog_tests/test_versions_3 (+0/-0)
gitubuntu/changelog_tests/test_versions_unknown (+0/-0)
gitubuntu/git_repository.py (+241/-83)
gitubuntu/importer.py (+51/-20)
gitubuntu/importlocal.py (+0/-1)
gitubuntu/importppa.py (+0/-1)
gitubuntu/queue.py (+1/-1)
gitubuntu/repo_builder.py (+165/-32)
gitubuntu/run.py (+38/-0)
gitubuntu/scriptutils.py (+160/-15)
gitubuntu/scriptutils_test.py (+31/-0)
gitubuntu/source-package-whitelist.txt (+14/-0)
gitubuntu/source_builder.py (+26/-7)
gitubuntu/source_builder_test.py (+70/-4)
gitubuntu/test_git_repository.py (+30/-9)
gitubuntu/test_importer.py (+26/-0)
gitubuntu/test_util.py (+22/-0)
gitubuntu/version.py (+1/-1)
setup.py (+1/-0)
snap/snapcraft.yaml (+150/-22)
snap/wrappers/git-ubuntu-self-test (+20/-0)
~nacc/git-ubuntu:lp1733856-fix-repeated-orphan-tags
Server Team CI bot: Approve (continuous-integration)
Christian Ehrhardt : Pending requested
Diff: 67 lines (+28/-2)
2 files modified
gitubuntu/git_repository.py (+3/-0)
gitubuntu/importer.py (+25/-2)
~nacc/git-ubuntu:bug-fixes-3
On hold for merging into git-ubuntu:master
Robie Basak: Needs Fixing
Server Team CI bot: Approve (continuous-integration)
Christian Ehrhardt : Pending requested
Andreas Hasenack: Pending requested
git-ubuntu developers: Pending requested
Diff: 1849 lines (+783/-376)
15 files modified
bin/git-ubuntu (+6/-1)
gitubuntu/build.py (+209/-134)
gitubuntu/dsc.py (+37/-11)
gitubuntu/exportorig.py (+2/-4)
gitubuntu/git_repository.py (+155/-48)
gitubuntu/importer.py (+56/-29)
gitubuntu/lint.py (+7/-5)
gitubuntu/merge.py (+1/-1)
gitubuntu/run.py (+15/-0)
gitubuntu/versioning.py (+35/-0)
scripts/import-source-packages.py (+20/-25)
scripts/scriptutils.py (+202/-13)
scripts/source-package-walker.py (+20/-85)
scripts/update-repository-alias.py (+15/-15)
snap/snapcraft.yaml (+3/-5)
~nacc/git-ubuntu:lp1733856-fix-repeated-orphan-tags
Superseded for merging into git-ubuntu:master
Christian Ehrhardt : Approve
Server Team CI bot: Approve (continuous-integration)
Diff: 67 lines (+28/-2)
2 files modified
gitubuntu/git_repository.py (+3/-0)
gitubuntu/importer.py (+25/-2)
Revision history for this message
Andreas Hasenack (ahasenack) wrote :
Robie Basak (racb)
tags: added: import-edge-case
Robie Basak (racb)
tags: added: import
Revision history for this message
Robie Basak (racb) wrote :

Also affects python3.4:

11/29/2017 07:45:39 - ERROR:stderr: fatal: tag 'importer/orphan/3.4.1-11' already exists

Revision history for this message
Nish Aravamudan (nacc) wrote : Re: [Bug 1733856] Re: error: orphan tag already exists during import

See if they need reimports.

On Nov 29, 2017 14:55, "Robie Basak" <email address hidden> wrote:

> Also affects python3.4:
>
> 11/29/2017 07:45:39 - ERROR:stderr: fatal: tag
> 'importer/orphan/3.4.1-11' already exists
>
> --
> You received this bug notification because you are a member of Ubuntu
> Server Dev import team, which is subscribed to usd-importer.
> https://bugs.launchpad.net/bugs/1733856
>
> Title:
> error: orphan tag already exists during import
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/usd-importer/+bug/1733856/+subscriptions
>

Revision history for this message
Nish Aravamudan (nacc) wrote :

Also I wonder if maybe we have a conflict between orphan applied and
unapplied tags. This would be resolved by my branch that gets rid of orphan
tags, but I need to think it over.

On Nov 29, 2017 16:36, "Nish Aravamudan" <email address hidden>
wrote:

> See if they need reimports.
>
> On Nov 29, 2017 14:55, "Robie Basak" <email address hidden> wrote:
>
>> Also affects python3.4:
>>
>> 11/29/2017 07:45:39 - ERROR:stderr: fatal: tag
>> 'importer/orphan/3.4.1-11' already exists
>>
>> --
>> You received this bug notification because you are a member of Ubuntu
>> Server Dev import team, which is subscribed to usd-importer.
>> https://bugs.launchpad.net/bugs/1733856
>>
>> Title:
>> error: orphan tag already exists during import
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/usd-importer/+bug/1733856/+subscriptions
>>
>

Nish Aravamudan (nacc)
Changed in usd-importer:
status: New → In Progress
assignee: nobody → Nish Aravamudan (nacc)
Revision history for this message
Nish Aravamudan (nacc) wrote :

Also affects pax.

Revision history for this message
Nish Aravamudan (nacc) wrote :

Also affects language-pack-gnome-nb.

On Wed, Jan 24, 2018 at 11:03 AM, Andreas Hasenack
<email address hidden> wrote:
> ** Merge proposal linked:
> https://code.launchpad.net/~nacc/usd-importer/+git/usd-importer/+merge/334659
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1733856
>
> Title:
> error: orphan tag already exists during import
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/usd-importer/+bug/1733856/+subscriptions

Nish Aravamudan (nacc)
Changed in usd-importer:
milestone: none → lp-beta
importance: Undecided → High
Revision history for this message
Nish Aravamudan (nacc) wrote :

I think it's going to affect the language packs fyi

language-pack-kde-sc-base

Nish Aravamudan (nacc)
Changed in usd-importer:
status: In Progress → Fix Released
assignee: Nish Aravamudan (nacc) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.