Launchpad itself

In progress builds cannot be cancelled

Bug #173018 reported by Sarah Kowalik
78
This bug affects 9 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson

Bug Description

https://launchpad.net/+builds/sejong/+cancel is not yet implemented.

Please implement this, so that people can cancel builds if they were known wrong (and not use up build time), or to cancel the build if it's known to have timed out.

See original description

Related branches

lp:~julian-edwards/launchpad/cancel-build-bug-173018
Jeroen T. Vermeulen (community): Approve
Diff: 340 lines (+172/-10)
10 files modified
lib/lp/buildmaster/enums.py (+15/-1)
lib/lp/buildmaster/interfaces/buildfarmjob.py (+3/-0)
lib/lp/buildmaster/interfaces/buildqueue.py (+3/-0)
lib/lp/buildmaster/manager.py (+42/-7)
lib/lp/buildmaster/model/buildfarmjob.py (+10/-0)
lib/lp/buildmaster/model/buildqueue.py (+5/-0)
lib/lp/buildmaster/tests/test_buildfarmjob.py (+6/-0)
lib/lp/buildmaster/tests/test_buildqueue.py (+41/-0)
lib/lp/buildmaster/tests/test_manager.py (+43/-2)
lib/lp/soyuz/model/buildfarmbuildjob.py (+4/-0)
lp:~julian-edwards/launchpad/cancel-build-bug-173018-part2
Brad Crittenden (community): Approve (code)
Diff: 305 lines (+163/-20)
4 files modified
lib/lp/app/browser/tales.py (+2/-0)
lib/lp/buildmaster/manager.py (+45/-14)
lib/lp/buildmaster/model/buildfarmjob.py (+4/-1)
lib/lp/buildmaster/tests/test_manager.py (+112/-5)
lp:~julian-edwards/launchpad/cancel-build-bug-173018-ui-part3
Graham Binns (community): Approve (code)
Diff: 269 lines (+170/-3)
4 files modified
lib/lp/soyuz/interfaces/binarypackagebuild.py (+23/-0)
lib/lp/soyuz/model/binarypackagebuild.py (+28/-0)
lib/lp/soyuz/stories/webservice/xx-builds.txt (+2/-0)
lib/lp/soyuz/tests/test_binarypackagebuild.py (+117/-3)
lp:~julian-edwards/launchpad/cancel-build-bug-173018-ui-part4
Jeroen T. Vermeulen (community): Approve
Diff: 0 lines
Celso Providelo (cprov)
Changed in soyuz:
milestone: none → 1.2.1
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Reproduced in <http://launchpad.dev/+builds/bob/+cancel>.

Changed in soyuz:
importance: Undecided → Medium
status: New → Confirmed
Celso Providelo (cprov)
Changed in soyuz:
milestone: 1.2.1 → 1.2.2
Celso Providelo (cprov)
Changed in soyuz:
milestone: 1.2.2 → 1.2.3
Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: 1.2.3 → none
Revision history for this message
Adam Conrad (adconrad) wrote :

In discussing cancelling builds, two things came up today on IRC:

1) We need a new build status ("cancelled"?) in the DB to represent cancelled builds so that they don't get retried again and again. This current interface should twiddle that column when used.

2) We can easily hard-cancel builds on virtual builders (currently, only PPA) by just resetting the Xen guest completely, rather than having logic in launchpad-buildd to attempt to kill the build. This is bound to be more reliable anyway, so may as well be implemented.

if ((current_builder == virtual) && (action = cancel)) { mark_build_cancelled(); ppa_reset }

Celso Providelo (cprov)
Changed in soyuz:
milestone: none → 2.1.9
status: Confirmed → Triaged
Revision history for this message
Celso Providelo (cprov) wrote :

As per bug #257219, aborting superseded in-progress builds is also required.

Admittedly, it's much easier and effective for virtual builders, although I suspect whatever solution we consider should cover non-virtual builders (see the screenshot attached in the mentioned bug).

Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: 2.1.9 → 2.1.12
milestone: 2.1.12 → 2.1.11
Julian Edwards (julian-edwards)
Changed in soyuz:
milestone: 2.1.11 → pending
Revision history for this message
Julian Edwards (julian-edwards) wrote :

See also bug 494560

tags: added: buildfarm
Tom Haddon (mthaddon)
tags: added: canonical-losa-lp
Revision history for this message
Robert Collins (lifeless) wrote :

Killing all the processes in a chroot is fairly well understood now - we have helpers for the LP test suite back when it was on praseodymium that does exactly that.

Changed in launchpad:
importance: Medium → High
summary: - Soyuz refuses to let you cancel a build
+ In progress builds cannot be cancelled
description: updated
description: updated
Julian Edwards (julian-edwards)
Changed in launchpad:
assignee: nobody → Julian Edwards (julian-edwards)
status: Triaged → In Progress
importance: High → Critical
tags: added: escalated
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14192 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14192) is part of this bug's fix.

tags: added: qa-needstesting
Julian Edwards (julian-edwards)
tags: added: bad-commit-14192 qa-bad
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14220 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14220>.

tags: added: qa-needstesting
removed: qa-bad
Changed in launchpad:
status: In Progress → Fix Committed
Julian Edwards (julian-edwards)
Changed in launchpad:
status: Fix Committed → In Progress
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14224 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14224) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Julian Edwards (julian-edwards)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r14241 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14241>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Steve Kowalik (stevenk)
Changed in launchpad:
status: Fix Committed → Fix Released
Julian Edwards (julian-edwards)
Changed in launchpad:
status: Fix Released → Fix Committed
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Not quite released. Cancelling over the API works, but there's a pending branch for the UI changes.

Julian Edwards (julian-edwards)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Tom Haddon (mthaddon) wrote :

I thought there was a separate bug for this, but I can't seem to find it. This doesn't appear to be possible for all builds - an example of one that it doesn't work for is https://launchpad.net/ubuntu/+source/libreoffice/1:3.5.0~beta2-2ubuntu1/+build/3082920 (armel).

Changed in launchpad:
status: Fix Released → Confirmed
Revision history for this message
Julian Edwards (julian-edwards) wrote :

It only works for virtual builds at the moment. To get it working for non-virtual is trickier.

Changed in launchpad:
status: Confirmed → Triaged
Francis J. Lacoste (flacoste)
tags: removed: escalated
reneb (corbeau-5)
Changed in launchpad:
status: Triaged → Fix Committed
Julian Edwards (julian-edwards)
Changed in launchpad:
status: Fix Committed → Triaged
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Julian Edwards (julian-edwards) → nobody
William Grant (wgrant)
tags: added: buildd-manager
removed: bad-commit-14192 qa-ok
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Critical → High
Colin Watson (cjwatson)
Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
William Grant (wgrant)
Changed in launchpad:
status: In Progress → Fix Released
radek wolny (wolny-radek)
summary: - In progress builds cannot be cancelled
+ In progress builds cannot be cancelled#173018
Anders Kaseorg (andersk)
summary: - In progress builds cannot be cancelled#173018
+ In progress builds cannot be cancelled
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.