'git ubuntu build-source -v --sign --for-merge' uses Debian instead of Ubuntu containers
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-ubuntu |
Fix Released
|
High
|
Nish Aravamudan |
Bug Description
The documentation at <https:/
I haven't looked to see why it wants to do this (the actual container launch failed because I happen to currently be running an upstream kernel for debugging, so zfs support is missing; so whatever it would tell me next, it never gets that far). But there shouldn't be any reason to download and run a Debian container as part of an Ubuntu source package build. If this is for retrieving the orig tarballs, why isn't this already in the git repo via pristine-tar as part of the import? And if there is some reason it shouldn't be done as part of the import, why would we need a Debian container image when debian-keyring + apt is all that's needed to securely download the orig tarballs into a local target?
Related branches
- Robie Basak: Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 71 lines (+23/-29)1 file modifiedgitubuntu/build.py (+23/-29)
tags: | added: merge |
summary: |
- 'git ubuntu build-source -v --sign --for-merge' should not require - Debian containers + 'git ubuntu build-source -v --sign --for-merge' uses Debian instead of + Ubuntu containers |
Changed in usd-importer: | |
status: | New → Triaged |
importance: | Undecided → High |
milestone: | none → 1.0 |
Changed in usd-importer: | |
assignee: | nobody → Nish Aravamudan (nacc) |
milestone: | lp-beta → future |
Technically I believe that to build a source package, you need to install build dependencies and run the clean target first (which may depend on build dependencies). This may for example produce a control from a control.in, or similar, via a build dependency. That's why we're doing this in a container by default.
In the common case you can get away without this, but I wanted to avoid having to give first time contributors excuses about why the default case doesn't work. So I'm going for a container-based build being the default so that all source packages in the archive (including historical ones where possible) can be built without exception as much as possible.
I expect experienced developers will want to use --no-lxd by default. I intend for there to be some kind of per-user configuration option to make this this automatic for them.
This is currently by design, so this is Invalid I think. But I appreciate your option. Feel free to tell me why I'm wrong right here :)