new -v option must not have a space

Bug #1721247 reported by Andreas Hasenack
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
git-ubuntu
Fix Released
Undecided
Andreas Hasenack

Bug Description

During a lxd binary build I got this:

10/04/2017 09:44:46 - ERROR:Command exited 2: /usr/bin/lxc exec gu-build-d788b108-6ea8-46ac-8201-2e04de21bf4a -- sh -c "cd /tmp/tmp.ykCNY8py26/cyrus-sasl2-2.1.27~101-g0780600+dfsg-3ubuntu1 && dpkg-buildpackage -S -i -I -us -uc -v 2.1.27~101-g0780600+dfsg-2ubuntu1"
10/04/2017 09:44:46 - ERROR:stdout:
10/04/2017 09:44:46 - ERROR:stderr: dpkg-buildpackage: error: unknown option or argument 2.1.27~101-g0780600+dfsg-2ubuntu1

I don't know how I missed that in the review, because I did builds with that branch. Maybe I didn't wait until the end.

Related branches

Revision history for this message
Robie Basak (racb) wrote :

IIRC, this is exactly how dpkg-buildpackage behaves, and git ubuntu is just passing it through. I'm not sure it makes sense for git ubuntu to parse a different form, translate it and pass that through.

Do I misunderstand what you're requesting?

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I think so :)

$ dpkg-buildpackage -uc -us -v 1.2.3
dpkg-buildpackage: error: unknown option or argument 1.2.3

Use --help for program usage information.

dpkg-buildpackage(1):

       -vversion

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This should fix it (untested):

diff --git a/gitubuntu/build.py b/gitubuntu/build.py
index 9a09d6a..a8972f4 100644
--- a/gitubuntu/build.py
+++ b/gitubuntu/build.py
@@ -451,7 +451,7 @@ def main(
                 'pkg/ubuntu/devel',
             )
             if all('-v' not in arg for arg in rem_args):
- rem_args.extend(['-v', oldubuntu_version,])
+ rem_args.append('-v%s' % oldubuntu_version)
             else:
                 logging.warning(
                     "-v specified manually, not passing -v%s automatically",

Revision history for this message
Nish Aravamudan (nacc) wrote : Re: [Bug 1721247] Re: new -v option must not have a space

Yep, that does look right, can you submit it as a MP?

On Wed, Oct 4, 2017 at 6:42 AM, Andreas Hasenack <email address hidden> wrote:
> This should fix it (untested):
>
> diff --git a/gitubuntu/build.py b/gitubuntu/build.py
> index 9a09d6a..a8972f4 100644
> --- a/gitubuntu/build.py
> +++ b/gitubuntu/build.py
> @@ -451,7 +451,7 @@ def main(
> 'pkg/ubuntu/devel',
> )
> if all('-v' not in arg for arg in rem_args):
> - rem_args.extend(['-v', oldubuntu_version,])
> + rem_args.append('-v%s' % oldubuntu_version)
> else:
> logging.warning(
> "-v specified manually, not passing -v%s automatically",
>
> --
> You received this bug notification because you are a member of Ubuntu
> Server Dev import team, which is subscribed to usd-importer.
> https://bugs.launchpad.net/bugs/1721247
>
> Title:
> new -v option must not have a space
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/usd-importer/+bug/1721247/+subscriptions

Changed in usd-importer:
assignee: nobody → Andreas Hasenack (ahasenack)
status: New → In Progress
Nish Aravamudan (nacc)
Changed in usd-importer:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.