Qt apps not fullscreening under miral-kiosk
Bug #1717910 reported by
Gerry Boland
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Critical
|
Alan Griffiths | ||
Bug Description
Running:
./bin/miral-kiosk --x11-displays=
and for example:
QT_QPA_
results in a not-fullscreen window in the Miral shell.
Digging I see that the kiosk window manager isn't implementing place_new_window. Adding this simple patch: https:/
I will admit Qtubuntu probably has an issue too, as the kiosk WM does send resize events in advise_new_window, but Qt seems to be ignoring them
Related branches
lp:~alan-griffiths/mir/fix-1717910
- Mir CI Bot: Needs Fixing (continuous-integration)
- Gerry Boland (community): Approve
-
Diff: 116 lines (+38/-19)4 files modifieddebian/changelog (+2/-0)
examples/miral-kiosk/kiosk_window_manager.cpp (+30/-15)
examples/miral-kiosk/kiosk_window_manager.h (+5/-3)
include/miral/miral/canonical_window_manager.h (+1/-1)
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | #1 |
| Changed in mir: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| milestone: | none → 1.0.0 |
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | #2 |
| Changed in mir: | |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
| status: | Triaged → In Progress |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The patch assumes a single output. The correct logic is in KioskWindowMana
We don't really care about gtk-mir, so moving that code to KioskWindowMana