Mir

Wayland clients do not work on miral-desktop

Bug #1716353 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Critical
Alan Griffiths
Mir 0.28.0

Bug Description

Install mir-examples from the staging PPA (or build Mir from trunk)

$ sudo add-apt-repository ppa:mir-team/staging
$ sudo apt update
$ sudo apt install mir-examples

Then run miral-desktop:

$ miral-desktop

In the terminal run:

$ QT_QPA_PLATFORM=wayland kate

Expect: Kate starts, using wayland
Actual: Kate crashes with "Failed to create display (No such file or directory)"

Tags: wayland

Related branches

lp:~alan-griffiths/mir/fix-1716353
Mir CI Bot: Needs Fixing (continuous-integration)
Gerry Boland (community): Approve
Brandon Schaefer (community): Approve
Diff: 91 lines (+20/-5)
4 files modified
examples/miral-shell/miral-desktop.sh (+1/-1)
src/server/frontend/wayland/wayland_connector.cpp (+12/-2)
src/server/frontend/wayland/wayland_connector.h (+2/-1)
src/server/frontend/wayland/wayland_default_configuration.cpp (+5/-1)
lp:mir
PS Jenkins bot (community): Approve (continuous-integration)
Alan Griffiths: Approve
Kevin DuBois (community): Approve
Diff: 1373 lines (+579/-161)
23 files modified
3rd_party/android-input/android/frameworks/base/services/input/MirLog.cpp (+157/-5)
include/test/mir_test_framework/display_server_test_fixture.h (+2/-0)
include/test/mir_test_framework/stub_client_connection_configuration.h (+35/-0)
include/test/mir_test_framework/testing_client_configuration.h (+43/-0)
include/test/mir_test_framework/testing_process_manager.h (+7/-8)
src/client/mir_client_library.cpp (+39/-17)
src/server/graphics/android/hwc_common_device.cpp (+15/-13)
src/server/options/program_option.cpp (+2/-1)
tests/acceptance-tests/test_client_authorization.cpp (+7/-0)
tests/acceptance-tests/test_client_focus_notification.cpp (+2/-9)
tests/acceptance-tests/test_client_input.cpp (+8/-15)
tests/acceptance-tests/test_client_library.cpp (+30/-17)
tests/acceptance-tests/test_focus_selection.cpp (+2/-9)
tests/acceptance-tests/test_server_shutdown.cpp (+2/-9)
tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+2/-9)
tests/acceptance-tests/test_surfaceloop.cpp (+3/-10)
tests/acceptance-tests/test_surfaces_with_output_id.cpp (+2/-9)
tests/mir_test_framework/CMakeLists.txt (+1/-0)
tests/mir_test_framework/display_server_test_fixture.cpp (+9/-6)
tests/mir_test_framework/testing_client_options.cpp (+126/-0)
tests/mir_test_framework/testing_process_manager.cpp (+41/-1)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+25/-1)
tests/unit-tests/logging/test_legacy_input_report.cpp (+19/-22)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

The corresponding scenario works with mir-app, so I suspect that running the shell as root and connecting as the user is a usecase that doesn't (yet) work.

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Yes, the client is looking for $XDG_RUNTIME_DIR/wayland-0 - which (obviously) the server didn't create. There ought to be a way to configure this right.

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

OK, so what is happening is that wl_display_add_socket_auto(display) relies on $XDG_RUNTIME_DIR being set. That's a sensible default, but, as root, this isn't the case so no socket is created.

The client is looking in the right place, we just need a way for the script to specify the wayland socket to the server, and that needs to call wl_display_add_socket(<socket>, display) instead. (Much as we do for the legacy Mir socket.)

Changed in mir:
assignee: nobody → Alan Griffiths (alan-griffiths)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Nope, wl_display_add_socket() also insists on having XDG_RUNTIME_DIR, we'll have to go with the flow.

Alan Griffiths (alan-griffiths)
Changed in mir:
status: Triaged → Fix Committed
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.