Cinder

py35 tests failing due to iso8601 module change

Bug #1715486 reported by Sean McGinnis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Sean McGinnis
CloudPulse
In Progress
Undecided
zhangyangyang
Cue
In Progress
Undecided
zhangyangyang
IoTronic
Fix Released
Undecided
zhangyangyang
Ironic
Fix Released
High
Sean McGinnis
Magnum
Fix Released
Undecided
Sean McGinnis
Mogan
Fix Released
High
Sean McGinnis
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Sean McGinnis
masakari
Fix Released
Undecided
SamP
oslo.versionedobjects
Fix Released
Medium
maoxinya
senlin
Fix Released
Undecided
SamP
watcher
Fix Released
Undecided
SamP

Bug Description

Python 3.x moved where the iso8601 Utc() method is located. Need to handle new path.

Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-cross-cinder-python35/cinder/tests/unit/api/contrib/test_admin_actions.py", line 829, in setUp
    self.svc = self.start_service('volume', host='test')
  File "/home/jenkins/workspace/gate-cross-cinder-python35/cinder/test.py", line 323, in start_service
    svc = service.Service.create(**kwargs)
  File "/home/jenkins/workspace/gate-cross-cinder-python35/cinder/service.py", line 425, in create
    cluster=cluster)
  File "/home/jenkins/workspace/gate-cross-cinder-python35/cinder/service.py", line 203, in __init__
    self._create_service_ref(ctxt, manager_class.RPC_API_VERSION)
  File "/home/jenkins/workspace/gate-cross-cinder-python35/cinder/service.py", line 374, in _create_service_ref
    service_ref.create()
  File "/home/jenkins/workspace/gate-cross-cinder-python35/cinder/objects/service.py", line 143, in create
    self._from_db_object(self._context, self, db_service)
  File "/home/jenkins/workspace/gate-cross-cinder-python35/cinder/objects/service.py", line 86, in _from_db_object
    service[name] = value
  File "/home/jenkins/workspace/gate-cross-cinder-python35/.tox/py35/lib/python3.5/site-packages/oslo_versionedobjects/base.py", line 765, in __setitem__
    setattr(self, name, value)
  File "/home/jenkins/workspace/gate-cross-cinder-python35/.tox/py35/lib/python3.5/site-packages/oslo_versionedobjects/base.py", line 72, in setter
    field_value = field.coerce(self, name, value)
  File "/home/jenkins/workspace/gate-cross-cinder-python35/.tox/py35/lib/python3.5/site-packages/oslo_versionedobjects/fields.py", line 195, in coerce
    return self._type.coerce(obj, attr, value)
  File "/home/jenkins/workspace/gate-cross-cinder-python35/.tox/py35/lib/python3.5/site-packages/oslo_versionedobjects/fields.py", line 471, in coerce
    value = value.replace(tzinfo=iso8601.iso8601.Utc())
AttributeError: module 'iso8601.iso8601' has no attribute 'Utc'

Sean McGinnis (sean-mcginnis)
Changed in cinder:
assignee: nobody → Sean McGinnis (sean-mcginnis)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Looks like there are several projects that will need to update for this change:

http://codesearch.openstack.org/?q=iso8601.Utc()&i=nope&files=&repos=

Revision history for this message
Matt Riedemann (mriedem) wrote :

There was another bug 1715486 for this which fixed it in nova already:

https://review.openstack.org/#/c/498287/

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

oslo.versionedobjects already in the works with https://bugs.launchpad.net/nova/+bug/1713354

no longer affects: oslo.versionedobjects
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501472

Changed in manila:
assignee: nobody → Sean McGinnis (sean-mcginnis)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501474

Changed in ironic:
assignee: nobody → Sean McGinnis (sean-mcginnis)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501476

Changed in magnum:
assignee: nobody → Sean McGinnis (sean-mcginnis)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501479

Changed in mogan:
assignee: nobody → Sean McGinnis (sean-mcginnis)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mogan (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501480

SamP (sampath-priyankara)
Changed in masakari:
assignee: nobody → SamP (sampath-priyankara)
Changed in senlin:
assignee: nobody → SamP (sampath-priyankara)
Changed in watcher:
assignee: nobody → SamP (sampath-priyankara)
Zhenguo Niu (niu-zglinux)
Changed in mogan:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to masakari (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501515

Changed in masakari:
status: New → In Progress
Changed in senlin:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501516

Changed in watcher:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to watcher (master)

Fix proposed to branch: master
Review: https://review.openstack.org/501518

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/501474
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=a63d4bafdbadf3308ee368c85e693184efc592b4
Submitter: Jenkins
Branch: master

commit a63d4bafdbadf3308ee368c85e693184efc592b4
Author: Sean McGinnis <email address hidden>
Date: Wed Sep 6 16:51:12 2017 -0500

    Use newer location for iso8601 UTC

    Newer versions have moved from iso8601.iso8601.Utc() to
    just iso8601.UTC, causing tests to fail under py35.

    Change-Id: I387c85f649316b26109eb1bc21da5ce24c450852
    Closes-bug: #1715486

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mogan (master)

Reviewed: https://review.openstack.org/501480
Committed: https://git.openstack.org/cgit/openstack/mogan/commit/?id=07caad2946177c0aee972f6b535fe08d44d4d5c0
Submitter: Jenkins
Branch: master

commit 07caad2946177c0aee972f6b535fe08d44d4d5c0
Author: Sean McGinnis <email address hidden>
Date: Wed Sep 6 16:59:07 2017 -0500

    Use newer location for iso8601 UTC

    Newer versions have moved from iso8601.iso8601.Utc() to
    just iso8601.UTC, causing tests to fail under py35.

    Change-Id: Ic2e3d395335003d043b400e96184ceb3a238063d
    Closes-bug: #1715486

Changed in mogan:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/501479
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=640217d22ebfc07fbab84ef7b8c3c974fbc75a8a
Submitter: Jenkins
Branch: master

commit 640217d22ebfc07fbab84ef7b8c3c974fbc75a8a
Author: Sean McGinnis <email address hidden>
Date: Wed Sep 6 16:57:21 2017 -0500

    Use newer location for iso8601 UTC

    Newer versions have moved from iso8601.iso8601.Utc() to
    just iso8601.UTC, causing tests to fail under py35.

    Change-Id: I59c771b6803866282912c2067ff5ed25bba13626
    Closes-bug: #1715486

Changed in magnum:
status: In Progress → Fix Released
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/501476
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=c8b8fe86fc8640386fc59e3f42f9995e8507ab45
Submitter: Jenkins
Branch: master

commit c8b8fe86fc8640386fc59e3f42f9995e8507ab45
Author: Sean McGinnis <email address hidden>
Date: Wed Sep 6 16:54:25 2017 -0500

    Use newer location for iso8601 UTC

    Newer versions have moved from iso8601.iso8601.Utc() to
    just iso8601.UTC, causing tests to fail under py35.

    Change-Id: Ie35ef49546dd322c2630c77d528a197ff295c3ae
    Closes-bug: #1715486

Changed in ironic:
status: In Progress → Fix Released
Revision history for this message
Gorka Eguileor (gorka) wrote :

For reference, the patch [1] that caused this issue was introduced in 0.1.12.

[1] https://bitbucket.org/micktwomey/pyiso8601/commits/a1f771bc36754edb2fd649ab2fbe6b788b6c6149

zhangyangyang (zhangyangyang)
Changed in cloudpulse:
assignee: nobody → zhangyangyang (zhangyangyang)
Changed in cue:
assignee: nobody → zhangyangyang (zhangyangyang)
Changed in iotronic:
assignee: nobody → zhangyangyang (zhangyangyang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cloudpulse (master)

Fix proposed to branch: master
Review: https://review.openstack.org/502023

Changed in cloudpulse:
status: New → In Progress
zhangyangyang (zhangyangyang)
Changed in cue:
status: New → In Progress
Changed in iotronic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cue (master)

Fix proposed to branch: master
Review: https://review.openstack.org/502027

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to iotronic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/502028

zhangyangyang (zhangyangyang)
Changed in oslo.versionedobjects:
assignee: nobody → zhangyangyang (zhangyangyang)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.versionedobjects (master)

Fix proposed to branch: master
Review: https://review.openstack.org/502029

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin (master)

Reviewed: https://review.openstack.org/501516
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=1ae1a61a34179ca6d028d43498351214db9ef60a
Submitter: Jenkins
Branch: master

commit 1ae1a61a34179ca6d028d43498351214db9ef60a
Author: Sampath Priyankara <email address hidden>
Date: Thu Sep 7 10:31:07 2017 +0900

    iso8601.is8601.Utc No Longer Exists

    iso8601.UTC is correct datetime UTC field object.
    iso8601 >= 0.1.12 includes only iso8601.UTC for python3
    while both UTC and Utc() for python2. Less then 0.1.12
    included both UTC and Utc() for both python2/3.

    Change-Id: I53de9164d17551fb08fa5eb554856a9aa3aafec6
    Closes-Bug: #1715486

Changed in senlin:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/501472
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=2f9ca1b4defb68a394f874b02b205b6ec27b9179
Submitter: Jenkins
Branch: master

commit 2f9ca1b4defb68a394f874b02b205b6ec27b9179
Author: Sean McGinnis <email address hidden>
Date: Wed Sep 6 16:47:52 2017 -0500

    Use newer location for iso8601 UTC

    Newer versions have moved from iso8601.iso8601.Utc() to
    just iso8601.UTC, causing tests to fail under py35.

    Change-Id: I9c0bb9f28c2abe3d7c33c4cff4fa1e968aae52ce
    Closes-bug: #1715486

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/501518
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=887fa746aec17e673e418d96f2e8476194c38de5
Submitter: Jenkins
Branch: master

commit 887fa746aec17e673e418d96f2e8476194c38de5
Author: Sampath Priyankara <email address hidden>
Date: Thu Sep 7 10:40:49 2017 +0900

    iso8601.is8601.Utc No Longer Exists

    iso8601.UTC is correct datetime UTC field object.
    iso8601 >= 0.1.12 includes only iso8601.UTC for python3
    while both UTC and Utc() for python2. Less then 0.1.12
    included both UTC and Utc() for both python2/3.

    Change-Id: I0f8796fba6725eea013b3f8d9ad33c10a402c524
    Closes-Bug: #1715486

Changed in watcher:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on oslo.versionedobjects (master)

Change abandoned by zhangyangyang (<email address hidden>) on branch: master
Review: https://review.openstack.org/502029

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cue (master)

Change abandoned by zhangyangyang (<email address hidden>) on branch: master
Review: https://review.openstack.org/502027

Revision history for this message
Matthew Thode (prometheanfire) wrote :

fixed in https://review.openstack.org/#/c/498275/

Changed in oslo.versionedobjects:
assignee: zhangyangyang (zhangyangyang) → nobody
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to masakari (master)

Reviewed: https://review.openstack.org/501515
Committed: https://git.openstack.org/cgit/openstack/masakari/commit/?id=d9c87bba0adc3f27b90d8309381c3f1445ba7bf1
Submitter: Zuul
Branch: master

commit d9c87bba0adc3f27b90d8309381c3f1445ba7bf1
Author: Sampath Priyankara <email address hidden>
Date: Thu Sep 7 10:25:30 2017 +0900

    iso8601.is8601.Utc No Longer Exists

    iso8601.UTC is correct datetime UTC field object.
    iso8601 >= 0.1.12 includes only iso8601.UTC for python3
    while both UTC and Utc() for python2. Less then 0.1.12
    included both UTC and Utc() for both python2/3.

    Change-Id: I9b2a8ba5a5ab44c95e68d67e0e3ee8e2c0024b03
    Closes-Bug: #1715486

Changed in masakari:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to iotronic (master)

Reviewed: https://review.openstack.org/502028
Committed: https://git.openstack.org/cgit/openstack/iotronic/commit/?id=7cf5f4de23c4ecf7945e8cdb4d082d1da277b924
Submitter: Jenkins
Branch: master

commit 7cf5f4de23c4ecf7945e8cdb4d082d1da277b924
Author: zhangyangyang <email address hidden>
Date: Fri Sep 8 18:17:11 2017 +0800

    Use newer location for iso8601 UTC

    Newer versions have moved from iso8601.iso8601.Utc()
    to just iso8601.UTC.

    Change-Id: Ia6d65aafc57fb0abbbef0ef5987d79ddeb843344
    Closes-Bug:#1715486

Changed in iotronic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cloudpulse (master)

Change abandoned by zhangyangyang (<email address hidden>) on branch: master
Review: https://review.openstack.org/502023

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.0.0b1

This issue was fixed in the openstack/cinder 12.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/watcher 1.5.0

This issue was fixed in the openstack/watcher 1.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 6.0.0.0b1

This issue was fixed in the openstack/manila 6.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 9.2.0

This issue was fixed in the openstack/ironic 9.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/senlin 5.0.0.0b2

This issue was fixed in the openstack/senlin 5.0.0.0b2 development milestone.

Revision history for this message
Matthew Thode (prometheanfire) wrote :

glance: http://logs.openstack.org/73/535173/3/check/cross-glance-py35/9b06b73/testr_results.html.gz

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

This new Glance failure looks to be a little different. Instead of changing the location, it looks like they have now changed the default format for zulu to UTC.

I wonder if we should open a new bug for this one, as this will probably impact a lot of the same projects and will have a different solution.

Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Opened https://bugs.launchpad.net/glance/+bug/1744160 to track this new failure.

no longer affects: glance
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/senlin 5.0.0.0b3

This issue was fixed in the openstack/senlin 5.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 6.0.0

This issue was fixed in the openstack/magnum 6.0.0 release.

Stephen Finucane (stephenfinucane)
Changed in oslo.versionedobjects:
importance: Undecided → Medium
status: Fix Committed → Fix Released
maoxinya (maoxinya)
Changed in oslo.versionedobjects:
assignee: nobody → maoxinya (maoxinya)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.