karbor-dashboard

Previous page in checkpoints pagination not work

Bug #1714909 reported by jiaopengju
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
karbor-dashboard
Fix Released
Undecided
jiaopengju

Bug Description

Currently, previous page in checkpoints pagination can not work, it always throw an error on the web page.

With the code, I found that the sort_key of checkpoints is 'name', but 'name' is not in the returned checkpoints' entity. IMO, we should use 'id' instead.

With using 'id', there are also some issues:
After clicking next page or previous page several times, dashboard will show wrong content (for example, show 10 checkpoints in one page), this should also be fixed.

jiaopengju (pj-jiao)
Changed in karbor-dashboard:
assignee: nobody → jiaopengju (pj-jiao)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to karbor-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/500656

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to karbor-dashboard (master)

Reviewed: https://review.openstack.org/500656
Committed: https://git.openstack.org/cgit/openstack/karbor-dashboard/commit/?id=1d7fd7c754c48f39534984d1792698f2dce17e10
Submitter: Jenkins
Branch: master

commit 1d7fd7c754c48f39534984d1792698f2dce17e10
Author: Pengju Jiao <email address hidden>
Date: Tue Sep 5 10:25:10 2017 +0800

    Fix checkpoints pagination error

    Currently, previous page in checkpoints pagination not
    work, it always throw an error in the web page. It is
    because that checkpoints in karbor do not need reverse
    the order (checkpoints are sorted by 'timestamp@id' in
    the backend, so we can not do the reverse only be the
    id or name)

    This patch will fix it.

    Change-Id: I45c3e7337bf2ee9d3f2fbf9ee7a438884b8b8ca9
    Closes-Bug: #1714909

Changed in karbor-dashboard:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/karbor-dashboard 0.5.0

This issue was fixed in the openstack/karbor-dashboard 0.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.