merge irqbalance for artful

Bug #1712256 reported by Christian Ehrhardt 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
irqbalance (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

All Delta that is left is for bug 1454273.

There is now the systemd unit properly delivered in the latest Debian packages.
Further as Brian outlined it is no more directly stalling the startup using that unit.
And finally it was upstream denied to be disabled in [1].
There are more fixes we could pick up and this is the last delta left to make this a sync.

Given the history on this I'd want to make this a sync for artful, but since this is "discussion-worthy" I'd want a 2nd opinion.

OTOH I personally think it doesn't make sens in containers, even with the opposite being stated in the issue tracker - yet none of us can yet prove one or the other.
In any case we can now drop the non systemd-changes and [2] should make the detection more clean and the delta even smaller.

I'll propose a merge, but I'd also be ok with a sync as outlined, but don't want to decide alone.

[1]: https://github.com/Irqbalance/irqbalance/issues/27
[2]: https://www.freedesktop.org/software/systemd/man/systemd.unit.html

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

While searching for more background I found further links and [1] is interesting.
This has patch [2] which is now upstream.
Which is funny as it is a 100% match of the Delta I just wanted to add for review.

But that said, this is now actually upstream accepted.
So:
1. let this be a merge still for this cycle
2. mark my change as a backport of the upstream patch instead
3. on next cycle once upstream released a new version we can make it a sync

[1]: https://github.com/Irqbalance/irqbalance/issues/32
[2]: https://github.com/Irqbalance/irqbalance/commit/d0405967a997c1e57d75541def45b5139677115b

Changed in irqbalance (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package irqbalance - 1.1.0-2.3ubuntu1

---------------
irqbalance (1.1.0-2.3ubuntu1) artful; urgency=medium

  * Merge with Debian unstable (LP: #1712256). Remaining changes:
    - Drop upstart system jobs.
      - delete d/irqbalance.upstart
      - d/irqbalance.maintscript: conffile handling (droppable >18.04)
  * Dropped changes (no more relevant):
    - Do not start when inside a container (LP 1454273)
  * Added changes:
    - Do not start when inside a container (LP 1454273) but for systemd now

 -- Christian Ehrhardt <email address hidden> Wed, 23 Aug 2017 13:35:55 +0200

Changed in irqbalance (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.