Ubuntu
ubuntu-themes package

battery icon is distorded under GNOME Shell

Bug #1711085 reported by Didier Roche-Tolomelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
indicator-power (Ubuntu)
Fix Released
Undecided
Unassigned
ubuntu-themes (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Even if https://bugs.launchpad.net/ubuntu/+source/ubuntu-themes/+bug/1693155 is fixed, the icon is still distorded in non Hi-DPI environment. The issue is that the icons aren't really square. Let's use the upstrema indicator icons, while still preserving them in the Unity session.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Alternatively I could also elongate those squarish 16x16 icons that are causing the problem. They're just squarish so as to keep all the original detail and border from the old wider icons.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Let's use that proven path for now and revisit later on, shall we? :)

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm not sure which path you mean... Adwaita icons are proven for Gnome Shell but break Unity (Unity needs changing to avoid loading some of them by accident). The icons we have right now are the only proven solution that work in Gnome Shell and Unity.

So there are at least four ways forward:
 (a) Do nothing
 (b) Make the 16x16 battery icons longer and less square
 (c) Use Adwaita battery icons, but this requires changing Unity code to not pick some up by accident.
 (d) Modify Gnome Shell code to support our old rectangular icons from 17.04.

It sounds to me like either of your preferred options (c) and (d) require shell code hacking.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

We discussed it a couple of times with seb on #ubuntu-desktop in the past week and the current approach is to prefix icons name with unity- and have indicator-power loading them in priority.

Please refrain modifying bugs that are opened for tracking without talking on IRC. This is the second time and give additional work as I have now to remove the additional components (gnome-shell and unity) you added…

no longer affects: gnome-shell (Ubuntu)
no longer affects: unity (Ubuntu)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-power - 12.10.6+17.10.20170817-0ubuntu1

---------------
indicator-power (12.10.6+17.10.20170817-0ubuntu1) artful; urgency=medium

  * Try using unity-* prepended icons before real ones. As the battery
    icons in ubuntu-mono aren't square, we want to special case them
    (LP: #1711085).
  * Adapt test for the above change.

 -- Didier Roche <email address hidden> Thu, 17 Aug 2017 08:30:02 +0200

Changed in indicator-power (Ubuntu):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-themes - 16.10+17.10.20170817-0ubuntu1

---------------
ubuntu-themes (16.10+17.10.20170817-0ubuntu1) artful; urgency=medium

  * Rename most battery icons prepending unity-*. As the battery
    icons in ubuntu-mono aren't square, we want to special case them
    (LP: #1711085).

 -- Didier Roche <email address hidden> Wed, 16 Aug 2017 15:35:22 +0200

Changed in ubuntu-themes (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.