Ubuntu
pollinate package

SRU pollinate 4.25

Bug #1708192 reported by Scott Moser
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pollinate (Ubuntu)
Fix Released
Medium
Unassigned
Trusty
Fix Released
Medium
Scott Moser
Xenial
Fix Released
Medium
Scott Moser
Zesty
Fix Released
Medium
Unassigned
Artful
Fix Released
Medium
Unassigned

Bug Description

=== Begin SRU Template ===
[Impact]
The key change is that the user agent string as of Zesty and Artful now
contains the contents of /proc/uptime. In aggregate, this gives us
important performance data to detect improvements and regressions in
Ubuntu boot times.

[Test Case]
Launch a privileged container with:

1. lxc launch ubuntu-daily:xenial -c security.privileged=true x1-priv
2. lxc exec x1-priv -- apt update && apt -y install pollen

Run a local pollen server and have the pollinate (client) connect with that via:

3. lxc exec x1-priv -- pollinate -r --insecure -s https://localhost

Then check in /var/log/syslog for the client user-agent string. On systems without the updated pollinate client, the USER_AGENT value does not include uptime:

root@x1-priv:~# grep pollen /var/log/syslog | grep -c uptime
0
root@x1-priv:~#

After upgrading to the newer client, uptime is now present in the pollen entries:

root@x1-priv:~# grep pollen /var/log/syslog | grep -c uptime
2
root@x1-priv:~#

The two changes are:
a.) the defaults file /etc/default/pollinate file was sourced twice during
execution. That was unlikely to cause issue, but the cleanup removed
unnecessary duplication.

b.) uptime is read from /proc/cpuinfo and added to the USER_AGENT
variable that is fed to curl.

[Regression Potential]
The script runs with 'set -e', and reads from /proc/uptime with:
   read up idle < /proc/uptime

That means that the 'pollinate' script will exit failure if either:
a.) /proc/uptime did not exist (possibly proc not mounted)
b.) a read error occurred.

These scenarios seem unlikely, especially in Ubuntu environments.
The upstream code should check to at least check the readability of
/proc/uptime first. I've filed bug 1708461 to address that issue
and submitted a merge proposal for a fix.

[Other Info]
The reading of up/idle from uptime was originally added under bug 1638552.
=== End SRU Template ===

See original description
Scott Moser (smoser)
Changed in pollinate (Ubuntu Zesty):
status: New → Fix Released
importance: Undecided → Medium
Changed in pollinate (Ubuntu Artful):
status: New → Fix Released
importance: Undecided → Medium
Changed in pollinate (Ubuntu Xenial):
status: New → Confirmed
Changed in pollinate (Ubuntu Trusty):
status: New → Confirmed
importance: Undecided → Medium
Changed in pollinate (Ubuntu Xenial):
importance: Undecided → Medium
Scott Moser (smoser)
description: updated
Scott Moser (smoser)
summary: - SRU pollinate > 4.25
+ SRU pollinate 4.25
Revision history for this message
Scott Moser (smoser) wrote :

pollinate at 4.25-0ubuntu1~16.04.1 and 4.25-0ubuntu1~14.04.1 is in xenial and trusty queue:
https://launchpad.net/ubuntu/xenial/+queue?queue_state=1&queue_text=pollinate
https://launchpad.net/ubuntu/trusty/+queue?queue_state=1&queue_text=pollinate

description: updated
description: updated
Scott Moser (smoser)
description: updated
Andreas Hasenack (ahasenack)
Changed in pollinate (Ubuntu Trusty):
status: Confirmed → In Progress
Changed in pollinate (Ubuntu Xenial):
status: Confirmed → In Progress
Changed in pollinate (Ubuntu Trusty):
assignee: nobody → Scott Moser (smoser)
Changed in pollinate (Ubuntu Xenial):
assignee: nobody → Scott Moser (smoser)
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Scott, or anyone else affected,

Accepted pollinate into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pollinate/4.25-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in pollinate (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Scott, or anyone else affected,

Accepted pollinate into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pollinate/4.25-0ubuntu1~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in pollinate (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed-trusty
Ryan Harper (raharper)
description: updated
Revision history for this message
Ryan Harper (raharper) wrote :

Xenial verification is complete. Everything looks correct with uptime now present in the USER_AGENT string sent to a pollen server.

Attaching log of xenial verification test.

Revision history for this message
Ryan Harper (raharper) wrote :

Trusty verification test results. Updated client now provides uptime string in USER_AGENT sent to pollen server, passing verification.

Ryan Harper (raharper)
tags: added: verification-done verification-done-trusty verification-done-xenial
removed: verification-needed verification-needed-trusty verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pollinate - 4.25-0ubuntu1~14.04.1

---------------
pollinate (4.25-0ubuntu1~14.04.1) trusty; urgency=medium

  * New upstream release (LP: #1708192):
    - remove duplicate config file sourcing
    - Include uptime/idletime in the user-agent string to help measure
      boot performance.

 -- Scott Moser <email address hidden> Wed, 02 Aug 2017 14:34:51 -0400

Changed in pollinate (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for pollinate has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pollinate - 4.25-0ubuntu1~16.04.1

---------------
pollinate (4.25-0ubuntu1~16.04.1) xenial; urgency=medium

  * New upstream release (LP: #1708192):
    - remove duplicate config file sourcing
    - Include uptime/idletime in the user-agent string to help measure
      boot performance.

 -- Scott Moser <email address hidden> Wed, 02 Aug 2017 13:35:16 -0400

Changed in pollinate (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.