subcommands fail when only a local import exists
Bug #1699541 reported by
Robie Basak
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-ubuntu |
Fix Released
|
Medium
|
Unassigned |
Bug Description
"git queue sync" expects to find the devel pointers in refs/remotes/
Workaround for "git queue sync" is to use --parent (and --series, --no-trim, --no-fetch and --source) to specify the parent commit precisely.
Long term, we think we need to teach GitRepository.
Related branches
~racb/git-ubuntu:lp1699541-queue-local-import
- Server Team CI bot: Approve (continuous-integration)
- Robie Basak: Approve
-
Diff: 63 lines (+23/-7)1 file modifiedgitubuntu/queue.py (+23/-7)
~nacc/git-ubuntu:lp1699541-queue-local-import
Superseded
for merging
into
git-ubuntu:master
- Server Team CI bot: Approve (continuous-integration)
- Robie Basak: Pending requested
-
Diff: 54 lines (+22/-6)1 file modifiedgitubuntu/queue.py (+22/-6)
Changed in usd-importer: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
tags: | added: local-importer-ux |
Changed in usd-importer: | |
milestone: | none → 1.0 |
Changed in usd-importer: | |
status: | Confirmed → In Progress |
Changed in usd-importer: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
Hrm, while I appreciate the difficulty here, how likely are local imports going to be?
To be clear, get_heads_ and_versions can look in multiple prefixes, specified by a namespace (top-level 'directory' in refs/heads/) and a head_prefix (next-level 'directory' in refs/heads/ <namespace> /).
Also, get_heads_ and_versions only deals with local branches, not remote-tracking branches (as they need to be iterated differently).
I would suggest a couple of approaches, but I'm not sure what is best. Here is my initial proposal, though:
1) Restrict changes to queue code for now.
2) Given there are currently only two locations, maybe do some sort of try/except to test for the two possible ref namespaces to expect things in?
Or
1) Change queue to take a parameter that specifies the ref-namespace to look for the importer stuff? If you are doing a local import, then you would pass --import- ref-namespace= refs/headsimpor ter/, and it would default to refs/remotes/pkg ?