Magnum

allow passing master flavor on cluster creation

Bug #1699247 reported by Ricardo Rocha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
Ricardo Rocha

Bug Description

Currently we can only specify the master flavor on cluster template creation.

It would be nice to be able to overwrite this on cluster creation, instead of forcing users to duplicate the template with a different value.

Something like:

# magnum cluster-create --name ... --master-flavor-id m1.large

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/489572

Changed in magnum:
assignee: nobody → Ricardo Rocha (rocha-porto)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/489572
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=446b15934991aa5d8666e6c024c28cf3af4fb398
Submitter: Jenkins
Branch: master

commit 446b15934991aa5d8666e6c024c28cf3af4fb398
Author: Ricardo Rocha <email address hidden>
Date: Tue Aug 1 11:35:21 2017 +0000

    Allow master_flavor_id on cluster create

    Add master_flavor_id as an option during cluster create. If not given,
    the default is taken from the cluster template.

    Add master_flavor_id in the Cluster object and use that instead
    of the one from ClusterTemplate.

    Update both magnum and magnum cli documentation to reflect the above changes.

    Partial-Bug: #1699247
    Change-Id: Id1d973167b381538121583a0a9691304b39e98de

Revision history for this message
Spyros Trigazis (strigazi) wrote :

The osc client to missed
$ git diff
diff --git a/magnumclient/v1/clusters.py b/magnumclient/v1/clusters.py
index 163f30b..df5ebfe 100644
--- a/magnumclient/v1/clusters.py
+++ b/magnumclient/v1/clusters.py
@@ -21,6 +21,7 @@ CREATION_ATTRIBUTES.append('create_timeout')
 CREATION_ATTRIBUTES.append('keypair')
 CREATION_ATTRIBUTES.append('docker_volume_size')
 CREATION_ATTRIBUTES.append('labels')
+CREATION_ATTRIBUTES.append('master_flavor_id')

Otherwise it throws
Key must be in name,node_count,discovery_url,master_count,baymodel_id,bay_create_timeout,cluster_template_id,create_timeout,keypair,docker_volume_size,labels

Revision history for this message
Spyros Trigazis (strigazi) wrote :

This is the error that I get with the openstack client:
$ openstack coe cluster create --cluster-template kube-1-8 --keypair default --master-flavor m1.small kube
Key must be in name,node_count,discovery_url,master_count,baymodel_id,bay_create_timeout,cluster_template_id,create_timeout,keypair,docker_volume_size,labels

Ricardo Rocha (rocha-porto)
Changed in magnum:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.