cloud-init

Identification of e24cloud platform as using Ec2 datasource

Bug #1696476 reported by Marcin Gibula
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
cloud-init
Fix Released
Low
Unassigned

Bug Description

Hi,

I'd like to ask you, to add identification for e24cloud platform (e24cloud.com) with Ec2 Datasource.

It can be identified via system vendor field:

# cat /sys/class/dmi/id/sys_vendor
e24cloud

# dmidecode --string=system-manufacturer
e24cloud

I'll be happy to test a patch.

See original description

Related branches

~smoser/cloud-init:feature/e24cloud
Ryan Harper: Approve
Server Team CI bot: Approve (continuous-integration)
Diff: 179 lines (+59/-4)
7 files modified
cloudinit/apport.py (+1/-0)
cloudinit/sources/DataSourceEc2.py (+11/-1)
doc/rtd/topics/datasources.rst (+2/-1)
doc/rtd/topics/datasources/e24cloud.rst (+9/-0)
tests/unittests/test_datasource/test_ec2.py (+14/-1)
tests/unittests/test_ds_identify.py (+17/-1)
tools/ds-identify (+5/-0)
Marcin Gibula (m-gibula)
description: updated
Revision history for this message
Ryan Harper (raharper) wrote :

Hi, If you'd like to test something out, you can look at some of the other EC2 Look Alike classes, like AliYun.

https://git.launchpad.net/cloud-init/tree/cloudinit/sources/DataSourceAliYun.py

And the commit where this landed shows the other changes needed (tools/ds-identify)

Changed in cloud-init:
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for cloud-init because there has been no activity for 60 days.]

Changed in cloud-init:
status: Incomplete → Expired
Scott Moser (smoser)
Changed in cloud-init:
status: Expired → Triaged
importance: Undecided → Low
Revision history for this message
Scott Moser (smoser) wrote :

@Marcin,
I've attached a branch, would you be able to test that?

Sorry for the 2 year delay.

Revision history for this message
Marcin Gibula (m-gibula) wrote :

Wow, that's unexpected:-)
I'm out of office until wednesday, will test it when I get back.

Thanks!

Revision history for this message
Scott Moser (smoser) wrote :

@Marcin,
Are you able to check?
I'm pretty sure I've implemented the code correctly, but it would sure be nice if we had someone verify that before landing it.

Revision history for this message
Marcin Gibula (m-gibula) wrote :

Hi,
yes, from what I've tested, it detects Ec2 datasource correctly.

Revision history for this message
Server Team CI bot (server-team-bot) wrote :

This bug is fixed with commit 7d5d34f3 to cloud-init on branch master.
To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=7d5d34f3

Changed in cloud-init:
status: Triaged → Fix Committed
Revision history for this message
Chad Smith (chad.smith) wrote : Fixed in cloud-init version 19.2-57.

This bug is believed to be fixed in cloud-init in version 19.2-57. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in cloud-init:
status: Fix Committed → Fix Released
Revision history for this message
James Falcon (falcojr) wrote :

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/2925

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.