Glance installation fails if password contains '@' symbol

same problem here when tried to install devstack and using a password with '@'.

So, also when password or login have '/' symbol glance throw error.

Seems like this hit interpolation on ConfigParser. Are you able to escape using `%%`?

One possible solution is to set:

config = ConfigParser(strict=False, interpolation=None)

correction '%@' as example to escapte @.

From https://git.launchpad.net/glance/tree/glance/db/sqlalchemy/alembic_migrations/__init__.py master bracnh line 37.

config.set_main_option('sqlalchemy.url', str(engine.url))

This indeed an expected behaviour, quoting to alembic documentation (http://alembic.zzzcomputing.com/en/latest/api/config.html).

 set_main_option(name, value)

    Set an option programmatically within the ‘main’ section.

    This overrides whatever was in the .ini file.
    Parameters:

        name – name of the value
        value¶ – the value. Note that this value is passed to ConfigParser.set, which supports variable interpolation using pyformat (e.g. %(some_value)s). A raw percent sign not part of an interpolation symbol must therefore be escaped, e.g. %%. The given value may refer to another value already in the file using the interpolation format.

Fix proposed to branch: master
Review: https://review.openstack.org/498427

Fix proposed to branch: master
Review: https://review.openstack.org/498730

Change abandoned by Gleb Zimin (<email address hidden>) on branch: master
Review: https://review.openstack.org/498730

There's an unanswered question here ... how did

> "Test@321" in local.conf file.

end up being escaped to %40

> CRITICAL glance [-] Unhandled error: ValueError: invalid interpolation syntax
> in 'mysql+pymysql://root:Test%40321@127.0.0.1/glance?charset=utf8'

? afaict we don't do that anywhere

I've actually convinced myself this really is glance's fault. I have a suggested change incoming

So, we can delete devstack from affects.

Unassigning, patches have been abandoned.

Current patch: https://review.openstack.org/#/c/499410/

Reviewed: https://review.openstack.org/499410
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=f601cfccf1d8e2e314a270943d91e8aa1932f2a4
Submitter: Zuul
Branch: master

commit f601cfccf1d8e2e314a270943d91e8aa1932f2a4
Author: Ian Wienand <email address hidden>
Date: Thu Aug 31 11:06:28 2017 +1000

    Support RFC1738 quoted chars in passwords

    In the bug, a user tried setting a devstack password with a "@" in it.

    As it turns out, sqlalchmey turns the connection-string into a
    sqlalchemy.engine.url.URL object [1] which returns a RFC1738 quoted
    string.

    However, alembic's set_main_option [2] uses python
    string-interpolation which interprets '%' characters. This means you
    end up with an interpolation traceback when using any quoted character
    (':@/') in a user/password (more likely password).

    Avoid this by ensuring the URL is safe for python interpolation in
    set_main_option by replacing '%' -> '%%'.

    I convinced myself this is safe because sqlalchemy correctly parses
    the quoted and unquoted versions just the same

    ---
     >>> str(sqlalchemy.engine.url.make_url('mysql+pymysql://foo:crazy:@/pw@/moo'))
     'mysql+pymysql://foo:crazy%3A%40%2Fpw@/moo'
     >>> str(sqlalchemy.engine.url.make_url('mysql+pymysql://foo:crazy%3A%40%2Fpw@/moo'))
     'mysql+pymysql://foo:crazy%3A%40%2Fpw@/moo'
    ---

    A test is added

    [1] https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/url.py
    [2] http://alembic.zzzcomputing.com/en/latest/api/config.html#alembic.config.Config.set_main_option

    Change-Id: I3ef7e3e539e35ce040573f2044ab6eb3c990200a
    Closes-Bug: #1695299

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/592210

Reviewed: https://review.openstack.org/592210
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=626018b991080c0706df8481e37addefd10c58fa
Submitter: Zuul
Branch: stable/rocky

commit 626018b991080c0706df8481e37addefd10c58fa
Author: Ian Wienand <email address hidden>
Date: Thu Aug 31 11:06:28 2017 +1000

    Support RFC1738 quoted chars in passwords

    In the bug, a user tried setting a devstack password with a "@" in it.

    As it turns out, sqlalchmey turns the connection-string into a
    sqlalchemy.engine.url.URL object [1] which returns a RFC1738 quoted
    string.

    However, alembic's set_main_option [2] uses python
    string-interpolation which interprets '%' characters. This means you
    end up with an interpolation traceback when using any quoted character
    (':@/') in a user/password (more likely password).

    Avoid this by ensuring the URL is safe for python interpolation in
    set_main_option by replacing '%' -> '%%'.

    I convinced myself this is safe because sqlalchemy correctly parses
    the quoted and unquoted versions just the same

    ---
     >>> str(sqlalchemy.engine.url.make_url('mysql+pymysql://foo:crazy:@/pw@/moo'))
     'mysql+pymysql://foo:crazy%3A%40%2Fpw@/moo'
     >>> str(sqlalchemy.engine.url.make_url('mysql+pymysql://foo:crazy%3A%40%2Fpw@/moo'))
     'mysql+pymysql://foo:crazy%3A%40%2Fpw@/moo'
    ---

    A test is added

    [1] https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/engine/url.py
    [2] http://alembic.zzzcomputing.com/en/latest/api/config.html#alembic.config.Config.set_main_option

    Change-Id: I3ef7e3e539e35ce040573f2044ab6eb3c990200a
    Closes-Bug: #1695299
    (cherry picked from commit f601cfccf1d8e2e314a270943d91e8aa1932f2a4)

This issue was fixed in the openstack/glance 17.0.0.0rc2 release candidate.

This issue was fixed in the openstack/glance 18.0.0.0b1 development milestone.