PBR

sphinx 1.6.1 introduces an attribute error

Bug #1691129 reported by Doug Hellmann
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
PBR
Fix Released
Undecided
Julien Danjou

Bug Description

2017-05-16 14:22:14.432281 | Traceback (most recent call last):
2017-05-16 14:22:14.432344 | File "setup.py", line 22, in <module>
2017-05-16 14:22:14.432356 | pbr=True)
2017-05-16 14:22:14.432376 | File "/usr/lib/python3.5/distutils/core.py", line 148, in setup
2017-05-16 14:22:14.432387 | dist.run_commands()
2017-05-16 14:22:14.432421 | File "/usr/lib/python3.5/distutils/dist.py", line 955, in run_commands
2017-05-16 14:22:14.432438 | self.run_command(cmd)
2017-05-16 14:22:14.432459 | File "/usr/lib/python3.5/distutils/dist.py", line 974, in run_command
2017-05-16 14:22:14.432469 | cmd_obj.run()
2017-05-16 14:22:14.432507 | File "/home/jenkins/workspace/gate-releases-docs-ubuntu-xenial/.tox/venv/lib/python3.5/site-packages/pbr/builddoc.py", line 189, in run
2017-05-16 14:22:14.432527 | self._sphinx_run()
2017-05-16 14:22:14.432606 | File "/home/jenkins/workspace/gate-releases-docs-ubuntu-xenial/.tox/venv/lib/python3.5/site-packages/pbr/builddoc.py", line 142, in _sphinx_run
2017-05-16 14:22:14.432645 | self.builder_target_dir, self.doctree_dir,
2017-05-16 14:22:14.432667 | File "/usr/lib/python3.5/distutils/cmd.py", line 103, in __getattr__
2017-05-16 14:22:14.432680 | raise AttributeError(attr)
2017-05-16 14:22:14.432693 | AttributeError: builder_target_dir
2017-05-16 14:22:14.473650 | ERROR: InvocationError: '/home/jenkins/workspace/gate-releases-docs-ubuntu-xenial/.tox/venv/bin/python setup.py build_sphinx'

http://logs.openstack.org/73/465073/3/check/gate-releases-docs-ubuntu-xenial/d93bff1/console.html#_2017-05-16_14_22_14_432693

Revision history for this message
Lance Bragstad (lbragstad) wrote :

This started cropping up in the keystone-specs gate. I was able to recreate with version 1.6.1 and version 1.5.6 appears to fix it for me locally.

Julien Danjou (jdanjou)
Changed in pbr:
assignee: nobody → Julien Danjou (jdanjou)
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

I have the same issue with running tox -edocs against a change to the tripleo-docs repo

OpenStack Infra (hudson-openstack)
Changed in pbr:
status: New → In Progress
Revision history for this message
Adrian Vladu (avladu) wrote :

Same issue with cloudbase-init repo

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pbr (master)

Reviewed: https://review.openstack.org/465489
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=c02406601a7d7c453c77318ff5b5af6d760e80ae
Submitter: Jenkins
Branch: master

commit c02406601a7d7c453c77318ff5b5af6d760e80ae
Author: Julien Danjou <email address hidden>
Date: Wed May 17 12:05:59 2017 +0200

    builddoc: uses the new Sphinx 1.6 code for multiple builder

    As noted by stephenfin, Sphinx 1.6 provides its own code to build doc with
    multiple builders. The one provided by pbr so far for Sphinx < 1.6 is not even
    compatible with 1.6. This patch fixes that by running the native Sphinx code
    for Sphinx > 1.6 and falling back to the old code for older Sphinx versions.

    Closes-Bug: #1691129
    Change-Id: I5224235b1056a248b246c54e2d99eea94d53c4eb

Changed in pbr:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack-dev/pbr 3.0.1

This issue was fixed in the openstack-dev/pbr 3.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to pbr (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/481620

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to pbr (master)

Reviewed: https://review.openstack.org/481620
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=c59fad9c883c85af02b663f5c25b297f54f992d1
Submitter: Jenkins
Branch: master

commit c59fad9c883c85af02b663f5c25b297f54f992d1
Author: Stephen Finucane <email address hidden>
Date: Fri Jul 7 11:02:36 2017 +0100

    builddoc: Use '[sphinx_build] builders' with Sphinx < 1.6

    In 'c024066', we resolved an issue with pbr and Sphinx 1.6+ and
    implicitly started using Sphinx 1.6's support for declaring multiple
    builders as part of the setuptools plugin. However, in doing so, we
    neglected to provide a migration path for folks who were using the older
    option. This meant folks using the '[sphinx_build] builders' option
    would see a breaking change in behavior when upgrading to a pbr release
    including the above change. Resolve this issue now.

    Note that we want to deprecate support for this option in the future,
    but doing so is not a backportable change and will be done separately.

    Change-Id: Ic2fe67f932ba26b665110ae66431a5359fc50016
    Closes-Bug: #1702872
    Related-Bug: #1691129

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.