Ubuntu
btrfs-progs package

fix empty subvolume send and receive

Bug #1689621 reported by Christian Brauner on 2017-05-09

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	btrfs-progs (Ubuntu)	Fix Released	Undecided	Stéphane Graber
	Zesty	Fix Released	Undecided	Unassigned

Bug Description

The original report can be found here:
https://bugzilla.kernel.org/show_bug.cgi?id=195597

== Rationale ==
The previous btrfs bugfix while it fixed the issue we found back then, also introduced a regression for some other users. This issue was reported upstream and fixed by Christian (author of the original patch). This regression fix has been merged by btrfs upstream and should be included in Ubuntu.

== Testcase ==
The reproducer for this issue is:

truncate -s 10GB pool.btrfs
mkfs.btrfs pool.btrfs
mount -t btrfs pool.btrfs /mnt
btrfs subvolume create /mnt/a
btrfs subvolume snapshot /mnt/a /mnt/snap-a
btrfs send /mnt/snap-a | btrfs receive /mnt/a

should incorrectly fail with

ERROR: empty stream is not considered valid

whereas it should actually succeed.

== Regression potential ==
The previous fix for this issue introduced a regression, so it's clearly not impossible that this may introduce yet another one.

Both this and the previous patch were reviewed and merged upstream, including a testcase, so nothing that we know about or that upstream knows about should regress.

btrfs upstream (https://bugzilla.kernel.org/attachment.cgi?id=256157

See original description

Tags:

Revision history for this message

Christian Brauner (cbrauner) wrote on 2017-05-09:

0001-btrfs-progs-send-fail-on-first-ENODATA-only.patch Edit (1.6 KiB, text/plain)

Changed in btrfs (Ubuntu):
assignee:	nobody → Stéphane Graber (stgraber)

Stéphane Graber (stgraber) on 2017-05-09

affects:

btrfs (Ubuntu) → btrfs-progs (Ubuntu)

Revision history for this message

Stéphane Graber (stgraber) wrote on 2017-05-09:

Uploaded to artful and zesty.

description:	updated
Changed in btrfs-progs (Ubuntu Zesty):
status:	New → In Progress
Changed in btrfs-progs (Ubuntu):
status:	New → Fix Committed

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2017-05-09:

The attachment "0001-btrfs-progs-send-fail-on-first-ENODATA-only.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags:

added: patch

Revision history for this message

Launchpad Janitor (janitor) wrote on 2017-05-09:

This bug was fixed in the package btrfs-progs - 4.9.1-1ubuntu2

---------------
btrfs-progs (4.9.1-1ubuntu2) artful; urgency=medium

* Cherry-pick follow-up fix from upstream (LP: #1689621):
- 0003-btrfs-progs-send-fail-on-first-ENODATA-only.patch

-- Stéphane Graber <email address hidden> Tue, 09 May 2017 15:18:10 -0400

Changed in btrfs-progs (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2017-05-12: Please test proposed package

Hello Christian, or anyone else affected,

Accepted btrfs-progs into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/btrfs-progs/4.9.1-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in btrfs-progs (Ubuntu Zesty):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Christian Brauner (cbrauner) on 2017-05-12

tags:

added: verification-done
removed: verification-needed

Revision history for this message

pfaelzerchen (pfaelzerchen) wrote on 2017-05-18:

Thanks for the fix. I tested btrfs-progs 4.9.1-1ubuntu1.1 today on zesty. The errors were gone. Also btrbk (which uses the send/receive for backup) works fine again.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2017-05-24:

This bug was fixed in the package btrfs-progs - 4.9.1-1ubuntu1.1

---------------
btrfs-progs (4.9.1-1ubuntu1.1) zesty; urgency=medium

* Cherry-pick follow-up fix from upstream (LP: #1689621):
- 0003-btrfs-progs-send-fail-on-first-ENODATA-only.patch

-- Stéphane Graber <email address hidden> Tue, 09 May 2017 15:18:10 -0400

Changed in btrfs-progs (Ubuntu Zesty):
status:	Fix Committed → Fix Released

Revision history for this message

Chris J Arges (arges) wrote on 2017-05-24: Update Released

The verification of the Stable Release Update for btrfs-progs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.