Sahara

[UI] Cinder options unavailable for node group if volume v1 unavailable

Bug #1678534 reported by Jeremy Freudberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Undecided
Jeremy Freudberg

Bug Description

When creating node group template, dashboard checks is Cinder is available by seeing if "volume" service is enabled. We need to check for "volumev2" and "volumev3" also otherwise the option is unavailable.

http://git.openstack.org/cgit/openstack/sahara-dashboard/tree/sahara_dashboard/content/data_processing/clusters/nodegroup_templates/workflows/create.py#n48

Jeremy Freudberg (jfreud)
Changed in sahara:
assignee: nobody → Jeremy Freudberg (jfreud)
Revision history for this message
Jeremy Freudberg (jfreud) wrote :

Ok, so obviously we need to check for volumev2 in dashboard.

But, volumev3 maybe not since we are not even supporting it in Sahara itself yet: https://github.com/openstack/sahara/blob/master/sahara/utils/openstack/cinder.py#L58

Revision history for this message
Luigi Toscano (ltoscano) wrote :

Should we track a bug to evaluate the support for volumev3? I think I heard that volumev3 is basically v2+microversioning; if it is true, it should not be difficult to support it (also because v2 is deprecated).

Revision history for this message
Jeremy Freudberg (jfreud) wrote :

Luigi, agree. We can track Cinder API v3 support here https://bugs.launchpad.net/sahara/+bug/1680157

As I mentioned over there, v3.0 is functionally equivalent to v2!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/484809

Changed in sahara:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-dashboard (master)

Reviewed: https://review.openstack.org/484809
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=ed4cb76aa2e5b00f1671d9dbcbc5a8dda589365a
Submitter: Jenkins
Branch: master

commit ed4cb76aa2e5b00f1671d9dbcbc5a8dda589365a
Author: Jeremy Freudberg <email address hidden>
Date: Tue Jul 18 10:02:27 2017 -0400

    Check for volumev2 and volumev3 too

    If we don't check for all three possible Cinder service types, we may
    end up with Cinder options hidden even when the service is in fact
    available.

    Change-Id: Ic844dc7d3b138b0918f9c436f0550fe0a4379bae
    Closes-Bug: #1678534

Changed in sahara:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-dashboard (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/489595

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/sahara-dashboard 7.0.0.0rc1

This issue was fixed in the openstack/sahara-dashboard 7.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-dashboard (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/493570

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-dashboard (stable/newton)

Reviewed: https://review.openstack.org/493570
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=fed6bed0409f7c52426391b29ea73f3355bf190d
Submitter: Jenkins
Branch: stable/newton

commit fed6bed0409f7c52426391b29ea73f3355bf190d
Author: Jeremy Freudberg <email address hidden>
Date: Tue Jul 18 10:02:27 2017 -0400

    Check for volumev2 and volumev3 too

    If we don't check for all three possible Cinder service types, we may
    end up with Cinder options hidden even when the service is in fact
    available.

    Change-Id: Ic844dc7d3b138b0918f9c436f0550fe0a4379bae
    Closes-Bug: #1678534
    (cherry picked from commit ed4cb76aa2e5b00f1671d9dbcbc5a8dda589365a)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-dashboard (stable/ocata)

Reviewed: https://review.openstack.org/489595
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=8e8b93080da9f1341c4bd950f740f57356fce9bf
Submitter: Jenkins
Branch: stable/ocata

commit 8e8b93080da9f1341c4bd950f740f57356fce9bf
Author: Jeremy Freudberg <email address hidden>
Date: Tue Jul 18 10:02:27 2017 -0400

    Check for volumev2 and volumev3 too

    If we don't check for all three possible Cinder service types, we may
    end up with Cinder options hidden even when the service is in fact
    available.

    Change-Id: Ic844dc7d3b138b0918f9c436f0550fe0a4379bae
    Closes-Bug: #1678534
    (cherry picked from commit ed4cb76aa2e5b00f1671d9dbcbc5a8dda589365a)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/sahara-dashboard 5.0.2

This issue was fixed in the openstack/sahara-dashboard 5.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/sahara-dashboard 6.0.2

This issue was fixed in the openstack/sahara-dashboard 6.0.2 release.

Luigi Toscano (ltoscano)
tags: added: dashboard
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.