NVMe disks are not added in the DISK category by the udev parser
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox Provider - Resource |
Fix Released
|
High
|
Sylvain Pineau | ||
Bug Description
Last year, we fixed an issue regarding devices with NVMe drives where the disk/detect job would always fail. [1]
Now, I discovered that on newer devices, although this test pass, the NVMe drives are actually not parsed properly by our udev parser, which means they don't end up in the DISK category. Because of this, the template jobs that depend on this DISK category are not run, and therefore some tests are not generated nor run, such as
- disk/stats_.*
- disk/read_
- disk/smart_.*
- disk/storage_
The three devices tested that feature this issue are 201611-25208, 201606-22339 and 201606-22472.
Below is the output of `udevadm info --export-db` for each of them.
[1] https:/
Related branches
- Maciej Kisielewski: Approve
- Jeff Lane : Approve
-
Diff: 6350 lines (+6257/-5)3 files modifiedcheckbox_support/parsers/tests/test_udevadm.py (+15/-0)
checkbox_support/parsers/tests/udevadm_data/TOSHIBA_NVME.txt (+6216/-0)
checkbox_support/parsers/udevadm.py (+26/-5)
| Pierre Equoy (pieq) wrote | #1 |
| Maciej Kisielewski (kissiel) wrote | #3 |
| Changed in plainbox-provider-resource: | |
| status: | New → Confirmed |
| Changed in plainbox-provider-resource: | |
| assignee: | nobody → Sylvain Pineau (sylvain-pineau) |
| status: | Confirmed → In Progress |
| importance: | Undecided → High |
| Changed in plainbox-provider-resource: | |
| status: | In Progress → Fix Committed |
| Changed in plainbox-provider-resource: | |
| milestone: | none → 0.32.0 |
| Changed in plainbox-provider-resource: | |
| status: | Fix Committed → Fix Released |
Indeed the disk tests did not run on my PC with nvme.
attaching udevadm output