LIB_ID UTF-8 strings are being decoded via the current locale

Bug #1675942 reported by Chris Pavlina
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Medium
Chris Pavlina

Bug Description

The strings returned by the methods of LIB_ID are all of type "UTF8". In a great many locations, these are being implicitly cast to wxString instead of using FROM_UTF8. This results in attempting to convert them via the current locale's encoding instead of UTF-8.

I assume this hasn't been noticed because 1) most users use UTF-8 locales, 2) tests only run in debug mode, 3) the libraries have had mostly ASCII characters for a while.

Planned fix is to find all uses of LIB_ID methods returning UTF8 and check that they are being converted correctly.

Revision history for this message
Chris Pavlina (pavlina-chris) wrote :

This bug was the real cause of https://bugs.launchpad.net/kicad/+bug/1675878.

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 4011ed4e31c77d9ee885cc9262d0f0f89cad4fc6
https://git.launchpad.net/kicad/patch/?id=4011ed4e31c77d9ee885cc9262d0f0f89cad4fc6

Changed in kicad:
status: In Progress → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.