Ubuntu
walinuxagent package

duplicate logrotate files/entries

Bug #1673152 reported by Andrew Baumann
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
walinuxagent (Ubuntu)
Fix Released
Undecided
Łukasz Zemczak
Trusty
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

[ Impact ]

We always keep all the supported series in sync, we want to SRU this change as well. In certain cases, when upgrading from a very old walinuxagent, the logrotate files are duplicate - which is never a good thing.

[ Test Case ]

Easiest way would be to install an ancient trusty walinuxagent package and then upgrade to the latest proposed one and check if the old logrotate configuration file is still present.

 * Download walinuxagent 2.0.8-0ubuntu1~14.04.0
 * Install the package through dpkg (possibly dpkg --force-all -i since otherwise the old version will not install)
 * Check if /etc/logrotate.d/waagent is present
 * Upgrade walinuxagent to 2.2.6
 * Make sure that /etc/logrotate.d/waagent is gone and /etc/logrotate.d/waagent.logrotate is present

[ Regression Potential ]

The logrotate configuration can be lost or invalid - but if that would happen then the bug will fail verification.

Original description:

I am getting the following errors from cron after upgrading my VM to walinuxagent 2.2.2-0ubuntu0~14.04.1 (the previous version was 2.0.8-0ubuntu1~14.04.0).
    /etc/cron.daily/logrotate:
    error: waagent.logrotate:1 duplicate log entry for /var/log/waagent.log

Indeed, there are two duplicate logrotate files that both appear to belong to the walinuxagent package:
    $ dpkg -S /etc/logrotate.d/waagent*
    walinuxagent: /etc/logrotate.d/waagent
    walinuxagent: /etc/logrotate.d/waagent.logrotate
    $ cmp /etc/logrotate.d/waagent*
    $ cat /etc/logrotate.d/waagent
    /var/log/waagent.log {
        compress
        monthly
        rotate 6
        notifempty
        missingok
    }

I'm on 14.04 LTS:
    $ lsb_release -rd
    Description: Ubuntu 14.04.5 LTS
    Release: 14.04

See original description
Andrew Baumann (0xab)
description: updated
Łukasz Zemczak (sil2100)
Changed in walinuxagent (Ubuntu):
assignee: nobody → Łukasz Zemczak (sil2100)
status: New → Confirmed
Łukasz Zemczak (sil2100)
Changed in walinuxagent (Ubuntu):
status: Confirmed → In Progress
Łukasz Zemczak (sil2100)
description: updated
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package walinuxagent - 2.2.6-0ubuntu1

---------------
walinuxagent (2.2.6-0ubuntu1) zesty; urgency=medium

  * New upstream release (LP: #1661750).
  * debian/control:
    - Change the maintainer to Ubuntu Developers (LP: #1657528).
    - Add the dependency of isc-dhcp-client as our maintainer scripts assume
      it's installed.
    - Add trailing commas to dependencies, add whitespaces.
  * Rename ephemeral-disk-warning.sh to ephemeral-disk-warning (lintian error).
  * debian/docs:
    - Remove LICENSE.txt as it's redundant.
  * debian/postinst:
    - Stop checking for update-initramfs existence using the absolute path, use
      the 'command' command instead to make lintian happy.
  * Remove debian/patches/disable-auto-update.patch:
    - We now ship with auto-updates enabled (LP: #1650522).
  * debian/maintscript:
    - Add a maintscript to rename the old logrotate file on upgrade from an
      ancient version of walinuxagent (LP: #1673152).

 -- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 15 Mar 2017 10:19:34 +0100

Changed in walinuxagent (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Proposed package upload rejected

An upload of walinuxagent to yakkety-proposed has been rejected from the upload queue for the following reason: "to be reuploaded w/ bug ref for isc-dhcp-client dep".

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Andrew, or anyone else affected,

Accepted walinuxagent into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.2.6-0ubuntu1~16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in walinuxagent (Ubuntu Yakkety):
status: New → Fix Committed
Changed in walinuxagent (Ubuntu Xenial):
status: New → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Andrew, or anyone else affected,

Accepted walinuxagent into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.2.6-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Andrew, or anyone else affected,

Accepted walinuxagent into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.2.6-0ubuntu1~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in walinuxagent (Ubuntu Trusty):
status: New → Fix Committed
Revision history for this message
Andrew Baumann (0xab) wrote :

Thanks for the quick turnaround. I installed the new package (2.2.6-0ubuntu1~14.04.1), and confirmed that /etc/logrotate.d/waagent was removed.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thanks Andrew!

I also just tested all 3 packages on a single chroot to see if the logrotate file was successfully removed. I performed the following tests: force-install walinuxagent 2.0.8-0ubuntu1~14.04.0 from trusty, download new package for series x from x-proposed, install walinuxagent version X, check if there are duplicate logrotate files, repeat for next series. I did this for 2.2.6-0ubuntu1~16.10.1, 2.2.6-0ubuntu1~16.04.1 and 2.2.6-0ubuntu1~14.04.1.

I didn't want to re-setup different chroots for different series as it doesn't really affect the test being made (as we need to upgrade from a trusty version of the package anyway).

tags: added: verification-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package walinuxagent - 2.2.6-0ubuntu1~16.10.1

---------------
walinuxagent (2.2.6-0ubuntu1~16.10.1) yakkety; urgency=medium

  * Backport zesty version to yakkety.
  * New upstream release (LP: #1661750).
  * debian/control:
    - Change the maintainer to Ubuntu Developers (LP: #1657528).
    - Add the dependency of isc-dhcp-client as our maintainer scripts assume
      it's installed (LP: #1673862).
    - Add trailing commas to dependencies, add whitespaces.
  * Rename ephemeral-disk-warning.sh to ephemeral-disk-warning (lintian error).
  * debian/docs:
    - Remove LICENSE.txt as it's redundant.
  * debian/postinst:
    - Stop checking for update-initramfs existence using the absolute path, use
      the 'command' command instead to make lintian happy.
  * Remove debian/patches/disable-auto-update.patch:
    - We now ship with auto-updates enabled (LP: #1650522).
  * debian/maintscript:
    - Add a maintscript to rename the old logrotate file on upgrade from an
      ancient version of walinuxagent (LP: #1673152).

 -- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 15 Mar 2017 10:19:34 +0100

Changed in walinuxagent (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for walinuxagent has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package walinuxagent - 2.2.6-0ubuntu1~16.04.1

---------------
walinuxagent (2.2.6-0ubuntu1~16.04.1) xenial; urgency=medium

  * Backport zesty version to xenial.
  * New upstream release (LP: #1661750)
  * debian/control:
    - Change the maintainer to Ubuntu Developers (LP: #1657528)
    - Add the dependency of isc-dhcp-client as our maintainer scripts assume
      it's installed (LP: #1673862).
    - Add trailing commas to dependencies, add whitespaces.
  * Rename ephemeral-disk-warning.sh to ephemeral-disk-warning (lintian error).
  * debian/docs:
    - Remove LICENSE.txt as it's redundant.
  * debian/postinst:
    - Stop checking for update-initramfs existence using the absolute path, use
      the 'command' command instead to make lintian happy.
  * Remove debian/patches/disable-auto-update.patch:
    - We now ship with auto-updates enabled (LP: #1650522).
  * debian/maintscript:
    - Add a maintscript to rename the old logrotate file on upgrade from an
      ancient version of walinuxagent (LP: #1673152).

 -- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 15 Mar 2017 10:19:34 +0100

Changed in walinuxagent (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package walinuxagent - 2.2.6-0ubuntu1~14.04.1

---------------
walinuxagent (2.2.6-0ubuntu1~14.04.1) trusty; urgency=medium

  * Backport zesty version to trusty.
  * New upstream release (LP: #1661750).
  * debian/control:
    - Change the maintainer to Ubuntu Developers (LP: #1657528).
    - Add the dependency of isc-dhcp-client as our maintainer scripts assume
      it's installed (LP: #1673862).
    - Add trailing commas to dependencies, add whitespaces.
  * Rename ephemeral-disk-warning.sh to ephemeral-disk-warning (lintian error).
  * debian/docs:
    - Remove LICENSE.txt as it's redundant.
  * debian/postinst:
    - Stop checking for update-initramfs existence using the absolute path, use
      the 'command' command instead to make lintian happy.
  * Remove debian/patches/disable-auto-update.patch:
    - We now ship with auto-updates enabled (LP: #1650522).
  * debian/maintscript:
    - Add a maintscript to rename the old logrotate file on upgrade from an
      ancient version of walinuxagent (LP: #1673152).

 -- Łukasz 'sil2100' Zemczak <email address hidden> Wed, 15 Mar 2017 10:19:34 +0100

Changed in walinuxagent (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.