Fuel for OpenStack

[10.0 swarm] Compute role has priority under cinder role during applying of openstack config

Bug #1671521 reported by Sergey Novikov on 2017-03-09

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Status tracked in Pike
Newton	Fix Released	High	Igor Gajsin	Fuel for OpenStack 12.0
Pike	Fix Committed	High	Igor Gajsin	Fuel for OpenStack 10.1

Bug Description

Detailed bug description:

The issue was found by https://product-ci.infra.mirantis.net/job/10.0.system_test.ubuntu.services_reconfiguration_thread_1/204/testReport/(root)/apply_config_for_node_with_multiple_role/apply_config_for_node_with_multiple_role/

Steps to reproduce:
1. deploy simple cluster (1 controller, 1 compute,1 compute+cinder)
2. Upload config of reconfiguration for compute role [0]
3. Upload the same config from step #2 (but with other values) for cinder role [1]
4. Apply config for node with role "compute+cinder"

Expected results: Config for cinder role was applied
Actual result: Config for compute role was applied

I haven't found any information about priority of roles or config ids in the following specs [2,3]. but historically we assume that the latest uploaded config for the same node should be applied.

[0] - http://paste.openstack.org/show/602080/
[1] - http://paste.openstack.org/show/602081/
[2] - http://specs.openstack.org/openstack/fuel-specs/specs/9.0/puppet-resource-override.html
[3] - https://specs.openstack.org/openstack/fuel-specs/specs/8.0/openstack-config-change.html

Tags:

Revision history for this message

Sergey Novikov (snovikov) wrote on 2017-03-10:

diagnostic snapshot is available by https://drive.google.com/file/d/0B29AewS4dQJoUERTUURrV2MxcG8/view?usp=sharing

Oleksiy Molchanov (omolchanov) on 2017-03-14

Changed in fuel:
status:	New → Incomplete
status:	Incomplete → Confirmed
tags:	added: area-python

Igor Gajsin (igajsin) on 2017-03-15

Changed in fuel:
assignee:	Fuel Sustaining (fuel-sustaining-team) → Igor Gajsin (igajsin)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-17: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/447059

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-28: Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/450779

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-28: Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/447059
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=8e12d76f86eccac41469f2f100b8fdab0bec0d6b
Submitter: Jenkins
Branch: master

commit 8e12d76f86eccac41469f2f100b8fdab0bec0d6b
Author: Igor Gajsin <email address hidden>
Date: Fri Mar 17 19:23:27 2017 +0300

Reorder configs_query by time

    There is the possibility to change OpenStack config after deployment.
    Changes could be applied per role. And in the case of multiple roles
    on a node, many changes could pretend to be applied. I.e. if we have
    a config for the role 'compute', a config for the role 'cinder' and
    a node with role 'cinder+compute' we have to choose one of them.

    Previous decision was 'sort it in the lexicographical order', so it
    applies 'cinder' then --- 'compute'. It is contra intuitive. The best
    option is applying to a node the last related config, to new config
    overlaps old ones.

Change-Id: I7db388ca3baeb351adc9fdb70c55b0be50fafe48
Closes-bug: #1671521

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-28: Fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/450779
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=8a422879594d9f8492ab6b9222b6842bfb9c2b70
Submitter: Jenkins
Branch: stable/newton

commit 8a422879594d9f8492ab6b9222b6842bfb9c2b70
Author: Igor Gajsin <email address hidden>
Date: Fri Mar 17 19:23:27 2017 +0300

Reorder configs_query by time

Change-Id: I7db388ca3baeb351adc9fdb70c55b0be50fafe48
Closes-bug: #1671521

tags:

added: in-stable-newton

Revision history for this message

Sergey Novikov (snovikov) wrote on 2017-04-07:

verified by https://product-ci.infra.mirantis.net/job/10.0.system_test.ubuntu.services_reconfiguration_thread_1/235/testReport/(root)/apply_config_for_node_with_multiple_role/apply_config_for_node_with_multiple_role/