lsdasd: continue outside a loop statement

please reverse mirror to bugzilla

------- Comment From <email address hidden> 2017-03-07 08:53 EDT-------
lsdasd: Replace continue with return

Patch attached fixing the problem.
Also fixed upstream -> package: s390-tools

This message is for mirror checking !

------- Comment From <email address hidden> 2017-03-22 11:31 EDT-------
@Paelzer can you please verify that this fix is now included within 17.04 and provide your feedback. Many thanks

It is not, so far I can only confirm the IBM release of 1.37.1 which seems to fix it.
One needs to pull that into Zesty.

@JFH - this is your chance to package something :-)
Or wait for xnox if that is better.
If you need me to emergency fix for deadlines let me know.

------- Comment From <email address hidden> 2017-03-22 12:18 EDT-------
@paelzer, it should also be available within 1.37.0 . Xnox picked the upstream fixed, and not upgrading the package level.

Hi Heinz-Werner,
it is not in https://launchpad.net/ubuntu/+source/s390-tools/1.37.0-0ubuntu2
Nor do I see it in http://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html

And on zesty as of now, still broken.

The last change I could find and you might mean is this of last Thursday:
  chzdev/qeth: set bridge_role after the device is online to avoid a
  race condition when setting qeth attributes on boot. LP: #1618463.

------- Comment From <email address hidden> 2017-03-22 12:54 EDT-------
(In reply to comment #13)
> Hi Heinz-Werner,
> it is not in https://launchpad.net/ubuntu/+source/s390-tools/1.37.0-0ubuntu2
> Nor do I see it in
> http://people.canonical.com/~ubuntu-archive/proposed-migration/
> update_excuses.html
>
> And on zesty as of now, still broken.
>
> The last change I could find and you might mean is this of last Thursday:
> chzdev/qeth: set bridge_role after the device is online to avoid a
> race condition when setting qeth attributes on boot. LP: #1618463.

Hi paelzer,

the fix is only included since 1.37.1 which can be found here:
https://www.ibm.com/developerworks/linux/linux390/s390-tools-1.37.1.html

There was a different LP for this particular release where Xnox already
cherry-picked a few fixes from. I can't find the exact number for the LP
on launchpad.net though. Apparently it is 1671497, but I can't seem to
find it (It's only mentioned in our bugzilla).

Best regards,
Jan

On Wed, Mar 22, 2017 at 5:59 PM, bugproxy <email address hidden> wrote:

> the fix is only included since 1.37.1 which can be found here:
> https://www.ibm.com/developerworks/linux/linux390/s390-tools-1.37.1.html
>

Hi Jan,
Yep, this is just what I found as reported above.

> There was a different LP for this particular release where Xnox already
> cherry-picked a few fixes from
>

Yes, again these are the changes I already referred in my post before that
went into https://launchpad.net/ubuntu/+source/s390-tools/1.37.0-0ubuntu2

Fortunately JFH knew that xnox is already working on that, so I'm not going
to interrupt his work - but that means you'll likely have to wait until
next week to get that going.

This bug was fixed in the package s390-tools - 1.37.0-0ubuntu3

---------------
s390-tools (1.37.0-0ubuntu3) zesty; urgency=medium

  * Cherrypick v1.37.1 point release bug fixes LP: #1671497, LP: #1669785
    - dbginfo.sh: Add Docker debug data
    - lsdasd: Replace continue with return
    - lscss: Allow to specify devices from subchannel set 3
    - mon_fsstatd: Only use physical filesystems
    - mon_fsstatd: Fix double free in error path
    - mon_procd: Fix segmentation fault
    - mon_procd: Bump buffer size to 4096

 -- Dimitri John Ledkov <email address hidden> Mon, 27 Mar 2017 16:10:35 +0100

------- Comment From <email address hidden> 2017-04-03 06:48 EDT-------
IBM Bugzilla Status -> Closed. Fixed with s390tools 1.37.1 or 1.37.0 cherrypicked