[tags] Unable to deploy cluster with new role clonned from controller role

root@node-1:~# mysql --protocol=SOCKET
ERROR 2047 (HY000): Wrong or unknown protocol

root@node-1:~# dpkg -l | grep mysql
ii libdbd-mysql-perl 4.033-1ubuntu0.1 amd64 Perl5 database interface to the MySQL database
ii libmysqlclient20:amd64 5.7.17-0ubuntu0.16.04.1 amd64 MySQL database client library
ii mysql-common 5.7.17-0ubuntu0.16.04.1 all MySQL database common files, e.g. /etc/mysql/my.cnf
ii mysql-wsrep-client-5.6 5.6.35-0~u16.04+mos1 amd64 MySQL database client binaries
ii mysql-wsrep-common-5.6 5.6.35-0~u16.04+mos1 all MySQL database common files, e.g. /etc/mysql/conf.d/my-5.6.cnf
ii mysql-wsrep-libmysqlclient18:amd64 5.6.35-0~u16.04+mos1 amd64 MySQL database client library
ii mysql-wsrep-server-5.6 5.6.35-0~u16.04+mos1 amd64 MySQL database wsrep server binaries and system database setup

Seems like some issue with host settings in .my.cnf. Please, set it to localhost.

After further investigation we found out that in this env haproxy is not deployed, because there is no haproxy_vip.

<% # If we have no VIPs with 'haproxy' namespace, then we're using external LB
if @vips.select{|key, hash| hash['namespace'] == 'haproxy' }.length == 0
 globals.store "external_lb", true
else
 globals.store "external_lb", false
end -%>

https://github.com/openstack/fuel-qa/blob/stable/newton/fuelweb_test/tests/tests_lcm/test_tags.py#L246-L321

Actually there is no vips in network metadata

[root@nailgun ~]# fuel nodes
id | status | name | cluster | ip | mac | roles | pending_roles | online | group_id
---+--------+-------------------------+---------+-------------+-------------------+----------------+---------------+--------+---------
 1 | error | slave-01_controller_new | 1 | 10.109.10.4 | 64:2a:3e:e5:a3:88 | controller_new | | 1 | 1

controller_new - looks pretty strange.

Here is where it is from:
2017-03-14 21:46:28.309 DEBUG [7f6e5d038880] (logger) Request POST /api/releases/2/roles from 10.109.10.1:59052 {"meta": {"group": "base", "description": "New controller role", "weight": 10, "tags": ["controller", "database", "keystone", "neutron", "new_tag"], "conflicts": ["compute"], "public_for_dvr_required": true, "name": "Controller_new", "update_required": ["compute", "cinder"], "public_ip_required": true}, "name": "controller_new", "volumes_roles_mapping": [{"id": "os", "allocate_size": "min"}, {"id": "logs", "allocate_size": "min"}, {"id": "image", "allocate_size": "all"}, {"id": "mysql", "allocate_size": "min"}, {"id": "horizon", "allocate_size": "min"}]}
2017-03-14 21:46:28.360 DEBUG [7f6e5d038880] (logger) Response code '201 Created' for POST /api/releases/2/roles from 10.109.10.1:59052

Aha, here it is
https://github.com/openstack/fuel-qa/blob/stable/newton/fuelweb_test/tests/tests_lcm/test_tags.py#L196

The reason is that
https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/objects/cluster.py#L1009
uses hardcoded role name rather than tags.

So, by now the workaround is "do not rename controller role" :)

Fix proposed to branch: master
Review: https://review.openstack.org/447417

Reviewed: https://review.openstack.org/447417
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=fba3bc344523da0d43f94e130b4944efe0d32529
Submitter: Jenkins
Branch: master

commit fba3bc344523da0d43f94e130b4944efe0d32529
Author: Georgy Kibardin <email address hidden>
Date: Mon Mar 20 11:59:21 2017 +0300

    Use tags instead of roles

    Now the deployment behaviour is driven by tags rather than role names, i.e. role
    name cannot be relied upon.

    Change-Id: Icfabeeb0b7fb6a9d697a09c3cf1fa020bbd4c323
    Closes-Bug: #1669743

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/449594

Reviewed: https://review.openstack.org/449594
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=72eaa18921a5dce874eeca0003b100311a552f50
Submitter: Jenkins
Branch: stable/newton

commit 72eaa18921a5dce874eeca0003b100311a552f50
Author: Georgy Kibardin <email address hidden>
Date: Mon Mar 20 11:59:21 2017 +0300

    Use tags instead of roles

    Now the deployment behaviour is driven by tags rather than role names, i.e. role
    name cannot be relied upon.

    Change-Id: Icfabeeb0b7fb6a9d697a09c3cf1fa020bbd4c323
    Closes-Bug: #1669743
    (cherry picked from commit fba3bc344523da0d43f94e130b4944efe0d32529)

Verified on Newton #1566 iso.

Passed test:
https://product-ci.infra.mirantis.net/job/10.0.system_test.ubuntu.test_tags/52/