portbinding update fails with ObjectDeletedError

From what I'm seeing this started on 3/2:

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22ObjectDeletedError%3A%20Instance%5C%22%20AND%20message%3A%5C%22PortBinding%20at%5C%22%20AND%20message%3A%5C%22has%20been%20deleted%2C%20or%20its%20row%20is%20otherwise%20not%20present.%5C%22%20AND%20tags%3A%5C%22screen-q-svc.txt%5C%22&from=10d

Actually I think it goes back further than 3/2. Ihar pointed this out in IRC:

https://review.openstack.org/#/c/423581/6

From looking at the logstash results, it shows up a lot in successful runs too so it's probably not causing failures, but it shows up in a lot of the runs so there is a problem to be solved with updating/deleting ports.

I don't think the locked_port_and_binding change will have had an impact. This exception is being thrown after the transaction is closed so the lock would have been released.

Fix proposed to branch: master
Review: https://review.openstack.org/441231

Reviewed: https://review.openstack.org/441231
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fc563eaabec392281be90bd2472bed4f6506cb40
Submitter: Jenkins
Branch: master

commit fc563eaabec392281be90bd2472bed4f6506cb40
Author: Kevin Benton <email address hidden>
Date: Fri Mar 3 08:51:33 2017 -0800

    deepcopy binding and binding levels avoid expiration

    Perform a deepcopy on the sqla objects passed into the PortContext
    so we get detached versions of them safe to reference forever.
    This is necessary because the PortContexts outlive the
    transaction context managers they are creating in which means an
    object can be expired and result in a query after a commit
    (e.g. in bind_port_if_needed) that will fail and result in an
    exception.

    This required a few additional explicit session.merge calls to deal
    with cases where touching the mech context was implicitly expected
    to modify the DB state on the next commit.

    Closes-Bug: #1669528
    Change-Id: Ib5ba2daa80acba53c082bade1f61a3ee44ca41fc

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/470268

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/470297

Reviewed: https://review.openstack.org/470297
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cb773098d276cfbabc600361e91cb709ec846ba8
Submitter: Jenkins
Branch: stable/newton

commit cb773098d276cfbabc600361e91cb709ec846ba8
Author: Kevin Benton <email address hidden>
Date: Fri Mar 3 08:51:33 2017 -0800

    deepcopy binding and binding levels avoid expiration

    Perform a deepcopy on the sqla objects passed into the PortContext
    so we get detached versions of them safe to reference forever.
    This is necessary because the PortContexts outlive the
    transaction context managers they are creating in which means an
    object can be expired and result in a query after a commit
    (e.g. in bind_port_if_needed) that will fail and result in an
    exception.

    This required a few additional explicit session.merge calls to deal
    with cases where touching the mech context was implicitly expected
    to modify the DB state on the next commit.

    Conflicts:
     neutron/plugins/ml2/driver_context.py
     neutron/plugins/ml2/plugin.py
     neutron/tests/unit/plugins/ml2/test_port_binding.py

    Closes-Bug: #1669528
    Change-Id: Ib5ba2daa80acba53c082bade1f61a3ee44ca41fc
    (cherry picked from commit 20c1de9dc83875431e8bf995f3f4f85bd6d81955)

Change abandoned by Jakub Libosvar (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/470268
Reason: Abandoned as per Kevin's comments.

This issue was fixed in the openstack/neutron 9.4.1 release.