missing footprint when importing netlist in pcbnew not very clear

Bug #1669020 reported by kerr smith
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Undecided
Unassigned

Bug Description

This is not really a bug but I thought it may be helpful. I am running Windows 7 64bit nightly 7601 - I have not updated in a couple of weeks as I am in the middle of a project and did not want to risk it.

When I recently completed a schematic I made some changes and then re-imported the netlist in to pcbnew and all looked fine. Unfortunately I did not notice that one of the footprints must have been renamed in the Github repository. This missing footprint did generate an error in the netlist window but it zoomed of the screen so fast I did not see it. This resulted in me having a missing component on my board without realising it.

I think it may be helpful in these cases if there was maybe a popup warning box saying that a footprint could not be found so you do not accidentally miss these errors.

I know there are filters on the bottom of the netlist window but by default 'All' is ticked and I had never thought to touch this as I have not had this happen before.

This is just a thought that I was thinking may be helpful so if this ever happens it would be clearer that a component footprint was now missing on your board.

Revision history for this message
Nick Østergaard (nickoe) wrote :

When is this popup supposed to appear?
Did the DRC not catch it?

Revision history for this message
kerr smith (kerrsmithusa) wrote :

No, the DRC check did not catch it - I only noticed the missing component as it happened to be one of only a couple of through hole components on my mostly surface mount PCB. I was just doing a final check manually to make sure all the through hole capacitors were placed with enough space around them and I noticed one was missing.

I thought that maybe a warning should popup right after the netlist import if there was an error (this could be for any error, not just this one) - the error does show in the netlist box but moves extremely quickly off the top of the screen and unless you scroll up through the messages it is very easy to miss. The popup would make you aware that an error had occurred so you do not miss it by mistake.

Revision history for this message
Jeff Young (jeyjey) wrote :

The DRC issue is recorded here: https://bugs.launchpad.net/kicad/+bug/1685516

Revision history for this message
Jeff Young (jeyjey) wrote :

Added error and warning badges to the checkboxes below the dialog so they can't be missed even if they scroll off the top.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 1669020] Re: missing footprint when importing netlist in pcbnew not very clear

@Jeff, I noticed you are using a fixed size hard coded font in this
patch. I prefer that KiCad use wxSystemSettings::GetFont(
wxSYS_SYSTEM_FONT or wxSYS_DEFAULT_GUI_FONT ) to fetch the font used by
UI controls. KiCad shouldn't change the users preferred UI font unless
there is a really good reason to do so.

On 2/19/2018 8:41 PM, Jeff Young wrote:
> Added error and warning badges to the checkboxes below the dialog so
> they can't be missed even if they scroll off the top.
>
> ** Patch added: "0006-Added-error-and-warning-badges-to-HTML-report-panel.patch"
> https://bugs.launchpad.net/kicad/+bug/1669020/+attachment/5058588/+files/0006-Added-error-and-warning-badges-to-HTML-report-panel.patch
>

Revision history for this message
Jeff Young (jeyjey) wrote :

I started out with wxSYS_SYSTEM_FONT size - 2, but then we don’t have any guarantee that it will fit in the circle. (Note that we decrease the size yet again if the number is 3 digits.)

I agree that I don’t like hard-coding any sizes, but this seemed like a reasonable place for it.

> On 20 Feb 2018, at 21:15, Wayne Stambaugh <email address hidden> wrote:
>
> @Jeff, I noticed you are using a fixed size hard coded font in this
> patch. I prefer that KiCad use wxSystemSettings::GetFont(
> wxSYS_SYSTEM_FONT or wxSYS_DEFAULT_GUI_FONT ) to fetch the font used by
> UI controls. KiCad shouldn't change the users preferred UI font unless
> there is a really good reason to do so.
>
> On 2/19/2018 8:41 PM, Jeff Young wrote:
>> Added error and warning badges to the checkboxes below the dialog so
>> they can't be missed even if they scroll off the top.
>>
>> ** Patch added: "0006-Added-error-and-warning-badges-to-HTML-report-panel.patch"
>> https://bugs.launchpad.net/kicad/+bug/1669020/+attachment/5058588/+files/0006-Added-error-and-warning-badges-to-HTML-report-panel.patch
>>
>
> --
> You received this bug notification because you are a member of KiCad Bug
> Squad, which is subscribed to KiCad.
> https://bugs.launchpad.net/bugs/1669020
>
> Title:
> missing footprint when importing netlist in pcbnew not very clear
>
> Status in KiCad:
> New
>
> Bug description:
> This is not really a bug but I thought it may be helpful. I am running
> Windows 7 64bit nightly 7601 - I have not updated in a couple of weeks
> as I am in the middle of a project and did not want to risk it.
>
> When I recently completed a schematic I made some changes and then re-
> imported the netlist in to pcbnew and all looked fine. Unfortunately I
> did not notice that one of the footprints must have been renamed in
> the Github repository. This missing footprint did generate an error in
> the netlist window but it zoomed of the screen so fast I did not see
> it. This resulted in me having a missing component on my board without
> realising it.
>
> I think it may be helpful in these cases if there was maybe a popup
> warning box saying that a footprint could not be found so you do not
> accidentally miss these errors.
>
> I know there are filters on the bottom of the netlist window but by
> default 'All' is ticked and I had never thought to touch this as I
> have not had this happen before.
>
> This is just a thought that I was thinking may be helpful so if this
> ever happens it would be clearer that a component footprint was now
> missing on your board.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/kicad/+bug/1669020/+subscriptions

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@Jeff, I merged this patch as is. If there are font sizing issues with
this, we can address it later. Thanks.

On 02/19/2018 08:41 PM, Jeff Young wrote:
> Added error and warning badges to the checkboxes below the dialog so
> they can't be missed even if they scroll off the top.
>
> ** Patch added: "0006-Added-error-and-warning-badges-to-HTML-report-panel.patch"
> https://bugs.launchpad.net/kicad/+bug/1669020/+attachment/5058588/+files/0006-Added-error-and-warning-badges-to-HTML-report-panel.patch
>

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 900bd9da68b5b62b36ea6e13bf1addcad4b2d14e
https://git.launchpad.net/kicad/patch/?id=900bd9da68b5b62b36ea6e13bf1addcad4b2d14e

Changed in kicad:
status: New → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.