Missing inspect-internal command

Bug #1665701 reported by Joshua Powers
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
btrfs-progs (Ubuntu)
Won't Fix
Undecided
Unassigned
Xenial
Won't Fix
Undecided
Unassigned
Yakkety
Won't Fix
Undecided
Unassigned
curtin (Ubuntu)
Fix Released
Medium
Unassigned
Xenial
Fix Released
Medium
Unassigned
Yakkety
Fix Released
Medium
Unassigned

Bug Description

==== Begin Curtin SRU Template ====
[Impact]
This change is actually only a test change.
Vmtest does an instllation to a btrfs device and then boots into the
installed system and collects information to verify that the install
worked properly. That collection of information was using
 btrfs-show-super (<yakkety) or btrfs-inspect-internal (yakkety).

Neither of those programs are available in zesty, so we have adjusted
the collection to use btrfs-show-super or btrfs-debug-tree (which is
also available in yakkety).

[Test Case]
Run curtin vmtest on tests/vmtests/test_iscsi.py.
 ./tools/jenkins-runner tests/vmtests/test_nvme.py tests/vmtests/test_basic.py

Those tests excercise the installation to btrfs and collection of information
in Trusty, Xenial, Yakkety, Zesty.

[Regression Potential]
This fix was test-only. There were no changes made to the runtime path of
curtin for this fix.

==== End Curtin SRU Template ====

btrfs-progs in Zesty (7.9.1-1) is missing the the btrfs-inspect-internal binary. btrfs-inspect-internal replaces the btrfs-show-super command, which is present in Yakkety, but again neither is in Zesty.

Also note that the man pages for both are present in Zesty.

Related branches

Revision history for this message
Ryan Harper (raharper) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in btrfs-progs (Ubuntu):
status: New → Confirmed
tags: added: zesty
tags: added: rls-z-incoming
Scott Moser (smoser)
Changed in curtin (Ubuntu):
status: New → Fix Released
importance: Undecided → Medium
Changed in curtin (Ubuntu Xenial):
status: New → Confirmed
importance: Undecided → Medium
Changed in curtin (Ubuntu Yakkety):
status: New → Confirmed
importance: Undecided → Medium
Scott Moser (smoser)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Joshua, or anyone else affected,

Accepted curtin into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/curtin/0.1.0~bzr470-0ubuntu1~16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in curtin (Ubuntu Yakkety):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Joshua, or anyone else affected,

Accepted curtin into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/curtin/0.1.0~bzr470-0ubuntu1~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in curtin (Ubuntu Xenial):
status: Confirmed → Fix Committed
Revision history for this message
Joshua Powers (powersj) wrote :

Test change, looked at source and verified locally on both packages.

tags: added: verification-done verification-done-xenial verification-done-yakkety
removed: verification-needed
Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Scott Moser (smoser) wrote :

Ubuntu server jenkins now runs integration tests with for xenial-proposed.
It's latest run at [1] passed and ran the tests listed below that verify
this bug if fixed.

  bug 1645515 tests/vmtests/test_iscsi.py
  bug 1665701 tests/vmtests/test_nvme.py tests/vmtests/test_basic.py

I've attached 2 files for posterity
  curtin-vmtest-proposed-x-22-archive.zip
  curtin-vmtest-proposed-x-22-console.log
artifacts of curtin vmtest-proposed-x build 22

You can verify that the installation of curtin used the version shown by:
$ grep -r "Installation started" archive/ | head -n 1
archive/output/ZestyTestNetworkIPV6Vlan/logs/install-serial.log:[ 9.954624] cloud-init[1518]: curtin: Installation started. (0.1.0~bzr470-0ubuntu1~16.04.1)

--
[1] https://jenkins.ubuntu.com/server/view/Curtin/job/curtin-vmtest-proposed-x/22/

Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Scott Moser (smoser) wrote :

Ubuntu server jenkins now runs integration tests with for yakkety-proposed.
It's latest run at [1] passed and ran the tests listed below that verify
this bug if fixed.

  bug 1645515 tests/vmtests/test_iscsi.py
  bug 1665701 tests/vmtests/test_nvme.py tests/vmtests/test_basic.py

I've attached 2 files for posterity
  curtin-vmtest-proposed-y-23-archive.zip
  curtin-vmtest-proposed-y-23-console.log
artifacts of curtin vmtest-proposed-y build 23

You can verify that the installation of curtin used the version shown by:
$ grep -r "Installation started" archive/ | head -n 1
archive/output/ZestyTestNetworkIPV6Vlan/logs/install-serial.log:[ 10.529395] cloud-init[1503]: curtin: Installation started. (0.1.0~bzr470-0ubuntu1~16.10.1)

--
[1] https://jenkins.ubuntu.com/server/view/Curtin/job/curtin-vmtest-proposed-y/23/

tags: removed: verification-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package curtin - 0.1.0~bzr470-0ubuntu1~16.04.1

---------------
curtin (0.1.0~bzr470-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

  * debian/rules: record debian package version in installed package.
    (LP: #1666986)
  * New upstream snapshot.
    - vmtest: allow time-based skipping of tests, apply to ZestyMdadmBcache
      to temporarily avoid bug 1667078.
    - Add iSCSI disk support. (LP: #1645515)
    - vmtest: handle change in btrfs-progs when finding fs UUID. (LP: #1665701)
    - pycodestyle: fix bare except in vmtests
    - unittests: add subp coverage for retries, and rcs
    - reporting: Add better descriptions and granularity of events
    - tox: do not bother with pep8 from trusty in trusty-check
    - tests: add two scripts used for running vmtest with installed package.
    - Make add-apt-repository command retry
    - Add tests for network bridging configuration

 -- Scott Moser <email address hidden> Wed, 01 Mar 2017 11:13:58 -0500

Changed in curtin (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for curtin has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package curtin - 0.1.0~bzr470-0ubuntu1~16.10.1

---------------
curtin (0.1.0~bzr470-0ubuntu1~16.10.1) yakkety-proposed; urgency=medium

  * debian/rules: record debian package version in installed package.
    (LP: #1666986)
  * New upstream snapshot.
    - vmtest: allow time-based skipping of tests, apply to ZestyMdadmBcache
      to temporarily avoid bug 1667078.
    - Add iSCSI disk support. (LP: #1645515)
    - vmtest: handle change in btrfs-progs when finding fs UUID. (LP: #1665701)
    - pycodestyle: fix bare except in vmtests
    - unittests: add subp coverage for retries, and rcs
    - reporting: Add better descriptions and granularity of events
    - tox: do not bother with pep8 from trusty in trusty-check
    - tests: add two scripts used for running vmtest with installed package.
    - Make add-apt-repository command retry
    - Add tests for network bridging configuration

 -- Scott Moser <email address hidden> Wed, 01 Mar 2017 11:17:12 -0500

Changed in curtin (Ubuntu Yakkety):
status: Fix Committed → Fix Released
tags: added: rls-aa-incoming
removed: rls-z-incoming
Revision history for this message
Steve Langasek (vorlon) wrote :

sounds like this compatibility issue has been resolved on the curtin side and that this command is no longer present upstream, so there is no change to be made to the btrfs-progs side.

Changed in btrfs-progs (Ubuntu):
status: Confirmed → Won't Fix
Changed in btrfs-progs (Ubuntu Xenial):
status: New → Won't Fix
Changed in btrfs-progs (Ubuntu Yakkety):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.