Libertine

Allow installing multiple packages at the same time

Bug #1665647 reported by Christopher Townsend on 2017-02-17

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Libertine	Status tracked in Devel
Devel	Fix Released	Low	Christopher Townsend	Libertine 1.7
Trunk	Fix Released	Low	Christopher Townsend	Libertine 1.7
libertine (Ubuntu)	Fix Released	Low	Christopher Townsend

Bug Description

Currently, only a single package can be installed per libertine-container-manager command. It would be better if we supported allowing installing multiple packages on the same command.

For example,

'libertine-container-manager install-package -p foo -p bar -p baz'

We should also consider allowing the use of a file with a list packages to be used too.

Related branches

lp:~townsend/libertine/install-remove-multiple-packages

Merged into lp:libertine at revision 425

Larry Price: Approve on 2017-03-02

Libertine CI Bot: Approve (continuous-integration) on 2017-03-02

lp:~townsend/libertine/1.7-release

Merged into lp:libertine/trunk at revision 194

Larry Price: Approve on 2017-03-06

Diff: 6192 lines (+2021/-1733)

78 files modified

.bzrignore (+1/-2)
CMakeLists.txt (+1/-1)
common/CMakeLists.txt (+3/-2)
common/ContainerAppsList.cpp (+6/-8)
common/ContainerAppsList.h (+7/-10)
common/ContainerArchivesList.cpp (+7/-7)
common/ContainerArchivesList.h (+5/-8)
common/ContainerBindMountsList.cpp (+87/-0)
common/ContainerBindMountsList.h (+76/-0)
common/ContainerConfig.cpp (+0/-513)
common/ContainerConfig.h (+0/-153)
common/ContainerConfigList.cpp (+74/-160)
common/ContainerConfigList.h (+29/-25)
common/ContainerManager.cpp (+20/-20)
common/ContainerManager.h (+4/-4)
common/ContainerOperationDetails.cpp (+25/-57)
common/ContainerOperationDetails.h (+9/-9)
common/ContainersConfig.cpp (+212/-0)
common/ContainersConfig.h (+108/-0)
debian/changelog (+41/-0)
debian/control (+8/-5)
debian/libertined.preinst (+24/-0)
debian/libertined.prerm (+24/-0)
debian/python3-libertine.install (+1/-0)
libertine/CMakeLists.txt (+1/-3)
libertine/libertine.cpp (+8/-7)
libertine/libertine.h (+5/-3)
liblibertine/libertined.cpp (+19/-15)
python/libertine/ChrootContainer.py (+1/-1)
python/libertine/Client.py (+70/-0)
python/libertine/ContainersConfig.py (+25/-17)
python/libertine/HostInfo.py (+8/-5)
python/libertine/Libertine.py (+18/-5)
python/libertine/LxcContainer.py (+39/-46)
python/libertine/LxdContainer.py (+187/-93)
python/libertine/__init__.py (+3/-3)
python/libertine/launcher/session.py (+20/-7)
python/libertine/service/manager.py (+15/-22)
python/libertine/service/operations_state.py (+75/-0)
python/libertine/service/task_dispatcher.py (+19/-0)
python/libertine/service/tasks/base_task.py (+1/-1)
python/libertine/service/tasks/create_task.py (+4/-2)
python/libertine/utils.py (+17/-13)
qml/common/AddBindMountDialog.qml (+27/-0)
qml/common/AddExtraArchiveView.qml (+1/-1)
qml/common/ContainerEditView.qml (+29/-19)
qml/common/ContainerInfoView.qml (+25/-7)
qml/common/ContainerOptionsDialog.qml (+4/-4)
qml/common/ContainersList.qml (+53/-10)
qml/common/DebianPackagePicker.qml (+1/-1)
qml/common/ExtraArchivesView.qml (+4/-3)
qml/common/ExtraBindMountsView.qml (+110/-0)
qml/common/ManageContainer.qml (+49/-10)
qml/common/PackageInfoView.qml (+4/-50)
qml/common/SearchPackagesDialog.qml (+5/-7)
qml/common/SearchResults.qml (+5/-5)
qml/common/SearchResultsView.qml (+14/-16)
qml/gui/ContainersView.qml (+1/-0)
qml/gui/WelcomeView.qml (+0/-80)
qml/gui/libertine.qml (+36/-20)
qml/plugin/MainSettingsPage.qml (+5/-4)
setup/gui/libertine-manager-app.desktop (+0/-12)
snap/gui/libertine-manager-app.desktop (+12/-0)
snap/plugins/x-libertine-deps.py (+4/-1)
snap/snap-runner.wrapper (+1/-1)
snapcraft.yaml (+23/-10)
system-settings-plugin/plugin.cpp (+6/-8)
tests/integration/CMakeLists.txt (+2/-2)
tests/integration/test_libertine_service.py (+3/-4)
tests/unit/CMakeLists.txt (+1/-1)
tests/unit/ContainerConfigListTests.cpp (+2/-2)
tests/unit/ContainerConfigTests.cpp (+0/-127)
tests/unit/ContainersConfigTests.cpp (+154/-0)
tools/completions/libertine-container-manager (+1/-1)
tools/libertine-container-manager (+113/-89)
tools/libertine-container-manager.1 (+13/-8)
tools/libertine-launch (+2/-2)
tools/libertined (+4/-1)

lp:~ci-train-bot/libertine/libertine-ubuntu-zesty-2542 (Merged)

Christopher Townsend (townsend) on 2017-02-17

Changed in libertine (Ubuntu):
status:	New → Triaged
importance:	Undecided → Low

Revision history for this message

doniks (kaabud-lp) wrote on 2017-02-17:

Or maybe:

'libertine-container-manager install-package -p foo bar baz'

or, all the way:

'libertine-container-manager install foo bar baz'

Revision history for this message

Libertine CI Bot (libertine-ci-bot) wrote on 2017-03-02:

Fix committed into lp:libertine at revision 425, scheduled for release in libertine, milestone Unknown

Changed in libertine:
status:	In Progress → Fix Committed

Christopher Townsend (townsend) on 2017-03-06

Changed in libertine (Ubuntu):
status:	Triaged → In Progress
assignee:	nobody → Christopher Townsend (townsend)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2017-03-09:

This bug was fixed in the package libertine - 1.7+17.04.20170308-0ubuntu1

---------------
libertine (1.7+17.04.20170308-0ubuntu1) zesty; urgency=medium

  [ Chris Townsend ]
  * Fix libertined such that it can probe for currently running X apps and
    rebuild application running state. (LP: #1637579)
  * Gracefully handle the case where an application does not start.
    (LP: #1666177)
  * Kill the libertined service during the libertined package removal and
    upgrades (LP: #1667368)
  * Refactor package operation details into container operation details.
  * Allowing specifying multiple packages to be installed or removed.
    (LP: #1665647)
  * Show the current container state in the 'Status' section of the
    Container Info page in the UI. (LP: #1667726)
  * Add ability to configure stopping or freezing a container from within
    the UI. (LP: #1667717)
  * Bump version to 1.7.

  [ Larry Price ]
  * Prevent rewriting existing data in ContainersConfig. (LP: #1659115)
  * Prevent staging libertine files when installing dependencies and fix
    deprecations for the snap.
  * Use AdaptivePageLayout instead of PageStack for app navigation.
    (LP: #1550365) (LP: #1659076)
  * Refactor ContainersConfig handling from the GUI.
  * Prevent removing container from the database when destroy fails.
  * Various fixes for getting the confined snap working with libertined.
  * Remove /Progress objects from d-bus connection during cleanup.
  * LXD container status will override d-bus result during destroy only.
  * Implement GUI for adding and removing bind-mounts in containers.
  * Use a decorator to refresh the database during any libertined operations
    involving ContainersConfig.
  * Fix any broken symlinks in the local lxd rootfs during update and package
    installation. (LP: #1659646)
  * Update the default container type to lxd. (LP: #1665645)
  * Properly remove bind-mounted files in local rootfs during lxd destroy.
  * Add container hostname to /etc/hosts in lxd containers.
  * Add a force option for destroying running containers.

-- Christopher Townsend <email address hidden> Wed, 08 Mar 2017 14:53:46 +0000

This bug was fixed in the package libertine - 1.7+17.04.20170308-0ubuntu1

---------------
libertine (1.7+17.04.20170308-0ubuntu1) zesty; urgency=medium

-- Christopher Townsend <christopher.townsend@canonical.com>  Wed, 08 Mar 2017 14:53:46 +0000

Changed in libertine (Ubuntu):
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.